interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Made uiFree(NULL) illegal to spot bugs.

This commit is contained in:
Pietro Gagliardi 2015-05-07 17:45:34 -04:00
parent d853da9028
commit 727b6871bc
4 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
TODO.md
View File

@ -1,4 +1,3 @@
- forbid free(NULL) to check for bugs
- opposite side alignment control in uiBox - opposite side alignment control in uiBox
- disabling containers on wine doesn't redraw children as disabled - disabling containers on wine doesn't redraw children as disabled
- test on real windows - test on real windows

2
darwin/alloc.m
View File

@ -49,6 +49,6 @@ void *uiRealloc(void *p, size_t new)
void uiFree(void *p) void uiFree(void *p)
{ {
if (p == NULL) if (p == NULL)
return; complain("attempt to uiFree(NULL); there's a bug somewhere");
free(BASE(p)); free(BASE(p));
} }

2
unix/alloc.c
View File

@ -39,5 +39,7 @@ void *uiRealloc(void *p, size_t new)
void uiFree(void *p) void uiFree(void *p)
{ {
if (p == NULL)
complain("attempt to uiFree(NULL); there's a bug somewhere");
g_free(BASE(p)); g_free(BASE(p));
} }

2
windows/alloc.c
View File

@ -44,7 +44,7 @@ void *uiRealloc(void *p, size_t size)
void uiFree(void *p) void uiFree(void *p)
{ {
if (p == NULL) if (p == NULL)
return; complain("attempt to uiFree(NULL); there's a bug somewhere");
if (HeapFree(heap, 0, p) == 0) if (HeapFree(heap, 0, p) == 0)
logLastError("error freeing memory in uiFree()"); logLastError("error freeing memory in uiFree()");
} }