interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TODO consolidation.

This commit is contained in:
Pietro Gagliardi 2015-04-30 17:34:15 -04:00
parent 75b4d28569
commit 6400a6ea8c
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
TODO.md
View File

@ -21,6 +21,9 @@
- disabling containers on wine doesn't redraw children as disabled - disabling containers on wine doesn't redraw children as disabled
- test on real windows - test on real windows
- collapse multiple consecutive menu separators? - collapse multiple consecutive menu separators?
- including for quit/preferences/about?
- or not even have separators there?
- in which case, hide leading or trailing separators?
ultimately: ultimately:
- add some sort of runtime type checking - add some sort of runtime type checking

3
unix/menu.c
View File

@ -197,7 +197,6 @@ uiMenuItem *menuAppendQuitItem(uiMenu *mm)
if (hasQuit) if (hasQuit)
complain("attempt to add multiple Quit menu items"); complain("attempt to add multiple Quit menu items");
hasQuit = TRUE; hasQuit = TRUE;
// TODO conditionally add separator
newItem((struct menu *) mm, typeSeparator, NULL); newItem((struct menu *) mm, typeSeparator, NULL);
return newItem((struct menu *) mm, typeQuit, NULL); return newItem((struct menu *) mm, typeQuit, NULL);
} }
@ -207,7 +206,6 @@ uiMenuItem *menuAppendPreferencesItem(uiMenu *mm)
if (hasPreferences) if (hasPreferences)
complain("attempt to add multiple Preferences menu items"); complain("attempt to add multiple Preferences menu items");
hasPreferences = TRUE; hasPreferences = TRUE;
// TODO conditionally add separator
newItem((struct menu *) mm, typeSeparator, NULL); newItem((struct menu *) mm, typeSeparator, NULL);
return newItem((struct menu *) mm, typePreferences, NULL); return newItem((struct menu *) mm, typePreferences, NULL);
} }
@ -217,7 +215,6 @@ uiMenuItem *menuAppendAboutItem(uiMenu *mm)
if (hasAbout) if (hasAbout)
complain("attempt to add multiple About menu items"); complain("attempt to add multiple About menu items");
hasAbout = TRUE; hasAbout = TRUE;
// TODO conditionally add separator
newItem((struct menu *) mm, typeSeparator, NULL); newItem((struct menu *) mm, typeSeparator, NULL);
return newItem((struct menu *) mm, typeAbout, NULL); return newItem((struct menu *) mm, typeAbout, NULL);
} }

3
windows/menu.c
View File

@ -181,7 +181,6 @@ uiMenuItem *menuAppendCheckItem(uiMenu *mm, const char *name)
uiMenuItem *menuAppendQuitItem(uiMenu *mm) uiMenuItem *menuAppendQuitItem(uiMenu *mm)
{ {
// TODO check multiple quit items // TODO check multiple quit items
// TODO conditionally add separator
newItem((struct menu *) mm, typeSeparator, NULL); newItem((struct menu *) mm, typeSeparator, NULL);
return newItem((struct menu *) mm, typeQuit, NULL); return newItem((struct menu *) mm, typeQuit, NULL);
} }
@ -189,7 +188,6 @@ uiMenuItem *menuAppendQuitItem(uiMenu *mm)
uiMenuItem *menuAppendPreferencesItem(uiMenu *mm) uiMenuItem *menuAppendPreferencesItem(uiMenu *mm)
{ {
// TODO check multiple preferences items // TODO check multiple preferences items
// TODO conditionally add separator
newItem((struct menu *) mm, typeSeparator, NULL); newItem((struct menu *) mm, typeSeparator, NULL);
return newItem((struct menu *) mm, typePreferences, NULL); return newItem((struct menu *) mm, typePreferences, NULL);
} }
@ -197,7 +195,6 @@ uiMenuItem *menuAppendPreferencesItem(uiMenu *mm)
uiMenuItem *menuAppendAboutItem(uiMenu *mm) uiMenuItem *menuAppendAboutItem(uiMenu *mm)
{ {
// TODO check multiple about items // TODO check multiple about items
// TODO conditionally add separator
newItem((struct menu *) mm, typeSeparator, NULL); newItem((struct menu *) mm, typeSeparator, NULL);
return newItem((struct menu *) mm, typeAbout, NULL); return newItem((struct menu *) mm, typeAbout, NULL);
} }