interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed a stale TODO.

This commit is contained in:
Pietro Gagliardi 2015-05-06 18:56:12 -04:00
parent 329b4f29dd
commit 5b65c58715
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
TODO.md
View File

@ -41,7 +41,7 @@
- determine whether or not margins count in preferredSize() when there is no main control - determine whether or not margins count in preferredSize() when there is no main control
- menu item state change while the menu is visible (not in response to user action) - menu item state change while the menu is visible (not in response to user action)
- OS X: requires an [NSMenu update] call after changing state - OS X: requires an [NSMenu update] call after changing state
- Windows: requires getting current menu state when amending it; see relevant line in windows/menu.c - Windows: requires getting current menu state when amending it in sync()
- figure out where we should return HRESULTs - figure out where we should return HRESULTs
- Windows: don't abort if a cleanup function fails? - Windows: don't abort if a cleanup function fails?
- should uiWindowOnClosing() really return an int? - should uiWindowOnClosing() really return an int?

1
windows/menu.c
View File

@ -48,7 +48,6 @@ static void sync(struct menuItem *item)
uintmax_t i; uintmax_t i;
MENUITEMINFOW mi; MENUITEMINFOW mi;
// TODO do we need to get the current state and amend it?
ZeroMemory(&mi, sizeof (MENUITEMINFOW)); ZeroMemory(&mi, sizeof (MENUITEMINFOW));
mi.cbSize = sizeof (MENUITEMINFOW); mi.cbSize = sizeof (MENUITEMINFOW);
mi.fMask = MIIM_STATE; mi.fMask = MIIM_STATE;