From 544987f19a59a0e2d419e0a1c01472cba67d11f1 Mon Sep 17 00:00:00 2001 From: Ian Bastos Date: Sun, 12 Jan 2020 03:17:26 +0000 Subject: [PATCH] render multiline text white on dark mode - darwin --- darwin/multilineentry.m | 19 +++++++++++++++++-- darwin/util.h | 2 ++ darwin/util.m | 6 ++++++ 3 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 darwin/util.h diff --git a/darwin/multilineentry.m b/darwin/multilineentry.m index d57284a0..a03c73e8 100644 --- a/darwin/multilineentry.m +++ b/darwin/multilineentry.m @@ -1,10 +1,11 @@ // 8 december 2015 #import "uipriv_darwin.h" +#include "util.h" // NSTextView has no intrinsic content size by default, which wreaks havoc on a pure-Auto Layout system // we'll have to take over to get it to work // see also http://stackoverflow.com/questions/24210153/nstextview-not-properly-resizing-with-auto-layout and http://stackoverflow.com/questions/11237622/using-autolayout-with-expanding-nstextviews -@interface intrinsicSizeTextView : NSTextView { +@interface intrinsicSizeTextView : NSTextView { uiMultilineEntry *libui_e; } - (id)initWithFrame:(NSRect)r e:(uiMultilineEntry *)e; @@ -25,11 +26,19 @@ struct uiMultilineEntry { - (id)initWithFrame:(NSRect)r e:(uiMultilineEntry *)e { self = [super initWithFrame:r]; + self.delegate = self; if (self) self->libui_e = e; return self; } +- (void)textDidChange:(NSNotification *)aNotification { + NSTextView *tv = (NSTextView *)[aNotification object]; + if (isDarkMode()) { + [tv setTextColor:[NSColor whiteColor]]; + } +} + - (NSSize)intrinsicContentSize { NSTextContainer *textContainer; @@ -130,7 +139,6 @@ static uiMultilineEntry *finishMultilineEntry(BOOL hscroll) // NSText properties: // this is what Interface Builder sets the background color to - [e->tv setBackgroundColor:[NSColor colorWithCalibratedWhite:1.0 alpha:1.0]]; [e->tv setDrawsBackground:YES]; [e->tv setEditable:YES]; [e->tv setSelectable:YES]; @@ -139,6 +147,13 @@ static uiMultilineEntry *finishMultilineEntry(BOOL hscroll) [e->tv setImportsGraphics:NO]; [e->tv setUsesFontPanel:NO]; [e->tv setRulerVisible:NO]; + + if (isDarkMode()) { + [e->tv setBackgroundColor:[NSColor windowBackgroundColor]]; + } else { + [e->tv setBackgroundColor:[NSColor colorWithCalibratedWhite:1.0 alpha:1.0]]; + } + // we'll handle font last // while setAlignment: has been around since 10.0, the named constant "NSTextAlignmentNatural" seems to have only been introduced in 10.11 #define ourNSTextAlignmentNatural 4 diff --git a/darwin/util.h b/darwin/util.h new file mode 100644 index 00000000..1b539370 --- /dev/null +++ b/darwin/util.h @@ -0,0 +1,2 @@ + +bool isDarkMode(); diff --git a/darwin/util.m b/darwin/util.m index 418d958e..be392731 100644 --- a/darwin/util.m +++ b/darwin/util.m @@ -14,3 +14,9 @@ void uiprivDisableAutocorrect(NSTextView *tv) [tv setAutomaticLinkDetectionEnabled:NO]; [tv setSmartInsertDeleteEnabled:NO]; } + +bool isDarkMode() +{ + NSString *osxMode = [[NSUserDefaults standardUserDefaults] stringForKey:@"AppleInterfaceStyle"]; + return [osxMode isEqualToString:@"Dark"]; +}