interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor TODO resolution.

This commit is contained in:
Pietro Gagliardi 2018-06-24 14:46:24 -04:00
parent f3882d6124
commit 4ed6e3ec8a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
darwin/tablecolumn.m
View File

@ -43,7 +43,7 @@ struct textColumnCreateParams {
int textEditableModelColumn; int textEditableModelColumn;
uiTableTextColumnOptionalParams textParams; uiTableTextColumnOptionalParams textParams;
BOOL makeImage; BOOL makeImageView;
int imageModelColumn; int imageModelColumn;
BOOL makeCheckbox; BOOL makeCheckbox;
@ -121,8 +121,7 @@ struct textColumnCreateParams {
} }
self->iv = nil; self->iv = nil;
// TODO rename to makeImageView if (p->makeImageView) {
if (p->makeImage) {
self->imageModelColumn = p->imageModelColumn; self->imageModelColumn = p->imageModelColumn;
self->iv = [[NSImageView alloc] initWithFrame:NSZeroRect]; self->iv = [[NSImageView alloc] initWithFrame:NSZeroRect];
@ -541,6 +540,7 @@ struct textColumnCreateParams {
row = [self->t->tv rowForView:self->b]; row = [self->t->tv rowForView:self->b];
uiprivTableModelSetCellValue(self->m, row, self->modelColumn, NULL); uiprivTableModelSetCellValue(self->m, row, self->modelColumn, NULL);
// TODO document we DON'T update the cell after doing this // TODO document we DON'T update the cell after doing this
// TODO or decide what to do instead
} }
@end @end
@ -613,7 +613,7 @@ void uiTableAppendImageColumn(uiTable *t, const char *name, int imageModelColumn
p.t = t; p.t = t;
p.m = t->m; p.m = t->m;
p.makeImage = YES; p.makeImageView = YES;
p.imageModelColumn = imageModelColumn; p.imageModelColumn = imageModelColumn;
str = [NSString stringWithUTF8String:name]; str = [NSString stringWithUTF8String:name];
@ -640,7 +640,7 @@ void uiTableAppendImageTextColumn(uiTable *t, const char *name, int imageModelCo
else else
p.textParams = uiprivDefaultTextColumnOptionalParams; p.textParams = uiprivDefaultTextColumnOptionalParams;
p.makeImage = YES; p.makeImageView = YES;
p.imageModelColumn = imageModelColumn; p.imageModelColumn = imageModelColumn;
str = [NSString stringWithUTF8String:name]; str = [NSString stringWithUTF8String:name];