From 2f9aaeeb627ad14ae6797ea4ffa619fecfbdf07c Mon Sep 17 00:00:00 2001
From: Pietro Gagliardi <pietro10@mac.com>
Date: Sun, 24 May 2020 18:08:48 -0400
Subject: [PATCH] Started writing tests for uiWindow.

---
 darwin/window.m  |  1 +
 test/meson.build |  1 +
 test/window.c    | 38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 40 insertions(+)
 create mode 100644 test/window.c

diff --git a/darwin/window.m b/darwin/window.m
index a050a35c..85b6c70b 100644
--- a/darwin/window.m
+++ b/darwin/window.m
@@ -446,6 +446,7 @@ const char *uiWindowTitle(uiWindow *w)
 	struct windowImplData *wi = (struct windowImplData *) uiControlImplData(uiControl(w));
 
 	if (wi->title == NULL)
+		// TODO replace this with a dedicated UTF-8 empty string object
 		return "";
 	return wi->title;
 }
diff --git a/test/meson.build b/test/meson.build
index 30861681..58f0ec9c 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -5,6 +5,7 @@ libui_test_sources = files([
 	'controls.c',
 	'initmain.c',
 	'noinitwrongthread.c',
+	'window.c',
 ])
 libui_allcalls_headers = files([
 	'allcalls.h',
diff --git a/test/window.c b/test/window.c
new file mode 100644
index 00000000..cae1efb2
--- /dev/null
+++ b/test/window.c
@@ -0,0 +1,38 @@
+// 24 may 2020
+#include "test.h"
+
+Test(CannotMakeWindowAChild)
+{
+	uiWindow *a, *b;
+	void *ctx;
+
+	a = uiNewWindow();
+	b = uiNewWindow();
+
+	ctx = beginCheckProgrammerError("cannot set a uiWindow as the child of another uiControl");
+	uiControlSetParent(a, b);
+	// TODO this should not be necessary
+	uiControlSetParent(a, NULL);
+	endCheckProgrammerError(ctx);
+
+	uiControlFree(uiControl(b));
+	uiControlFree(uiControl(a));
+}
+
+Test(InitialWindowTitleIsEmptyString)
+{
+	uiWindow *w;
+	const char *title;
+
+	w = uiNewWindow();
+	title = uiWindowTitle(w);
+	// TODO have a utf8cmp()
+	if (*title != 0)
+		// TODO have a diffUTF8
+		TestErrorf("brand new uiWindow has wrong title:" diff("%s"),
+			title, "(empty string)");
+	uiControlFree(uiControl(w));
+}
+
+// TODO check that SetTitle works, and also that it sanitizes
+// TODO for all the above, check that the underlying title was also set appropriately