interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

More complain() migration; common/* handled.

This commit is contained in:
Pietro Gagliardi 2016-05-13 19:46:59 -04:00
parent a4f9d08281
commit 1fede348ef
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
common/control.c
View File

@ -75,12 +75,10 @@ void uiFreeControl(uiControl *c)
uiFree(c); uiFree(c);
} }
// TODO except where noted, replace complain() with userbug()
void uiControlVerifyDestroy(uiControl *c) void uiControlVerifyDestroy(uiControl *c)
{ {
if (uiControlParent(c) != NULL) if (uiControlParent(c) != NULL)
complain("attempt to destroy uiControl %p while it has a parent", c); userbug("You cannot destroy a uiControl while it still has a parent. (control: %p)", c);
} }
void uiControlVerifySetParent(uiControl *c, uiControl *parent) void uiControlVerifySetParent(uiControl *c, uiControl *parent)
@ -88,13 +86,12 @@ void uiControlVerifySetParent(uiControl *c, uiControl *parent)
uiControl *curParent; uiControl *curParent;
if (uiControlToplevel(c)) if (uiControlToplevel(c))
complain("cannot set a parent on a toplevel (uiWindow)"); userbug("You cannot give a toplevel uiControl a parent. (control: %p)", c);
curParent = uiControlParent(c); curParent = uiControlParent(c);
if (parent != NULL && curParent != NULL) if (parent != NULL && curParent != NULL)
complain("attempt to reparent uiControl %p (has parent %p, attempt to give parent %p)", c, curParent, parent); userbug("You cannot give a uiControl a parent while it already has one. (control: %p; current parent: %p; new parent: %p)", c, curParent, parent);
if (parent == NULL && curParent == NULL) if (parent == NULL && curParent == NULL)
// TODO implbug() implbug("attempt to double unparent uiControl %p", c);
complain("attempt to double unparent uiControl %p — likely an implementation bug ", c);
} }
int uiControlEnabledToUser(uiControl *c) int uiControlEnabledToUser(uiControl *c)