interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Call gtk_widget_destroy() instead of g_object_unref() when destroying uiWindows. Fixes #165.

This commit is contained in:
Pietro Gagliardi 2016-06-21 12:15:38 -04:00
parent 80b8fddbea
commit 10480db895
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
unix/window.c
View File

@ -93,7 +93,8 @@ static void uiWindowDestroy(uiControl *c)
gtk_widget_destroy(w->childHolderWidget);
gtk_widget_destroy(w->vboxWidget);
// and finally free ourselves
g_object_unref(w->widget);
// use gtk_widget_destroy() instead of g_object_unref() because GTK+ has internal references (see #165)
gtk_widget_destroy(w->widget);
uiFreeControl(uiControl(w));
}
@ -323,7 +324,7 @@ uiWindow *uiNewWindow(const char *title, int width, int height, int hasMenubar)
uiWindowOnContentSizeChanged(w, defaultOnPositionContentSizeChanged, NULL);
// normally it's SetParent() that does this, but we can't call SetParent() on a uiWindow
// TODO we really need to clean this up
// TODO we really need to clean this up, especially since see uiWindowDestroy() above
g_object_ref(w->widget);
return w;