Resolved some TODOs/removed some stale TODOs. The one about libui_is_debug was confirmed by freenode elibrokeit as the pacman package manager uses it.

This commit is contained in:
Pietro Gagliardi 2019-03-25 23:12:28 -04:00
parent 0b87ee9f93
commit 0d9cfa0f68
1 changed files with 0 additions and 3 deletions

View File

@ -12,7 +12,6 @@
# And for Windows, the shared library (but not shared executables) needs an additional resource file, and the static executables (but not the static library) need a *different* resource file. (Windows static libraries can't contain resources anyway; the linkers will just ignore the resource objects.) # And for Windows, the shared library (but not shared executables) needs an additional resource file, and the static executables (but not the static library) need a *different* resource file. (Windows static libraries can't contain resources anyway; the linkers will just ignore the resource objects.)
# we have to specify C++ here even if we're not using C++ immediately because otherwise none of the C++ built-in options are available (sigh; TODO) # we have to specify C++ here even if we're not using C++ immediately because otherwise none of the C++ built-in options are available (sigh; TODO)
# and same for Objective-C because of add_project_arguments() (double sigh; TODO)
project('libui', ['c', 'cpp'], project('libui', ['c', 'cpp'],
meson_version: '>=0.48.0', meson_version: '>=0.48.0',
default_options: [ default_options: [
@ -66,7 +65,6 @@ if libui_mode == 'both'
error('sorry, but libui does not support building both shared and static libraries at the same time, because Windows resource file rules differ between the two') error('sorry, but libui does not support building both shared and static libraries at the same time, because Windows resource file rules differ between the two')
endif endif
# TODO there has to be a better way to specify this
libui_is_debug = get_option('buildtype').startswith('debug') libui_is_debug = get_option('buildtype').startswith('debug')
if libui_OS == 'darwin' if libui_OS == 'darwin'
@ -142,7 +140,6 @@ else
subdir('unix') subdir('unix')
install_headers('ui_unix.h') install_headers('ui_unix.h')
endif endif
# TODO make sure the name is always libui.(something) regardless of the OS or build type
libui_libui = library('ui', libui_sources, libui_libui = library('ui', libui_sources,
dependencies: libui_deps, dependencies: libui_deps,
build_rpath: libui_rpath, build_rpath: libui_rpath,