interesting
/
go-opengl-pixel
mirror of https://github.com/faiface/pixel.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

optimize deffers

This commit is contained in:
faiface 2016-12-14 19:07:25 +01:00
parent 4427206988
commit 86e64b6fa3
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pixelgl/vertex.go
View File

@ -197,8 +197,9 @@ func (va *VertexArray) SetIndices(indices []int) {
} }
va.indexNum = len(indices32) va.indexNum = len(indices32)
DoNoBlock(func() { DoNoBlock(func() {
defer va.ebo.bind().restore() va.ebo.bind()
gl.BufferData(gl.ELEMENT_ARRAY_BUFFER, 4*len(indices32), gl.Ptr(indices32), uint32(va.usage)) gl.BufferData(gl.ELEMENT_ARRAY_BUFFER, 4*len(indices32), gl.Ptr(indices32), uint32(va.usage))
va.ebo.restore()
}) })
} }
@ -223,7 +224,7 @@ func (va *VertexArray) SetVertexAttr(vertex int, attr Attr, value interface{}) (
} }
DoNoBlock(func() { DoNoBlock(func() {
defer va.vbo.bind().restore() va.vbo.bind()
offset := va.stride*vertex + va.attrs[attr] offset := va.stride*vertex + va.attrs[attr]
@ -243,6 +244,8 @@ func (va *VertexArray) SetVertexAttr(vertex int, attr Attr, value interface{}) (
default: default:
panic("set vertex attr: invalid attribute type") panic("set vertex attr: invalid attribute type")
} }
va.vbo.restore()
}) })
return true return true
@ -264,7 +267,7 @@ func (va *VertexArray) VertexAttr(vertex int, attr Attr) (value interface{}, ok
} }
Do(func() { Do(func() {
defer va.vbo.bind().restore() va.vbo.bind()
offset := va.stride*vertex + va.attrs[attr] offset := va.stride*vertex + va.attrs[attr]
@ -285,7 +288,11 @@ func (va *VertexArray) VertexAttr(vertex int, attr Attr) (value interface{}, ok
var data mgl32.Vec4 var data mgl32.Vec4
gl.GetBufferSubData(gl.ARRAY_BUFFER, offset, attr.Type.Size(), unsafe.Pointer(&data)) gl.GetBufferSubData(gl.ARRAY_BUFFER, offset, attr.Type.Size(), unsafe.Pointer(&data))
value = data value = data
default:
panic("set vertex attr: invalid attribute type")
} }
va.vbo.restore()
}) })
return value, true return value, true