go-ethereum/accounts
Thomas Bocek 89c6c5bb85 accounts/abi: Negative numbers not properly converted in ABI encoding
When converting a negative number e.g., -2, the resulting ABI encoding
should look as follows:
fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe.
However, since the check of the type is for an uint instead of an
int, it results in the following ABI encoding:
0101010101010101010101010101010101010101010101010101010101010102. The
Ethereum ABI
(https://github.com/ethereum/wiki/wiki/Ethereum-Contract-ABI) says,
that signed integers are stored in two's complement which should be
of the form ffffff.... and not 01010101..... for e.g. -1. Thus, I
removed the type check in numbers.go as well as the function S256
as I don't think they are correct. Or maybe I'm missing something?
2016-06-06 14:27:15 +02:00
..
abi accounts/abi: Negative numbers not properly converted in ABI encoding 2016-06-06 14:27:15 +02:00
testdata cmd/geth: add recovery procedure for AmbiguousAddrError 2016-04-12 15:59:18 +02:00
account_manager.go eth: add new RPC method (personal.) SignAndSendTransaction 2016-05-20 15:54:18 +02:00
accounts_test.go eth: add new RPC method (personal.) SignAndSendTransaction 2016-05-20 15:54:18 +02:00
addrcache.go accounts: cache key addresses 2016-04-12 15:58:07 +02:00
addrcache_test.go accounts: cache key addresses 2016-04-12 15:58:07 +02:00
key.go accounts: improve API and add documentation 2016-04-12 15:59:18 +02:00
key_store_passphrase.go accounts: add ErrDecrypt 2016-04-12 15:58:07 +02:00
key_store_passphrase_test.go accounts: cache key addresses 2016-04-12 15:58:07 +02:00
key_store_plain.go all: update license information 2016-04-15 09:48:05 +02:00
key_store_test.go accounts: add ErrDecrypt 2016-04-12 15:58:07 +02:00
presale.go accounts: add ErrDecrypt 2016-04-12 15:58:07 +02:00
watch.go accounts: disable file system watch on linux/arm64 2016-04-25 13:30:28 +02:00
watch_fallback.go accounts: disable file system watch on linux/arm64 2016-04-25 13:30:28 +02:00