go-ethereum

Commit Graph

Author	SHA1	Message	Date
Martin Holst Swende	4d3525610e	all: remove deprecated uses of math.rand (#26710 ) This PR is a (superior) alternative to https://github.com/ethereum/go-ethereum/pull/26708, it handles deprecation, primarily two specific cases. `rand.Seed` is typically used in two ways - `rand.Seed(time.Now().UnixNano())` -- we seed it, just to be sure to get some random, and not always get the same thing on every run. This is not needed, with global seeding, so those are just removed. - `rand.Seed(1)` this is typically done to ensure we have a stable test. If we rely on this, we need to fix up the tests to use a deterministic prng-source. A few occurrences like this has been replaced with a proper custom source. `rand.Read` has been replaced by `crypto/rand`.`Read` in this PR.	2023-02-16 14:36:58 -05:00
Guillaume Ballet	58f2ce8671	metrics: fix issues reported by staticcheck (#20365 )	2019-11-22 16:04:35 +01:00
Anton Evangelatov	ae9f97221a	metrics: pull library and introduce ResettingTimer and InfluxDB reporter (#15910 ) * go-metrics: fork library and introduce ResettingTimer and InfluxDB reporter. * vendor: change nonsense/go-metrics to ethersphere/go-metrics * go-metrics: add tests. move ResettingTimer logic from reporter to type. * all, metrics: pull in metrics package in go-ethereum * metrics/test: make sure metrics are enabled for tests * metrics: apply gosimple rules * metrics/exp, internal/debug: init expvar endpoint when starting pprof server * internal/debug: tiny comment formatting fix	2018-02-23 11:56:08 +02:00

Author

SHA1

Message

Date

Martin Holst Swende

4d3525610e

all: remove deprecated uses of math.rand (#26710 )

This PR is a (superior) alternative to https://github.com/ethereum/go-ethereum/pull/26708, it handles deprecation, primarily two specific cases. 

`rand.Seed` is typically used in two ways
- `rand.Seed(time.Now().UnixNano())` -- we seed it, just to be sure to get some random, and not always get the same thing on every run. This is not needed, with global seeding, so those are just removed. 
- `rand.Seed(1)` this is typically done to ensure we have a stable test. If we rely on this, we need to fix up the tests to use a deterministic prng-source. A few occurrences like this has been replaced with a proper custom source. 

`rand.Read` has been replaced by `crypto/rand`.`Read` in this PR.

2023-02-16 14:36:58 -05:00

Guillaume Ballet

58f2ce8671

metrics: fix issues reported by staticcheck (#20365 )

2019-11-22 16:04:35 +01:00

Anton Evangelatov

ae9f97221a

metrics: pull library and introduce ResettingTimer and InfluxDB reporter (#15910 )

* go-metrics: fork library and introduce ResettingTimer and InfluxDB reporter.

* vendor: change nonsense/go-metrics to ethersphere/go-metrics

* go-metrics: add tests. move ResettingTimer logic from reporter to type.

* all, metrics: pull in metrics package in go-ethereum

* metrics/test: make sure metrics are enabled for tests

* metrics: apply gosimple rules

* metrics/exp, internal/debug: init expvar endpoint when starting pprof server

* internal/debug: tiny comment formatting fix

2018-02-23 11:56:08 +02:00

3 Commits