350a0490ab
les: fix unittest ( #21382 )
2020-07-29 13:44:14 +03:00
37564ceda6
miner: refactor helper functions in worker.go ( #21044 )
...
This reduces complexity of some lengthy functions in worker.go,
making the code easier to read.
2020-07-28 18:16:49 +02:00
28c5a8a54b
les: implement new les fetcher ( #20692 )
...
* cmd, consensus, eth, les: implement light fetcher
* les: address comment
* les: address comment
* les: address comments
* les: check td after delivery
* les: add linearExpiredValue for error counter
* les: fix import
* les: fix dead lock
* les: order announces by td
* les: encapsulate invalid counter
* les: address comment
* les: add more checks during the delivery
* les: fix log
* eth, les: fix lint
* eth/fetcher: address comment
2020-07-28 18:02:35 +03:00
298a19bbc6
core: API-less transaction time sorting
2020-07-28 17:13:40 +03:00
c47052a580
core: sort txs at the same gas price by received time
2020-07-28 17:13:39 +03:00
93da0cf8a1
cmd, core, eth, light, trie: dump clean cache periodically ( #20391 )
...
* cmd, core, eth, light, trie: dump clean cache periodically
* eth: update config
* trie: minor fix
* core, trie: address comments
* eth: remove useless
* trie: print clean cache dump start too
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
2020-07-28 16:30:31 +03:00
79ce5537ab
signer/storage: fix a badly ordered error check ( #21379 )
2020-07-28 12:47:05 +03:00
8e7bee9b56
params: begin v1.9.19 release cycle
2020-07-27 14:58:45 +03:00
f538259187
params: release Geth v1.9.18
2020-07-27 14:53:53 +03:00
b1be979443
params: upgrade CHTs ( #21376 )
2020-07-27 12:57:15 +03:00
e997f92caf
Merge pull request #21368 from holiman/update_uint256
...
deps: update uint256 to v1.1.1
2020-07-24 15:02:52 +03:00
56434bfa89
deps: update uint256 to v1.1.1
2020-07-24 14:00:08 +02:00
6793ffa12b
Merge pull request #21300 from rjl493456442/txpool-fix-queued-evictions
...
core: fix queued transaction eviction
2020-07-24 11:14:42 +03:00
5413df1dfa
core: fix heartbeat in txpool
...
core: address comment
2020-07-24 11:12:59 +03:00
c374447401
core: fix queued transaction eviction
...
Solves issue#20582. Non-executable transactions should not be evicted on each tick if there are no promote transactions or if a pending/reset empties the pending list. Tests and logging expanded to handle these cases in the future.
core/tx_pool: use a ts for each tx in the queue, but only update the heartbeat on promotion or pending replaced
queuedTs proper naming
2020-07-24 11:11:57 +03:00
105922180f
eth/downloader: refactor downloader + queue ( #21263 )
...
* eth/downloader: refactor downloader + queue
downloader, fetcher: throttle-metrics, fetcher filter improvements, standalone resultcache
downloader: more accurate deliverytime calculation, less mem overhead in state requests
downloader/queue: increase underlying buffer of results, new throttle mechanism
eth/downloader: updates to tests
eth/downloader: fix up some review concerns
eth/downloader/queue: minor fixes
eth/downloader: minor fixes after review call
eth/downloader: testcases for queue.go
eth/downloader: minor change, don't set progress unless progress...
eth/downloader: fix flaw which prevented useless peers from being dropped
eth/downloader: try to fix tests
eth/downloader: verify non-deliveries against advertised remote head
eth/downloader: fix flaw with checking closed-status causing hang
eth/downloader: hashing avoidance
eth/downloader: review concerns + simplify resultcache and queue
eth/downloader: add back some locks, address review concerns
downloader/queue: fix remaining lock flaw
* eth/downloader: nitpick fixes
* eth/downloader: remove the *2*3/4 throttling threshold dance
* eth/downloader: print correct throttle threshold in stats
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
2020-07-24 10:46:26 +03:00
3a57eecc69
mobile: fix build on iOS ( #21362 )
...
This fixes the iOS framework build by naming the second parameter of the
Signer interface method. The name is important because it becomes part
of the objc method signature.
Fixes #21340
2020-07-23 19:15:40 +02:00
997b55236e
build: fix GOBIN for gomobile commands ( #21361 )
2020-07-23 12:34:08 +02:00
4c268e65a0
cmd/utils: implement configurable developer (--dev) account options ( #21301 )
...
* geth,utils: implement configurable developer account options
Prior to this change --dev (developer) mode
generated one account with an empty password,
irrespective of existing --password and --miner.etherbase
options.
This change makes --dev mode compatible with these
existing flags.
--dev mode may now be used in conjunction with
--password and --miner.etherbase flags to configure
the developer faucet using an existing keystore or
in creating a new account.
Signed-off-by: meows <b5c6@protonmail.com>
* main: remove key/pass flags from usage developer section
These flags are included already in other sections,
and it is not desired to duplicate them.
They were originally included in this section
along with added support for these flags in the
developer mode.
Signed-off-by: meows <b5c6@protonmail.com>
2020-07-23 06:47:34 +03:00
0b53e485d8
Merge pull request #21352 from karalabe/dev-noinit-genesis
...
cmd/utils: reuse existing genesis in persistent dev mode
2020-07-22 17:39:08 +03:00
9e22e912e3
cmd/utils: reuse existing genesis in persistent dev mode
2020-07-21 15:58:29 +03:00
123864fc05
whisper/whisperv6: improve test error messages ( #21348 )
2020-07-21 10:53:06 +02:00
7163a6664e
ethclient: serialize negative block number as "pending" ( #21177 )
...
Fixes #21175
Co-authored-by: sammy007 <sammy007@users.noreply.github.com>
Co-authored-by: Adam Schmideg <adamschmideg@users.noreply.github.com>
2020-07-21 10:51:15 +02:00
4366c45e4e
les: make clientPool.connectedBias configurable ( #21305 )
2020-07-21 10:23:40 +02:00
3a52c4dcf2
Merge pull request #21336 from karalabe/tiny-ref-optimization
...
core/vm: use pointers to operations vs. copy by value
2020-07-21 10:53:12 +03:00
722b742780
params: begin v1.9.18 release cycle
2020-07-20 15:58:33 +03:00
748f22c192
params: release Geth v1.9.17
2020-07-20 15:56:42 +03:00
43e2e58cbd
accounts, internal: fix funding check when estimating gas ( #21346 )
...
* internal, accounts: fix funding check when estimate gas
* accounts, internal: address comments
2020-07-20 15:52:42 +03:00
35ddf36229
Merge pull request #21347 from karalabe/ethstats-fixes
...
ethstats: fix reconnection issue, implement primus pings
2020-07-20 11:47:13 +03:00
0fef66c739
ethstats: fix reconnection issue, implement primus pings
2020-07-20 11:46:41 +03:00
508891e64b
core/vm: use pointers to operations vs. copy by value
2020-07-16 15:32:01 +03:00
9e88224eb8
core: raise gas limit in --dev mode, seed blake precompile ( #21323 )
...
* Set gasLimit in --dev mode to be 9m.
* core: Set gasLimit to 11.5 milion and add 1 wei allocation for BLAKE2b
2020-07-16 15:08:38 +03:00
295693759e
core/vm: less allocations for various call variants ( #21222 )
...
* core/vm/runtime/tests: add more benchmarks
* core/vm: initial work on improving alloc count for calls to precompiles
name old time/op new time/op delta
SimpleLoop/identity-precompile-10M-6 117ms ±75% 43ms ± 1% -63.09% (p=0.008 n=5+5)
SimpleLoop/loop-10M-6 79.6ms ± 4% 70.5ms ± 1% -11.42% (p=0.008 n=5+5)
name old alloc/op new alloc/op delta
SimpleLoop/identity-precompile-10M-6 24.4MB ± 0% 4.9MB ± 0% -79.94% (p=0.008 n=5+5)
SimpleLoop/loop-10M-6 13.2kB ± 0% 13.2kB ± 0% ~ (p=0.357 n=5+5)
name old allocs/op new allocs/op delta
SimpleLoop/identity-precompile-10M-6 382k ± 0% 153k ± 0% -59.99% (p=0.000 n=5+4)
SimpleLoop/loop-10M-6 40.0 ± 0% 40.0 ± 0% ~ (all equal)
* core/vm: don't allocate big.int for touch
name old time/op new time/op delta
SimpleLoop/identity-precompile-10M-6 43.3ms ± 1% 42.4ms ± 7% ~ (p=0.151 n=5+5)
SimpleLoop/loop-10M-6 70.5ms ± 1% 76.7ms ± 1% +8.67% (p=0.008 n=5+5)
name old alloc/op new alloc/op delta
SimpleLoop/identity-precompile-10M-6 4.90MB ± 0% 2.46MB ± 0% -49.83% (p=0.008 n=5+5)
SimpleLoop/loop-10M-6 13.2kB ± 0% 13.2kB ± 1% ~ (p=0.571 n=5+5)
name old allocs/op new allocs/op delta
SimpleLoop/identity-precompile-10M-6 153k ± 0% 76k ± 0% -49.98% (p=0.029 n=4+4)
SimpleLoop/loop-10M-6 40.0 ± 0% 40.0 ± 0% ~ (all equal)
* core/vm: reduce allocs in staticcall
name old time/op new time/op delta
SimpleLoop/identity-precompile-10M-6 42.4ms ± 7% 37.5ms ± 6% -11.68% (p=0.008 n=5+5)
SimpleLoop/loop-10M-6 76.7ms ± 1% 69.1ms ± 1% -9.82% (p=0.008 n=5+5)
name old alloc/op new alloc/op delta
SimpleLoop/identity-precompile-10M-6 2.46MB ± 0% 0.02MB ± 0% -99.35% (p=0.008 n=5+5)
SimpleLoop/loop-10M-6 13.2kB ± 1% 13.2kB ± 0% ~ (p=0.143 n=5+5)
name old allocs/op new allocs/op delta
SimpleLoop/identity-precompile-10M-6 76.4k ± 0% 0.1k ± 0% ~ (p=0.079 n=4+5)
SimpleLoop/loop-10M-6 40.0 ± 0% 40.0 ± 0% ~ (all equal)
* trie: better use of hasher keccakState
* core/state/statedb: reduce allocations in getDeletedStateObject
* core/vm: reduce allocations in all call derivates
* core/vm: reduce allocations in call variants
- Make returnstack `uint32`
- Use a `sync.Pool` of `stack`s
* core/vm: fix tests
* core/vm: goimports
* core/vm: tracer fix + staticcall gas fix
* core/vm: add back snapshot to staticcall
* core/vm: review concerns + make returnstack pooled + enable returndata in traces
* core/vm: fix some test tracer method signatures
* core/vm: run gencodec, minor comment polish
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
2020-07-16 15:06:19 +03:00
240d1851db
trie: quell linter in commiter.go ( #21329 )
2020-07-15 11:00:04 +03:00
6c9f040ebe
core: transaction pool optimizations ( #21328 )
...
* core: added local tx pool test case
* core, crypto: various allocation savings regarding tx handling
* core/txlist, txpool: save a reheap operation, avoid some bigint allocs
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
2020-07-14 21:42:32 +02:00
5b081ab214
cmd/clef: change --rpcport to --http.port and update flags in docs ( #21318 )
2020-07-14 10:35:32 +02:00
6ef4495a8f
p2p/discover: require table nodes to have an IP ( #21330 )
...
This fixes a corner case in discv5. The issue cannot happen in discv4
because it performs IP checks on all incoming node information.
2020-07-13 22:25:45 +02:00
79addac698
core/rawdb: better log messages for ancient failure ( #21327 )
2020-07-13 20:43:30 +02:00
7d5267e3a2
.github: Change Code Owners ( #21326 )
...
* modify code owners
* add marius
2020-07-13 16:20:20 +02:00
4edbc1f2bb
internal/ethapi: cap txfee for SignTransaction and Resend ( #21231 )
2020-07-13 12:45:39 +02:00
6cf6e1d753
README.md: point Go API reference link to pkg.go.dev ( #21321 )
2020-07-13 11:22:30 +02:00
2e08dad9e6
p2p/discv5: unset pingEcho on pong timeout ( #21324 )
2020-07-13 11:20:47 +02:00
af258efdb9
light: goimports -w ( #21325 )
2020-07-13 11:17:49 +02:00
6eef141aef
les: historical data garbage collection ( #19570 )
...
This change introduces garbage collection for the light client. Historical
chain data is deleted periodically. If you want to disable the GC, use
the --light.nopruning flag.
2020-07-13 11:02:54 +02:00
b8dd0890b3
params: begin v1.9.17 release cycle
2020-07-10 12:40:31 +02:00
ea3b00ad75
params: go-ethereum v1.9.16 stable
2020-07-10 12:38:48 +02:00
feb40e3a4d
accounts/external: remove dependency on internal/ethapi ( #21319 )
...
Fixes #20535
Co-authored-by: Felix Lange <fjl@twurst.com>
2020-07-10 11:33:31 +02:00
beabf95ad7
cmd/geth, cmd/puppeth: replace deprecated rpc and ws flags in tests and docs ( #21317 )
2020-07-09 17:48:40 +02:00
6ccce0906a
common/math: use math/bits intrinsics for Safe* ( #21316 )
...
This is a resubmit of ledgerwatch/turbo-geth#556 . The performance
benefit of this change is negligible, but it does remove a TODO.
2020-07-09 17:45:49 +02:00
bcb3087450
Revert "core, txpool: less allocations when handling transactions ( #21232 )"
...
Reverting because this change started handling account balances as
uint64 in the transaction pool, which is incorrect.
This reverts commit af5c97aebe
2020-07-09 14:02:03 +02:00
gary rong
Robert Zaremba
Péter Szilágyi
Hendrik Hofstadt
6543
Martin Holst Swende
villanuevawill
Felix Lange
meowsbits
rene
Sammy Libre
Binacs
Nikola Madjarevic
Guillaume Ballet
Tien
libotony