3ad73443c7
fix slice unpack bug in accounts/abi ( #18321 )
...
* fix slice unpack bug in accounts/abi
2018-12-17 09:50:52 +01:00
e79821cabe
accounts/abi: argument type and name were reversed ( #17947 )
...
argument type and name were reversed
2018-12-13 15:12:19 +01:00
b3be9b7cd8
usbwallet: check returned error when decoding hexstr ( #18056 )
...
* usbwallet: check returned error when decoding hexstr
* Update accounts/usbwallet/ledger.go
Co-Authored-By: CoreyLin <514971757@qq.com>
* usbwallet: check hex decode error
2018-12-13 10:21:52 +01:00
92639b676a
Add packing for dynamic array and slice types ( #18051 )
...
* added tests for new abi encoding features (#4 )
* added tests from bytes32[][] and string[]
* added offset to other types
* formatting
* Abi/dynamic types (#5 )
* Revert "Abi/dynamic types (#5 )" (#6 )
This reverts commit dabca31d79#7 )
* some cleanup
* Apply suggestions from code review
apply suggestions
Co-Authored-By: vedhavyas <vedhavyas.singareddi@gmail.com>
* added better formatting (#8 )
* review chnages
* better comments
2018-12-04 15:27:55 +01:00
32d35c9c08
accounts/keystore: delete the redundant keystore in filename ( #17930 )
...
* accounts/keystore: reduce file name length
* accounts/keystore: reduce code line width
2018-11-29 12:04:56 +02:00
6ff97bf2e5
accounts: wallet derivation path comment is mistaken ( #17934 )
2018-10-19 16:40:10 +03:00
331fa6d307
accounts/usbwallet: simplify code using -= operator ( #17904 )
2018-10-16 00:34:50 +02:00
d5c7a6056a
cmd/clef: encrypt the master seed on disk ( #17704 )
...
* cmd/clef: encrypt master seed of clef
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
* keystore: refactor for external use of encryption
* clef: utilize keystore encryption, check flags correctly
* clef: validate master password
* clef: add json wrapping around encrypted master seed
2018-10-09 11:05:41 +02:00
5ed3960b9b
accounts/abi/bind: stop using goimports in the binding generator ( #17768 )
2018-10-05 22:24:54 +02:00
96fd50be10
accounts/abi: fix panic in MethodById lookup. Fixes #17797 ( #17798 )
2018-10-01 14:17:36 +02:00
a5aaab2f22
accounts/abi/bind/backends: fix typo ( #17749 )
2018-09-28 22:47:46 +02:00
d6254f827b
all: protect self-mined block during reorg ( #17656 )
2018-09-20 15:09:30 +03:00
6f004c46d5
accounts/keystore: double-check keystore file after creation ( #17348 )
2018-09-19 18:08:38 +02:00
16bc8741bf
abi, signer: fix nil dereference in #17633 ( #17653 )
...
* abi,signer: fix nil dereference in #17633
* signer/core: tiny typo fix in test error message
2018-09-19 12:07:53 +03:00
42bd67bd6f
accounts/abi: fix unpacking of negative int256 ( #17583 )
2018-09-04 17:53:28 +02:00
d1aa605f1e
all: remove the duplicate 'the' in annotations ( #17509 )
2018-08-27 11:49:29 +03:00
60390878a5
accounts: fixed typo ( #17421 )
2018-08-17 10:38:02 +03:00
212bba47ff
backends: configurable gas limit to allow testing large contracts ( #17358 )
...
* backends: increase gaslimit in order to allow tests of large contracts
* backends: increase gaslimit in order to allow tests of large contracts
* backends: increase gaslimit in order to allow tests of large contracts
2018-08-15 10:15:42 +03:00
70176cda0e
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal the function purpose ( #17290 )
2018-08-03 10:25:17 +03:00
d9575e92fc
crypto/secp256k1: remove external LGPL dependencies ( #17239 )
2018-07-26 13:33:13 +02:00
21c059b67e
Merge pull request #16734 from reductionista/eip234
...
eth/filters, interfaces: EIP-234 Add blockHash option to eth_getLogs
2018-07-24 12:52:16 +03:00
040dd5bd5d
accounts/abi: refactor Method#Sig() to use index in range iterator directly ( #17198 )
2018-07-19 11:42:47 +03:00
323428865f
accounts: add unit tests for URL ( #17182 )
2018-07-18 11:32:49 +03:00
5d30be412b
all: switch out defunct set library to different one ( #16873 )
...
* keystore, ethash, eth, miner, rpc, whisperv6: tech debt with now defunct set.
* whisperv5: swap out gopkg.in/fatih/set.v0 with supported set
2018-07-16 10:54:19 +03:00
e1f1d3085c
accounts, eth, les: blockhash based filtering on all code paths
2018-07-12 18:16:54 +03:00
61a5976368
accounts: remove deadcode isSigned ( #16990 )
2018-06-20 11:46:29 +02:00
28aca90716
accounts/usbwallet: correct comment typo ( #16998 )
2018-06-19 14:43:20 +03:00
3e57c33147
accounts/usbwallet: correct comment typo ( #17008 )
2018-06-19 14:36:35 +03:00
c95e4a80d1
accounts/keystore: assign schema as const instead of var ( #16985 )
2018-06-14 17:24:35 +03:00
49719e21bc
core, eth: minor txpool event cleanups
2018-05-18 12:08:24 +03:00
a2e43d28d0
all: collate new transaction events together
2018-05-18 11:46:44 +03:00
247b5f0369
accounts/abi: allow abi: tags when unpacking structs
...
Go code users can now tag event struct members with `abi:` to specify in what fields the event will be de-serialized.
See PR #16648 for details.
2018-05-14 14:47:31 +02:00
7beccb29be
all: get rid of error when creating memory database ( #16716 )
...
* all: get rid of error when create mdb
* core: clean up variables definition
* all: inline mdb definition
2018-05-09 15:24:25 +03:00
6cf0ab38bd
core/rawdb: separate raw database access to own package ( #16666 )
2018-05-07 14:35:06 +03:00
541f299fbb
accounts: changed if-else blocks to conform with golint ( #16654 )
2018-05-03 11:37:56 +03:00
c1ea527573
accounts: golint updates for this or self warning ( #16627 )
2018-05-02 11:17:52 +03:00
ba1030b6b8
build: enable goimports and varcheck linters ( #16446 )
2018-04-18 00:53:50 +02:00
ec3db0f56c
cmd/clef, signer: initial poc of the standalone signer ( #16154 )
...
* signer: introduce external signer command
* cmd/signer, rpc: Implement new signer. Add info about remote user to Context
* signer: refactored request/response, made use of urfave.cli
* cmd/signer: Use common flags
* cmd/signer: methods to validate calldata against abi
* cmd/signer: work on abi parser
* signer: add mutex around UI
* cmd/signer: add json 4byte directory, remove passwords from api
* cmd/signer: minor changes
* cmd/signer: Use ErrRequestDenied, enable lightkdf
* cmd/signer: implement tests
* cmd/signer: made possible for UI to modify tx parameters
* cmd/signer: refactors, removed channels in ui comms, added UI-api via stdin/out
* cmd/signer: Made lowercase json-definitions, added UI-signer test functionality
* cmd/signer: update documentation
* cmd/signer: fix bugs, improve abi detection, abi argument display
* cmd/signer: minor change in json format
* cmd/signer: rework json communication
* cmd/signer: implement mixcase addresses in API, fix json id bug
* cmd/signer: rename fromaccount, update pythonpoc with new json encoding format
* cmd/signer: make use of new abi interface
* signer: documentation
* signer/main: remove redundant option
* signer: implement audit logging
* signer: create package 'signer', minor changes
* common: add 0x-prefix to mixcaseaddress in json marshalling + validation
* signer, rules, storage: implement rules + ephemeral storage for signer rules
* signer: implement OnApprovedTx, change signing response (API BREAKAGE)
* signer: refactoring + documentation
* signer/rules: implement dispatching to next handler
* signer: docs
* signer/rules: hide json-conversion from users, ensure context is cleaned
* signer: docs
* signer: implement validation rules, change signature of call_info
* signer: fix log flaw with string pointer
* signer: implement custom 4byte databsae that saves submitted signatures
* signer/storage: implement aes-gcm-backed credential storage
* accounts: implement json unmarshalling of url
* signer: fix listresponse, fix gas->uint64
* node: make http/ipc start methods public
* signer: add ipc capability+review concerns
* accounts: correct docstring
* signer: address review concerns
* rpc: go fmt -s
* signer: review concerns+ baptize Clef
* signer,node: move Start-functions to separate file
* signer: formatting
2018-04-16 15:04:32 +03:00
6ab9f0a19f
accounts/abi: improve test coverage ( #16044 )
2018-04-04 13:42:36 +02:00
933972d139
Merge pull request #16256 from epiclabs-io/unpack_one_arg_event
...
Fix issue unmarshaling single parameter events from abigen generated go code #16208
2018-03-21 10:11:37 +01:00
faed47b3c5
Merge pull request #15990 from markya0616/sim_backend_block_hash
...
accounts/abi, core: add AddTxWithChain in BlockGen for simulation
2018-03-19 08:29:54 +01:00
cddb529d70
accounts/abi: normalize method name to a camel-case string ( #15976 )
2018-03-07 14:34:53 +02:00
60a999f238
accounts/abi: Modified unpackAtomic to accept struct lvalues
2018-03-05 16:01:40 +01:00
13b566e06e
accounts/abi: Add one-parameter event test case from enriquefynn/unpack_one_arg_event
2018-03-05 16:00:03 +01:00
0b814d32f8
accounts/abi: Abi binding support for nested arrays, fixes #15648 , including nested array unpack fix ( #15676 )
...
* accounts/abi/bind: support for multi-dim arrays
Also:
- reduce usage of regexes a bit.
- fix minor Java syntax problems
Fixes #15648
* accounts/abi/bind: Add some more documentation
* accounts/abi/bind: Improve code readability
* accounts/abi: bugfix for unpacking nested arrays
The code previously assumed the arrays/slices were always 1 level
deep. While the packing supports nested arrays (!!!).
The current code for unpacking doesn't return the "consumed" length, so
this fix had to work around that by calculating it (i.e. packing and
getting resulting length) after the unpacking of the array element.
It's far from ideal, but unpacking behaviour is fixed now.
* accounts/abi: Fix unpacking of nested arrays
Removed the temporary workaround of packing to calculate size, which was
incorrect for slice-like types anyway.
Full size of nested arrays is used now.
* accounts/abi: deeply nested array unpack test
Test unpacking of an array nested more than one level.
* accounts/abi: Add deeply nested array pack test
Same as the deep nested array unpack test, but the other way around.
* accounts/abi/bind: deeply nested arrays bind test
Test the usage of bindings that were generated
for methods with multi-dimensional (and not
just a single extra dimension, like foo[2][3])
array arguments and returns.
edit: trigger rebuild, CI failed to fetch linter module.
* accounts/abi/bind: improve array binding
wrapArray uses a regex now, and arrayBindingJava is improved.
* accounts/abi: Improve naming of element size func
The full step size for unpacking an array
is now retrieved with "getFullElemSize".
* accounts/abi: support nested nested array args
Previously, the code only considered the outer-size of the array,
ignoring the size of the contents. This was fine for most types,
but nested arrays are packed directly into it, and count towards
the total size. This resulted in arguments following a nested
array to replicate some of the binary contents of the array.
The fix: for arrays, calculate their complete contents size:
count the arg.Type.Elem.Size when Elem is an Array, and
repeat when their child is an array too, etc.
The count is the number of 32 byte elements, similar to how it
previously counted, but nested.
* accounts/abi: Test deep nested arr multi-arguments
Arguments with a deeply nested array should not cause the next arguments
to be read from the wrong position.
2018-03-04 23:24:17 +01:00
5cf1d35470
eth, les, light: filter on logs only, derive receipts on demand
2018-02-22 19:12:43 +02:00
61f2279bde
abi: fix missing method on go 1.7/1.8
2018-02-21 12:27:50 +01:00
bd6ed23899
accounts/abi: harden unpacking against malicious input
2018-02-21 12:27:50 +01:00
08c5d4dd27
accounts/abi: address review concerns
2018-02-21 12:27:50 +01:00
f0f594d045
accounts/abi: Deduplicate code in unpacker
2018-02-21 12:27:50 +01:00
weimumu
tzapu
Corey Lin
Vedhavyas Singareddi
Wenbiao Zheng
Evgeny
Martin Holst Swende
Jeremy Schlatter
CDsigma
gary rong
Diep Pham
Sasuke1964
Jeff Prestes
Roc Yu
Péter Szilágyi
Ralph Caraveo III
Husam Ibrahim
Guillaume Ballet
GagziW
kiel barry
thomasmodeneis
Ricardo Domingos
Mark
Javier Peletier
protolambda