Felix Lange
53a18d2e27
event: document select case slice use and add edge case test ( #16680 )
...
Feed keeps active subscription channels in a slice called 'f.sendCases'.
The Send method tracks the active cases in a local variable 'cases'
whose value is f.sendCases initially. 'cases' shrinks to a shorter
prefix of f.sendCases every time a send succeeds, moving the successful
case out of range of the active case list.
This can be confusing because the two slices share a backing array. Add
more comments to document what is going on. Also add a test for removing
a case that is in 'f.sentCases' but not 'cases'.
2018-05-10 13:26:36 +03:00
gary rong
7beccb29be
all: get rid of error when creating memory database ( #16716 )
...
* all: get rid of error when create mdb
* core: clean up variables definition
* all: inline mdb definition
2018-05-09 15:24:25 +03:00
Andrea Franz
5dbd8b42a9
whisper/shhclient: update call to shh_generateSymKeyFromPassword to pass a string ( #16668 )
2018-05-09 13:40:59 +02:00
gary rong
4e7dc34ff1
eth/filter: check nil pointer when unsubscribe ( #16682 )
...
* eth/filter: check nil pointer when unsubscribe
* eth/filters, accounts, rpc: abort system if subscribe failed
* eth/filter: add crit log before exit
* eth/filter, event: minor fixes
2018-05-09 11:29:25 +03:00
kiel barry
4747aad160
eth: golint fixes to variable names ( #16711 )
2018-05-09 10:59:00 +03:00
kiel barry
4ea493e7eb
cmd: various golint fixes ( #16700 )
...
* cmd: various golint fixes
* cmd: update to pr change request
* cmd: update to pr change request
2018-05-09 10:38:03 +03:00
Guilherme Salgado
c60f6f6214
p2p: don't discard reason set by Disconnect ( #16559 )
...
Peer.run was discarding the reason for disconnection sent to the disc
channel by Disconnect.
2018-05-09 01:20:20 +02:00
kiel barry
ba975dc093
crypto: fix golint warnings ( #16710 )
2018-05-09 01:17:09 +02:00
ligi
eab6e5a317
build: specify the key to use when invoking gpg:sign-and-deploy-file ( #16696 )
2018-05-09 01:13:53 +02:00
Ivan Daniluk
c4a4613d95
p2p/simulations/adapters: fix websocket log line parsing in exec adapter ( #16667 )
2018-05-08 17:05:27 +02:00
Domino Valdano
fedae95015
eth/filters: derive FilterCriteria from ethereum.FilterQuery ( #16629 )
2018-05-08 14:39:15 +02:00
kiel barry
864e80a48f
p2p: fix some golint warnings ( #16577 )
2018-05-08 13:08:43 +02:00
kiel barry
a42be3b78d
rlp: fix some golint warnings ( #16659 )
2018-05-08 11:48:07 +02:00
Péter Szilágyi
6cf0ab38bd
core/rawdb: separate raw database access to own package ( #16666 )
2018-05-07 14:35:06 +03:00
Erichin
5463ed9996
mobile: add GetStatus Method for Receipt ( #16598 )
2018-05-07 11:32:51 +03:00
GagziW
d7be5c6619
common: changed if-else blocks to conform with golint ( #16656 )
2018-05-07 11:26:39 +03:00
Ivan Daniluk
d2fe83dc5c
whisper/mailserver: pass init error to the caller ( #16671 )
...
* whisper/mailserver: pass init error to the caller
* whisper/mailserver: add returns to fmt.Errorf
* whisper/mailserver: check err in mailserver init test
2018-05-04 12:10:18 +03:00
Eli
16f3c31773
signer: fix golint errors ( #16653 )
...
* signer/*: golint fixes
Specifically naming and comment formatting for documentation
* signer/*: fixed naming error crashing build
* signer/*: corrected error
* signer/core: fix tiny error whitespace
* signer/rules: fix test refactor
2018-05-04 11:04:17 +03:00
kiel barry
5b3af4c3d1
eth: golint updates for this or self warning ( #16632 )
...
* eth/*:golint updates for this or self warning
* eth/*: golint updates for this or self warning, pr updated per feedback
2018-05-03 15:15:33 +03:00
kiel barry
60b433ab84
event: golint updates for this or self warning ( #16631 )
...
* event/*: golint updates for this or self warning
* event/*: golint updates for this or self warning, pr updated per feedback
2018-05-03 14:54:36 +03:00
YH-Zhou
fd3da7c69d
consensus/ethash: fixed typo ( #16665 )
2018-05-03 12:44:47 +03:00
kiel barry
cd9a1d5b37
metrics: golint updates for this or self warning ( #16635 )
...
* metrics/*: golint updates for this or self warning
* metrics/*: golint updates for this or self warning, updated pr from feedback
2018-05-03 12:43:59 +03:00
kiel barry
2ad511ce09
rpc: golint error with context as last parameter ( #16657 )
...
* rpc/*: golint error with context as last parameter
* Update json.go
2018-05-03 11:41:22 +03:00
GagziW
541f299fbb
accounts: changed if-else blocks to conform with golint ( #16654 )
2018-05-03 11:37:56 +03:00
GagziW
7c02933275
les: changed if-else blocks to conform with golint ( #16658 )
2018-05-03 11:35:06 +03:00
GagziW
f2447bd4c3
p2p: changed if-else blocks to conform with golint ( #16660 )
2018-05-03 11:33:39 +03:00
GagziW
ea1724de1a
log: changed if-else blocks to conform with golint ( #16661 )
2018-05-03 11:30:12 +03:00
Péter Szilágyi
577d375a0d
VERSION, params: begin v1.8.8 release cycle
2018-05-02 14:04:09 +03:00
Péter Szilágyi
66432f3821
params: release geth 1.8.7
2018-05-02 14:01:38 +03:00
Martin Holst Swende
5d4d79ae26
cmd/clef: documentation about setup ( #16568 )
...
clef: documentation about setup
2018-05-02 13:31:05 +03:00
Péter Szilágyi
6a01363d1d
Merge pull request #16644 from ligi/reduce_aar_size
...
build: Add ldflags "-s -w" when building aar
2018-05-02 12:23:24 +03:00
ligi
58c4e033f4
build: Add ldflags -s -w when building aar
...
Smaller size on mobile is always good.
Might also solve our maven central upload problem
2018-05-02 11:21:24 +02:00
Péter Szilágyi
5449139ca2
Merge pull request #16569 from holiman/evm_blocknum
...
cmd/evm: use block number from genesis
2018-05-02 11:48:38 +03:00
Péter Szilágyi
579ac6287b
Merge pull request #16576 from CrispinFlowerday/bugfix/local_underpriced_txs
...
core: ensure local transactions aren't discarded as underpriced
2018-05-02 11:34:47 +03:00
kiel barry
a7720b5926
core: golint updates for this or self warning ( #16633 )
2018-05-02 11:27:59 +03:00
kiel barry
670bae4cd3
internal: golint updates for this or self warning ( #16634 )
2018-05-02 11:26:21 +03:00
Eli
4a8d5d2b1e
trie: golint iterator fixes ( #16639 )
2018-05-02 11:24:34 +03:00
Eli
d76c5ca532
tests: golint fixes for tests directory ( #16640 )
2018-05-02 11:20:19 +03:00
kiel barry
c1ea527573
accounts: golint updates for this or self warning ( #16627 )
2018-05-02 11:17:52 +03:00
Martin Holst Swende
8dfa4f46a9
evm/main: use blocknumber from genesis
2018-05-02 10:17:00 +02:00
Crispin Flowerday
0afd767537
core: ensure local transactions aren't discarded as underpriced
...
This fixes an issue where local transactions are discarded as
underpriced when the pool and queue are full.
2018-05-02 11:04:40 +03:00
Péter Szilágyi
448d17b8f7
Merge pull request #16630 from tstranex/master
...
vendor: Fix index out of range panic when size is bigger than 1 TiB
2018-05-02 10:58:14 +03:00
Péter Szilágyi
9922943b42
Merge pull request #16636 from reductionista/travis
...
travis.yml: remove obsolete brew-cask install
2018-05-02 10:41:50 +03:00
timothy
a1949d0788
vendor: fix leveldb crash when bigger than 1 TiB
2018-05-02 10:34:31 +03:00
Eli
9f6af6f812
whisper: Golint fixes in whisper packages ( #16637 )
2018-05-02 08:17:17 +02:00
Domino Valdano
ea171d5bd9
travis.yml: remove obsolete brew-cask install
2018-05-01 11:41:34 -07:00
Péter Szilágyi
1da33028ce
Merge pull request #16588 from karalabe/tracer-dirty-fix
...
core, eth: fix tracer dirty finalization
2018-04-27 16:28:19 +03:00
Péter Szilágyi
7a7428a027
core, eth: fix tracer dirty finalization
2018-04-27 14:29:18 +03:00
xincaosu
cfe8f5fd94
trie: remove unused `buf` parameter ( #16583 )
2018-04-27 12:45:02 +03:00
Martin Klepsch
852aa143ac
cmd/utils: point users to --syncmode under DEPRECATED ( #16572 )
...
Indicate that --light and --fast options are replaced by --syncmode
2018-04-27 12:32:06 +03:00