From d7851e635936dc71f649b8836d0afa2e8764edd6 Mon Sep 17 00:00:00 2001 From: rene <41963722+renaynay@users.noreply.github.com> Date: Fri, 27 Mar 2020 13:52:53 +0100 Subject: [PATCH] graphql, node, rpc: fix typos in comments (#20824) --- graphql/service.go | 2 +- node/node.go | 6 +++--- rpc/endpoints.go | 1 - rpc/http.go | 4 ++-- rpc/subscription.go | 4 ++-- 5 files changed, 8 insertions(+), 9 deletions(-) diff --git a/graphql/service.go b/graphql/service.go index f640756806..21892402db 100644 --- a/graphql/service.go +++ b/graphql/service.go @@ -35,7 +35,7 @@ type Service struct { cors []string // Allowed CORS domains vhosts []string // Recognised vhosts timeouts rpc.HTTPTimeouts // Timeout settings for HTTP requests. - backend ethapi.Backend // The backend that queries will operate onn. + backend ethapi.Backend // The backend that queries will operate on. handler http.Handler // The `http.Handler` used to answer queries. listener net.Listener // The listening socket. } diff --git a/node/node.go b/node/node.go index 7d8f9b07b9..39e15e0a74 100644 --- a/node/node.go +++ b/node/node.go @@ -158,7 +158,7 @@ func (n *Node) Register(constructor ServiceConstructor) error { return nil } -// Start create a live P2P node and starts running it. +// Start creates a live P2P node and starts running it. func (n *Node) Start() error { n.lock.Lock() defer n.lock.Unlock() @@ -235,7 +235,7 @@ func (n *Node) Start() error { // Mark the service started for potential cleanup started = append(started, kind) } - // Lastly start the configured RPC interfaces + // Lastly, start the configured RPC interfaces if err := n.startRPC(services); err != nil { for _, service := range services { service.Stop() @@ -274,7 +274,7 @@ func (n *Node) openDataDir() error { return nil } -// startRPC is a helper method to start all the various RPC endpoint during node +// startRPC is a helper method to start all the various RPC endpoints during node // startup. It's not meant to be called at any time afterwards as it makes certain // assumptions about the state of the node. func (n *Node) startRPC(services map[reflect.Type]Service) error { diff --git a/rpc/endpoints.go b/rpc/endpoints.go index 09f389d71b..07aaa44122 100644 --- a/rpc/endpoints.go +++ b/rpc/endpoints.go @@ -103,7 +103,6 @@ func StartWSEndpoint(endpoint string, apis []API, modules []string, wsOrigins [] } go NewWSServer(wsOrigins, handler).Serve(listener) return listener, handler, err - } // StartIPCEndpoint starts an IPC endpoint. diff --git a/rpc/http.go b/rpc/http.go index 40810c7b44..1cf6d90393 100644 --- a/rpc/http.go +++ b/rpc/http.go @@ -250,8 +250,8 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) { http.Error(w, err.Error(), code) return } - // All checks passed, create a codec that reads direct from the request body - // until EOF, write the response to w, and order the server to process a + // All checks passed, create a codec that reads directly from the request body + // until EOF, writes the response to w, and orders the server to process a // single request. ctx := r.Context() ctx = context.WithValue(ctx, "remote", r.RemoteAddr) diff --git a/rpc/subscription.go b/rpc/subscription.go index 8992bfc5e1..f9d60dcb98 100644 --- a/rpc/subscription.go +++ b/rpc/subscription.go @@ -153,7 +153,7 @@ func (n *Notifier) takeSubscription() *Subscription { return n.sub } -// acticate is called after the subscription ID was sent to client. Notifications are +// activate is called after the subscription ID was sent to client. Notifications are // buffered before activation. This prevents notifications being sent to the client before // the subscription ID is sent to the client. func (n *Notifier) activate() error { @@ -179,7 +179,7 @@ func (n *Notifier) send(sub *Subscription, data json.RawMessage) error { }) } -// A Subscription is created by a notifier and tight to that notifier. The client can use +// A Subscription is created by a notifier and tied to that notifier. The client can use // this subscription to wait for an unsubscribe request for the client, see Err(). type Subscription struct { ID ID