interesting
/
go-ethereum
mirror of https://github.com/ethereum/go-ethereum.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

cmd/devp2p/internal/v4test: add pong validation in bond (#26400)

This commit is contained in:
strykerin 2023-01-03 07:30:34 -03:00 committed by GitHub
parent dad92500e7
commit c6a2f77c2e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/devp2p/internal/v4test/discv4tests.go
View File

@ -395,7 +395,7 @@ func FindnodePastExpiration(t *utesting.T) {
// bond performs the endpoint proof with the remote node. // bond performs the endpoint proof with the remote node.
func bond(t *utesting.T, te *testenv) { func bond(t *utesting.T, te *testenv) {
te.send(te.l1, &v4wire.Ping{ pingHash := te.send(te.l1, &v4wire.Ping{
Version: 4, Version: 4,
From: te.localEndpoint(te.l1), From: te.localEndpoint(te.l1),
To: te.remoteEndpoint(), To: te.remoteEndpoint(),
@ -417,7 +417,9 @@ func bond(t *utesting.T, te *testenv) {
}) })
gotPing = true gotPing = true
case *v4wire.Pong: case *v4wire.Pong:
// TODO: maybe verify pong data here if err := te.checkPong(req, pingHash); err != nil {
t.Fatal(err)
}
gotPong = true gotPong = true
} }
} }