From 9095b37343c5149c84433841599ca13327219422 Mon Sep 17 00:00:00 2001 From: Taylor Gerring Date: Sun, 16 Nov 2014 13:45:46 -0600 Subject: [PATCH] Convert vm test to checker Tests are skipped due to reliance on deprecated mutan --- vm/main_test.go | 9 ++ vm/vm_test.go | 286 +++++++++++++++++++++++------------------------- 2 files changed, 148 insertions(+), 147 deletions(-) create mode 100644 vm/main_test.go diff --git a/vm/main_test.go b/vm/main_test.go new file mode 100644 index 0000000000..0ae03bf6aa --- /dev/null +++ b/vm/main_test.go @@ -0,0 +1,9 @@ +package vm + +import ( + "testing" + + checker "gopkg.in/check.v1" +) + +func Test(t *testing.T) { checker.TestingT(t) } diff --git a/vm/vm_test.go b/vm/vm_test.go index d9e2a32953..19aa171a62 100644 --- a/vm/vm_test.go +++ b/vm/vm_test.go @@ -1,189 +1,181 @@ package vm -// import ( -// "bytes" -// "fmt" -// "io/ioutil" -// "log" -// "math/big" -// "os" -// "testing" +import ( + "fmt" + "io/ioutil" + "log" + "math/big" + "os" -// "github.com/ethereum/go-ethereum/crypto" -// "github.com/ethereum/go-ethereum/ethutil" -// "github.com/ethereum/go-ethereum/logger" -// "github.com/ethereum/go-ethereum/state" -// "github.com/ethereum/go-ethereum/trie" -// // "github.com/obscuren/mutan" -// ) + "github.com/ethereum/go-ethereum/crypto" + "github.com/ethereum/go-ethereum/ethutil" + "github.com/ethereum/go-ethereum/logger" + "github.com/ethereum/go-ethereum/state" + "github.com/ethereum/go-ethereum/trie" + checker "gopkg.in/check.v1" + // "github.com/obscuren/mutan" +) -// type TestEnv struct{} +type VmSuite struct{} -// func (TestEnv) Origin() []byte { return nil } -// func (TestEnv) BlockNumber() *big.Int { return nil } -// func (TestEnv) BlockHash() []byte { return nil } -// func (TestEnv) PrevHash() []byte { return nil } -// func (TestEnv) Coinbase() []byte { return nil } -// func (TestEnv) Time() int64 { return 0 } -// func (TestEnv) GasLimit() *big.Int { return nil } -// func (TestEnv) Difficulty() *big.Int { return nil } -// func (TestEnv) Value() *big.Int { return nil } -// func (TestEnv) AddLog(state.Log) {} +var _ = checker.Suite(&VmSuite{}) +var big9 = ethutil.Hex2Bytes("0000000000000000000000000000000000000000000000000000000000000009") -// func (TestEnv) Transfer(from, to Account, amount *big.Int) error { -// return nil -// } +const mutcode = ` +var x = 0; +for i := 0; i < 10; i++ { + x = i +} -// // This is likely to fail if anything ever gets looked up in the state trie :-) -// func (TestEnv) State() *state.State { -// return state.New(trie.New(nil, "")) -// } +return x` -// const mutcode = ` -// var x = 0; -// for i := 0; i < 10; i++ { -// x = i -// } +type TestEnv struct{} -// return x` +func (TestEnv) Origin() []byte { return nil } +func (TestEnv) BlockNumber() *big.Int { return nil } +func (TestEnv) BlockHash() []byte { return nil } +func (TestEnv) PrevHash() []byte { return nil } +func (TestEnv) Coinbase() []byte { return nil } +func (TestEnv) Time() int64 { return 0 } +func (TestEnv) GasLimit() *big.Int { return nil } +func (TestEnv) Difficulty() *big.Int { return nil } +func (TestEnv) Value() *big.Int { return nil } +func (TestEnv) AddLog(*state.Log) {} +func (TestEnv) Transfer(from, to Account, amount *big.Int) error { + return nil +} -// func setup(level logger.LogLevel, typ Type) (*Closure, VirtualMachine) { -// code, err := ethutil.Compile(mutcode, true) -// if err != nil { -// log.Fatal(err) -// } +// This is likely to fail if anything ever gets looked up in the state trie :-) +func (TestEnv) State() *state.State { + return state.New(trie.New(nil, "")) +} -// // Pipe output to /dev/null -// logger.AddLogSystem(logger.NewStdLogSystem(ioutil.Discard, log.LstdFlags, level)) +func setup(level logger.LogLevel, typ Type) (*Closure, VirtualMachine) { + code, err := ethutil.Compile(mutcode, true) + if err != nil { + log.Fatal(err) + } -// ethutil.ReadConfig(".ethtest", "/tmp/ethtest", "") + // Pipe output to /dev/null + logger.AddLogSystem(logger.NewStdLogSystem(ioutil.Discard, log.LstdFlags, level)) -// stateObject := state.NewStateObject([]byte{'j', 'e', 'f', 'f'}) -// callerClosure := NewClosure(nil, stateObject, stateObject, code, big.NewInt(1000000), big.NewInt(0)) + ethutil.ReadConfig(".ethtest", "/tmp/ethtest", "") -// return callerClosure, New(TestEnv{}, typ) -// } + stateObject := state.NewStateObject([]byte{'j', 'e', 'f', 'f'}) + callerClosure := NewClosure(nil, stateObject, stateObject, code, big.NewInt(1000000), big.NewInt(0)) -// var big9 = ethutil.Hex2Bytes("0000000000000000000000000000000000000000000000000000000000000009") + return callerClosure, New(TestEnv{}, typ) +} -// func TestDebugVm(t *testing.T) { -// // if mutan.Version < "0.6" { -// // t.Skip("skipping for mutan version", mutan.Version, " < 0.6") -// // } +func (s *VmSuite) TestDebugVm(c *checker.C) { + // if mutan.Version < "0.6" { + // t.Skip("skipping for mutan version", mutan.Version, " < 0.6") + // } + closure, vm := setup(logger.DebugLevel, DebugVmTy) + ret, _, e := closure.Call(vm, nil) + c.Assert(e, checker.NotNil) + c.Skip("Depends on mutan") + c.Assert(ret, checker.DeepEquals, big9) +} -// closure, vm := setup(logger.DebugLevel, DebugVmTy) -// ret, _, e := closure.Call(vm, nil) -// if e != nil { -// t.Fatalf("Call returned error: %v", e) -// } -// if !bytes.Equal(ret, big9) { -// t.Errorf("Wrong return value '%x', want '%x'", ret, big9) -// } -// } +func (s *VmSuite) TestVm(c *checker.C) { + // if mutan.Version < "0.6" { + // t.Skip("skipping for mutan version", mutan.Version, " < 0.6") + // } + closure, vm := setup(logger.DebugLevel, StandardVmTy) + ret, _, e := closure.Call(vm, nil) + c.Assert(e, checker.NotNil) + c.Skip("Depends on mutan") + c.Assert(ret, checker.DeepEquals, big9) +} -// func TestVm(t *testing.T) { -// // if mutan.Version < "0.6" { -// // t.Skip("skipping for mutan version", mutan.Version, " < 0.6") -// // } +func (s *VmSuite) BenchmarkDebugVm(c *checker.C) { + closure, vm := setup(logger.InfoLevel, StandardVmTy) -// closure, vm := setup(logger.DebugLevel, StandardVmTy) -// ret, _, e := closure.Call(vm, nil) -// if e != nil { -// t.Fatalf("Call returned error: %v", e) -// } -// if !bytes.Equal(ret, big9) { -// t.Errorf("Wrong return value '%x', want '%x'", ret, big9) -// } -// } + c.ResetTimer() -// func BenchmarkDebugVm(b *testing.B) { -// closure, vm := setup(logger.InfoLevel, DebugVmTy) + for i := 0; i < c.N; i++ { + closure.Call(vm, nil) + } +} -// b.ResetTimer() +func (s *VmSuite) BenchmarkVm(c *checker.C) { + closure, vm := setup(logger.InfoLevel, DebugVmTy) -// for i := 0; i < b.N; i++ { -// closure.Call(vm, nil) -// } -// } + c.ResetTimer() -// func BenchmarkVm(b *testing.B) { -// closure, vm := setup(logger.InfoLevel, StandardVmTy) + for i := 0; i < c.N; i++ { + closure.Call(vm, nil) + } +} -// b.ResetTimer() +func RunCode(mutCode string, typ Type) []byte { + code, err := ethutil.Compile(mutCode, true) + if err != nil { + log.Fatal(err) + } -// for i := 0; i < b.N; i++ { -// closure.Call(vm, nil) -// } -// } + logger.AddLogSystem(logger.NewStdLogSystem(os.Stdout, log.LstdFlags, logger.InfoLevel)) -// func RunCode(mutCode string, typ Type) []byte { -// code, err := ethutil.Compile(mutCode, true) -// if err != nil { -// log.Fatal(err) -// } + ethutil.ReadConfig(".ethtest", "/tmp/ethtest", "") -// logger.AddLogSystem(logger.NewStdLogSystem(os.Stdout, log.LstdFlags, logger.InfoLevel)) + stateObject := state.NewStateObject([]byte{'j', 'e', 'f', 'f'}) + closure := NewClosure(nil, stateObject, stateObject, code, big.NewInt(1000000), big.NewInt(0)) -// ethutil.ReadConfig(".ethtest", "/tmp/ethtest", "") + vm := New(TestEnv{}, typ) + ret, _, e := closure.Call(vm, nil) + if e != nil { + fmt.Println(e) + } -// stateObject := state.NewStateObject([]byte{'j', 'e', 'f', 'f'}) -// closure := NewClosure(nil, stateObject, stateObject, code, big.NewInt(1000000), big.NewInt(0)) + return ret +} -// vm := New(TestEnv{}, typ) -// ret, _, e := closure.Call(vm, nil) -// if e != nil { -// fmt.Println(e) -// } +func (s *VmSuite) TestBuildInSha256(c *checker.C) { + ret := RunCode(` + var in = 42 + var out = 0 -// return ret -// } + call(0x2, 0, 10000, in, out) -// func TestBuildInSha256(t *testing.T) { -// ret := RunCode(` -// var in = 42 -// var out = 0 + return out + `, DebugVmTy) -// call(0x2, 0, 10000, in, out) + exp := crypto.Sha256(ethutil.LeftPadBytes([]byte{42}, 32)) + c.Skip("Depends on mutan") + c.Assert(ret, checker.DeepEquals, exp) +} -// return out -// `, DebugVmTy) +func (s *VmSuite) TestBuildInRipemd(c *checker.C) { + ret := RunCode(` + var in = 42 + var out = 0 -// exp := crypto.Sha256(ethutil.LeftPadBytes([]byte{42}, 32)) -// if bytes.Compare(ret, exp) != 0 { -// t.Errorf("Expected %x, got %x", exp, ret) -// } -// } + call(0x3, 0, 10000, in, out) -// func TestBuildInRipemd(t *testing.T) { -// ret := RunCode(` -// var in = 42 -// var out = 0 + return out + `, DebugVmTy) -// call(0x3, 0, 10000, in, out) + exp := ethutil.RightPadBytes(crypto.Ripemd160(ethutil.LeftPadBytes([]byte{42}, 32)), 32) + c.Skip("Depends on mutan") + c.Assert(ret, checker.DeepEquals, exp) +} -// return out -// `, DebugVmTy) +func (s *VmSuite) TestOog(c *checker.C) { + // This tests takes a long time and will eventually run out of gas + // t.Skip() + c.Skip("This tests takes a long time and will eventually run out of gas") -// exp := ethutil.RightPadBytes(crypto.Ripemd160(ethutil.LeftPadBytes([]byte{42}, 32)), 32) -// if bytes.Compare(ret, exp) != 0 { -// t.Errorf("Expected %x, got %x", exp, ret) -// } -// } + logger.AddLogSystem(logger.NewStdLogSystem(os.Stdout, log.LstdFlags, logger.InfoLevel)) -// func TestOog(t *testing.T) { -// // This tests takes a long time and will eventually run out of gas -// // t.Skip() + ethutil.ReadConfig(".ethtest", "/tmp/ethtest", "") -// logger.AddLogSystem(logger.NewStdLogSystem(os.Stdout, log.LstdFlags, logger.InfoLevel)) + stateObject := state.NewStateObject([]byte{'j', 'e', 'f', 'f'}) + closure := NewClosure(nil, stateObject, stateObject, ethutil.Hex2Bytes("60ff60ff600057"), big.NewInt(1000000), big.NewInt(0)) -// ethutil.ReadConfig(".ethtest", "/tmp/ethtest", "") - -// stateObject := state.NewStateObject([]byte{'j', 'e', 'f', 'f'}) -// closure := NewClosure(nil, stateObject, stateObject, ethutil.Hex2Bytes("60ff60ff600057"), big.NewInt(1000000), big.NewInt(0)) - -// vm := New(TestEnv{}, DebugVmTy) -// _, _, e := closure.Call(vm, nil) -// if e != nil { -// fmt.Println(e) -// } -// } + vm := New(TestEnv{}, DebugVmTy) + _, _, e := closure.Call(vm, nil) + if e != nil { + fmt.Println(e) + } +}