From 7ac08ba4e0bf3dc28a8e2fff16482e4dc18d60dc Mon Sep 17 00:00:00 2001 From: joohhnnn <68833933+joohhnnn@users.noreply.github.com> Date: Mon, 8 May 2023 15:01:14 +0800 Subject: [PATCH] cmd/geth: rename variable 'extapi' (#27223) rename parameter In this case, the naming of "extapi" might create some confusion. Although it represents an External Signer Backend, its name could be mistaken for an API. In reality, it is a backend instance used for communicating with external signers. A better naming choice could be "extBackend" or "externalBackend" to more accurately describe that it is a backend instance rather than an API. --- cmd/geth/config.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/geth/config.go b/cmd/geth/config.go index 816762a683..42ded49322 100644 --- a/cmd/geth/config.go +++ b/cmd/geth/config.go @@ -288,8 +288,8 @@ func setAccountManagerBackends(conf *node.Config, am *accounts.Manager, keydir s // Assemble the supported backends if len(conf.ExternalSigner) > 0 { log.Info("Using external signer", "url", conf.ExternalSigner) - if extapi, err := external.NewExternalBackend(conf.ExternalSigner); err == nil { - am.AddBackend(extapi) + if extBackend, err := external.NewExternalBackend(conf.ExternalSigner); err == nil { + am.AddBackend(extBackend) return nil } else { return fmt.Errorf("error connecting to external signer: %v", err)