From 77158e5bf0e80433b04ad2169ed3fee069594bf7 Mon Sep 17 00:00:00 2001 From: Jared Wasinger Date: Tue, 26 Nov 2024 19:31:58 +0700 Subject: [PATCH] various small fixes: better error message, remove unecessary comments. address review about missing word in function documentation. --- accounts/abi/bind/bind.go | 3 ++- accounts/abi/bind/v2/lib_test.go | 6 +----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/accounts/abi/bind/bind.go b/accounts/abi/bind/bind.go index a4655bb64a..e4bdf41f1e 100644 --- a/accounts/abi/bind/bind.go +++ b/accounts/abi/bind/bind.go @@ -365,7 +365,8 @@ func bind(types []string, abis []string, bytecodes []string, fsigs []map[string] // methods (which in v1 recursively deploy their // library dependencies). So, the entire set of // library dependencies is required, and we will - // the order to deploy and link them at runtime. + // determine the order to deploy and link them at + // runtime. var findDeps func(contract *tmplContract) map[string]struct{} findDeps = func(contract *tmplContract) map[string]struct{} { // 1) match all libraries that this contract depends on diff --git a/accounts/abi/bind/v2/lib_test.go b/accounts/abi/bind/v2/lib_test.go index ff96e92b21..612a38f97a 100644 --- a/accounts/abi/bind/v2/lib_test.go +++ b/accounts/abi/bind/v2/lib_test.go @@ -92,9 +92,6 @@ func TestDeployment(t *testing.T) { Backend: backend, Client: backend.Client(), } - - //log.SetDefault(log.NewLogger(log.NewTerminalHandlerWithLevel(os.Stdout, log.LevelDebug, true))) - ctrct, err := nested_libraries.NewC1() if err != nil { panic(err) @@ -102,9 +99,8 @@ func TestDeployment(t *testing.T) { constructorInput, err := ctrct.PackConstructor(big.NewInt(42), big.NewInt(1)) if err != nil { - t.Fatalf("fack %v", err) + t.Fatalf("failed to pack constructor: %v", err) } - // TODO: test case with arguments-containing constructor deploymentParams := DeploymentParams{ Contracts: []ContractDeployParams{ {