interesting
/
go-ethereum
mirror of https://github.com/ethereum/go-ethereum.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

core, eth/downloader: make body validation more strict (#26704)

This commit is contained in:
Martin Holst Swende 2023-02-16 05:10:16 -05:00 committed by GitHub
parent 08bf8a60c3
commit 645e3e86c4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/block_validator.go
View File

@ -76,6 +76,9 @@ func (v *BlockValidator) ValidateBody(block *types.Block) error {
if hash := types.DeriveSha(block.Withdrawals(), trie.NewStackTrie(nil)); hash != *header.WithdrawalsHash { if hash := types.DeriveSha(block.Withdrawals(), trie.NewStackTrie(nil)); hash != *header.WithdrawalsHash {
return fmt.Errorf("withdrawals root hash mismatch (header value %x, calculated %x)", *header.WithdrawalsHash, hash) return fmt.Errorf("withdrawals root hash mismatch (header value %x, calculated %x)", *header.WithdrawalsHash, hash)
} }
} else if block.Withdrawals() != nil {
// Withdrawals are not allowed prior to shanghai fork
return fmt.Errorf("withdrawals present in block body")
} }
if !v.bc.HasBlockAndState(block.ParentHash(), block.NumberU64()-1) { if !v.bc.HasBlockAndState(block.ParentHash(), block.NumberU64()-1) {

19
eth/downloader/queue.go
View File

@ -781,14 +781,17 @@ func (q *queue) DeliverBodies(id string, txLists [][]*types.Transaction, txListH
return errInvalidBody return errInvalidBody
} }
if header.WithdrawalsHash == nil { if header.WithdrawalsHash == nil {
// discard any withdrawals if we don't have a withdrawal hash set // nil hash means there withdrawals should not be present in body
withdrawalLists[index] = nil if withdrawalLists[index] != nil {
} else if *header.WithdrawalsHash == types.EmptyRootHash && withdrawalLists[index] == nil { return errInvalidBody
// if the withdrawal hash is the emptyRootHash, }
// we expect withdrawals to be [] instead of nil } else { // non-nil hash: body must have withdrawals
withdrawalLists[index] = make([]*types.Withdrawal, 0) if withdrawalLists[index] == nil {
} else if withdrawalListHashes[index] != *header.WithdrawalsHash { return errInvalidBody
return errInvalidBody }
if withdrawalListHashes[index] != *header.WithdrawalsHash {
return errInvalidBody
}
} }
return nil return nil
} }