interesting
/
go-ethereum
mirror of https://github.com/ethereum/go-ethereum.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

node: rename startNetworking to openEndpoints (#22105)

This commit is contained in:
rene 2021-01-04 12:39:25 +01:00 committed by GitHub
parent 47820ef726
commit 5c2a7ce2cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
node/node.go
View File

@ -159,12 +159,13 @@ func (n *Node) Start() error {
return ErrNodeStopped return ErrNodeStopped
} }
n.state = runningState n.state = runningState
err := n.startNetworking() // open networking and RPC endpoints
err := n.openEndpoints()
lifecycles := make([]Lifecycle, len(n.lifecycles)) lifecycles := make([]Lifecycle, len(n.lifecycles))
copy(lifecycles, n.lifecycles) copy(lifecycles, n.lifecycles)
n.lock.Unlock() n.lock.Unlock()
// Check if networking startup failed. // Check if endpoint startup failed.
if err != nil { if err != nil {
n.doClose(nil) n.doClose(nil)
return err return err
@ -247,12 +248,14 @@ func (n *Node) doClose(errs []error) error {
} }
} }
// startNetworking starts all network endpoints. // openEndpoints starts all network and RPC endpoints.
func (n *Node) startNetworking() error { func (n *Node) openEndpoints() error {
// start networking endpoints
n.log.Info("Starting peer-to-peer node", "instance", n.server.Name) n.log.Info("Starting peer-to-peer node", "instance", n.server.Name)
if err := n.server.Start(); err != nil { if err := n.server.Start(); err != nil {
return convertFileLockError(err) return convertFileLockError(err)
} }
// start RPC endpoints
err := n.startRPC() err := n.startRPC()
if err != nil { if err != nil {
n.stopRPC() n.stopRPC()