interesting
/
go-ethereum
mirror of https://github.com/ethereum/go-ethereum.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

core/txpool: improve error responses with wrapped errors (#30715)

This commit is contained in:
piersy 2024-11-04 10:32:41 +00:00 committed by GitHub
parent 6e1fedb12a
commit 484f0f4e84
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/txpool/txpool.go
View File

@ -358,7 +358,7 @@ func (p *TxPool) Add(txs []*types.Transaction, local bool, sync bool) []error {
for i, split := range splits { for i, split := range splits {
// If the transaction was rejected by all subpools, mark it unsupported // If the transaction was rejected by all subpools, mark it unsupported
if split == -1 { if split == -1 {
errs[i] = core.ErrTxTypeNotSupported errs[i] = fmt.Errorf("%w: received type %d", core.ErrTxTypeNotSupported, txs[i].Type())
continue continue
} }
// Find which subpool handled it and pull in the corresponding error // Find which subpool handled it and pull in the corresponding error

2
core/txpool/validation.go
View File

@ -99,7 +99,7 @@ func ValidateTransaction(tx *types.Transaction, head *types.Header, signer types
} }
// Make sure the transaction is signed properly // Make sure the transaction is signed properly
if _, err := types.Sender(signer, tx); err != nil { if _, err := types.Sender(signer, tx); err != nil {
return ErrInvalidSender return fmt.Errorf("%w: %v", ErrInvalidSender, err)
} }
// Ensure the transaction has more gas than the bare minimum needed to cover // Ensure the transaction has more gas than the bare minimum needed to cover
// the transaction metadata // the transaction metadata