interesting
/
go-ethereum
mirror of https://github.com/ethereum/go-ethereum.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refine code review and contribution guidelines

This commit is contained in:
Joe 2022-07-29 11:24:42 +01:00
parent 28572eb110
commit 0a4aa8add5
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
content/docs/developers/contributing.md
View File

@ -27,7 +27,7 @@ unless by explicit agreement because the work is contributing to some more compl
feature branch.
All pull requests will be reviewed according to the
[Code Review guidelines](/content/docs/developers/geth-developer/Code-Review-Guidelines.md).
[Code Review guidelines](/content/docs/developers/geth-developer/code-review-guidelines.md).
We encourage an early pull request approach, meaning pull requests are created as early
as possible even without the completed fix/feature. This will let core devs and other

5
content/docs/developers/geth-developer/Code-Review-Guidelines.md → content/docs/developers/geth-developer/code-review-guidelines.md
View File

@ -3,7 +3,7 @@ title: Code Review Guidelines
sort_key: B
---
The only way to get code into go-ethereum is to send a pull request. Those pull requests
The only way to get code into Geth is to submit a pull request (PR). Those pull requests
need to be reviewed by someone. This document is a guide that explains our expectations
around PRs for both authors and reviewers.
@ -11,9 +11,12 @@ around PRs for both authors and reviewers.
* The **author** of a pull request is the entity who wrote the diff and submitted it to
GitHub.
* The **team** consists of people with commit rights on the go-ethereum repository.
* The **reviewer** is the person assigned to review the diff. The reviewer must be a team
member.
* The **code owner** is the person responsible for the subsystem being modified by the PR.
## The Process