Merge pull request #982 from tgerring/issue962

Check for error on DB fetch of tx
2015-05-14 10:37:30 -07:00 · 2015-05-14 10:37:30 -07:00 · 007bced276
parent 6bc8dec7ac 12f82ab2ff
commit 007bced276
1 changed files with 5 additions and 1 deletions
--- a/xeth/xeth.go
+++ b/xeth/xeth.go
@ -318,7 +318,11 @@ func (self *XEth) EthTransactionByHash(hash string) (tx *types.Transaction, blha
 		Index      uint64
 	}

-	v, _ := self.backend.ExtraDb().Get(append(common.FromHex(hash), 0x0001))
+	v, dberr := self.backend.ExtraDb().Get(append(common.FromHex(hash), 0x0001))
+	// TODO check specifically for ErrNotFound
+	if dberr != nil {
+		return
+	}
 	r := bytes.NewReader(v)
 	err := rlp.Decode(r, &txExtra)
 	if err == nil {