2015-07-06 19:54:22 -05:00
|
|
|
// Copyright 2015 The go-ethereum Authors
|
2015-07-22 11:48:40 -05:00
|
|
|
// This file is part of the go-ethereum library.
|
2015-07-06 19:54:22 -05:00
|
|
|
//
|
2015-07-23 11:35:11 -05:00
|
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
2015-07-06 19:54:22 -05:00
|
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
2015-07-22 11:48:40 -05:00
|
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
2015-07-06 19:54:22 -05:00
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
2015-07-22 11:48:40 -05:00
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
2015-07-06 19:54:22 -05:00
|
|
|
// GNU Lesser General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU Lesser General Public License
|
2015-07-22 11:48:40 -05:00
|
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
2015-07-06 19:54:22 -05:00
|
|
|
|
2015-03-17 07:24:12 -05:00
|
|
|
package common
|
|
|
|
|
2016-04-21 21:33:24 -05:00
|
|
|
import (
|
2017-02-22 10:59:59 -06:00
|
|
|
"encoding/json"
|
cmd/clef, signer: initial poc of the standalone signer (#16154)
* signer: introduce external signer command
* cmd/signer, rpc: Implement new signer. Add info about remote user to Context
* signer: refactored request/response, made use of urfave.cli
* cmd/signer: Use common flags
* cmd/signer: methods to validate calldata against abi
* cmd/signer: work on abi parser
* signer: add mutex around UI
* cmd/signer: add json 4byte directory, remove passwords from api
* cmd/signer: minor changes
* cmd/signer: Use ErrRequestDenied, enable lightkdf
* cmd/signer: implement tests
* cmd/signer: made possible for UI to modify tx parameters
* cmd/signer: refactors, removed channels in ui comms, added UI-api via stdin/out
* cmd/signer: Made lowercase json-definitions, added UI-signer test functionality
* cmd/signer: update documentation
* cmd/signer: fix bugs, improve abi detection, abi argument display
* cmd/signer: minor change in json format
* cmd/signer: rework json communication
* cmd/signer: implement mixcase addresses in API, fix json id bug
* cmd/signer: rename fromaccount, update pythonpoc with new json encoding format
* cmd/signer: make use of new abi interface
* signer: documentation
* signer/main: remove redundant option
* signer: implement audit logging
* signer: create package 'signer', minor changes
* common: add 0x-prefix to mixcaseaddress in json marshalling + validation
* signer, rules, storage: implement rules + ephemeral storage for signer rules
* signer: implement OnApprovedTx, change signing response (API BREAKAGE)
* signer: refactoring + documentation
* signer/rules: implement dispatching to next handler
* signer: docs
* signer/rules: hide json-conversion from users, ensure context is cleaned
* signer: docs
* signer: implement validation rules, change signature of call_info
* signer: fix log flaw with string pointer
* signer: implement custom 4byte databsae that saves submitted signatures
* signer/storage: implement aes-gcm-backed credential storage
* accounts: implement json unmarshalling of url
* signer: fix listresponse, fix gas->uint64
* node: make http/ipc start methods public
* signer: add ipc capability+review concerns
* accounts: correct docstring
* signer: address review concerns
* rpc: go fmt -s
* signer: review concerns+ baptize Clef
* signer,node: move Start-functions to separate file
* signer: formatting
2018-04-16 07:04:32 -05:00
|
|
|
|
2016-04-21 21:33:24 -05:00
|
|
|
"math/big"
|
2016-11-27 17:58:22 -06:00
|
|
|
"strings"
|
2016-04-21 21:33:24 -05:00
|
|
|
"testing"
|
|
|
|
)
|
2015-03-17 07:24:12 -05:00
|
|
|
|
|
|
|
func TestBytesConversion(t *testing.T) {
|
|
|
|
bytes := []byte{5}
|
|
|
|
hash := BytesToHash(bytes)
|
|
|
|
|
|
|
|
var exp Hash
|
|
|
|
exp[31] = 5
|
|
|
|
|
|
|
|
if hash != exp {
|
|
|
|
t.Errorf("expected %x got %x", exp, hash)
|
|
|
|
}
|
|
|
|
}
|
2016-04-01 05:03:06 -05:00
|
|
|
|
2017-12-04 12:34:15 -06:00
|
|
|
func TestIsHexAddress(t *testing.T) {
|
|
|
|
tests := []struct {
|
|
|
|
str string
|
|
|
|
exp bool
|
|
|
|
}{
|
|
|
|
{"0x5aaeb6053f3e94c9b9a09f33669435e7ef1beaed", true},
|
|
|
|
{"5aaeb6053f3e94c9b9a09f33669435e7ef1beaed", true},
|
|
|
|
{"0X5aaeb6053f3e94c9b9a09f33669435e7ef1beaed", true},
|
|
|
|
{"0XAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", true},
|
|
|
|
{"0xAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", true},
|
|
|
|
{"0x5aaeb6053f3e94c9b9a09f33669435e7ef1beaed1", false},
|
|
|
|
{"0x5aaeb6053f3e94c9b9a09f33669435e7ef1beae", false},
|
|
|
|
{"5aaeb6053f3e94c9b9a09f33669435e7ef1beaed11", false},
|
|
|
|
{"0xxaaeb6053f3e94c9b9a09f33669435e7ef1beaed", false},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, test := range tests {
|
|
|
|
if result := IsHexAddress(test.str); result != test.exp {
|
|
|
|
t.Errorf("IsHexAddress(%s) == %v; expected %v",
|
|
|
|
test.str, result, test.exp)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-04-01 05:03:06 -05:00
|
|
|
func TestHashJsonValidation(t *testing.T) {
|
|
|
|
var tests = []struct {
|
|
|
|
Prefix string
|
|
|
|
Size int
|
2016-11-27 17:58:22 -06:00
|
|
|
Error string
|
2016-04-01 05:03:06 -05:00
|
|
|
}{
|
2017-06-23 03:50:49 -05:00
|
|
|
{"", 62, "json: cannot unmarshal hex string without 0x prefix into Go value of type common.Hash"},
|
|
|
|
{"0x", 66, "hex string has length 66, want 64 for common.Hash"},
|
|
|
|
{"0x", 63, "json: cannot unmarshal hex string of odd length into Go value of type common.Hash"},
|
|
|
|
{"0x", 0, "hex string has length 0, want 64 for common.Hash"},
|
2016-11-27 17:58:22 -06:00
|
|
|
{"0x", 64, ""},
|
|
|
|
{"0X", 64, ""},
|
2016-04-01 05:03:06 -05:00
|
|
|
}
|
2016-11-27 17:58:22 -06:00
|
|
|
for _, test := range tests {
|
|
|
|
input := `"` + test.Prefix + strings.Repeat("0", test.Size) + `"`
|
2017-02-22 10:59:59 -06:00
|
|
|
var v Hash
|
|
|
|
err := json.Unmarshal([]byte(input), &v)
|
2016-11-27 17:58:22 -06:00
|
|
|
if err == nil {
|
|
|
|
if test.Error != "" {
|
|
|
|
t.Errorf("%s: error mismatch: have nil, want %q", input, test.Error)
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if err.Error() != test.Error {
|
|
|
|
t.Errorf("%s: error mismatch: have %q, want %q", input, err, test.Error)
|
|
|
|
}
|
2016-04-21 21:33:24 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAddressUnmarshalJSON(t *testing.T) {
|
|
|
|
var tests = []struct {
|
|
|
|
Input string
|
|
|
|
ShouldErr bool
|
|
|
|
Output *big.Int
|
|
|
|
}{
|
|
|
|
{"", true, nil},
|
|
|
|
{`""`, true, nil},
|
|
|
|
{`"0x"`, true, nil},
|
|
|
|
{`"0x00"`, true, nil},
|
|
|
|
{`"0xG000000000000000000000000000000000000000"`, true, nil},
|
|
|
|
{`"0x0000000000000000000000000000000000000000"`, false, big.NewInt(0)},
|
|
|
|
{`"0x0000000000000000000000000000000000000010"`, false, big.NewInt(16)},
|
|
|
|
}
|
|
|
|
for i, test := range tests {
|
2017-02-22 10:59:59 -06:00
|
|
|
var v Address
|
|
|
|
err := json.Unmarshal([]byte(test.Input), &v)
|
2016-04-21 21:33:24 -05:00
|
|
|
if err != nil && !test.ShouldErr {
|
|
|
|
t.Errorf("test #%d: unexpected error: %v", i, err)
|
|
|
|
}
|
|
|
|
if err == nil {
|
|
|
|
if test.ShouldErr {
|
|
|
|
t.Errorf("test #%d: expected error, got none", i)
|
|
|
|
}
|
2017-02-22 10:59:59 -06:00
|
|
|
if v.Big().Cmp(test.Output) != 0 {
|
|
|
|
t.Errorf("test #%d: address mismatch: have %v, want %v", i, v.Big(), test.Output)
|
2016-04-21 21:33:24 -05:00
|
|
|
}
|
2016-04-01 05:03:06 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2017-07-16 07:28:22 -05:00
|
|
|
|
|
|
|
func TestAddressHexChecksum(t *testing.T) {
|
|
|
|
var tests = []struct {
|
|
|
|
Input string
|
|
|
|
Output string
|
|
|
|
}{
|
|
|
|
// Test cases from https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md#specification
|
|
|
|
{"0x5aaeb6053f3e94c9b9a09f33669435e7ef1beaed", "0x5aAeb6053F3E94C9b9A09f33669435E7Ef1BeAed"},
|
|
|
|
{"0xfb6916095ca1df60bb79ce92ce3ea74c37c5d359", "0xfB6916095ca1df60bB79Ce92cE3Ea74c37c5d359"},
|
|
|
|
{"0xdbf03b407c01e7cd3cbea99509d93f8dddc8c6fb", "0xdbF03B407c01E7cD3CBea99509d93f8DDDC8C6FB"},
|
|
|
|
{"0xd1220a0cf47c7b9be7a2e6ba89f429762e7b9adb", "0xD1220A0cf47c7B9Be7A2E6BA89F429762e7b9aDb"},
|
|
|
|
// Ensure that non-standard length input values are handled correctly
|
|
|
|
{"0xa", "0x000000000000000000000000000000000000000A"},
|
|
|
|
{"0x0a", "0x000000000000000000000000000000000000000A"},
|
|
|
|
{"0x00a", "0x000000000000000000000000000000000000000A"},
|
|
|
|
{"0x000000000000000000000000000000000000000a", "0x000000000000000000000000000000000000000A"},
|
|
|
|
}
|
|
|
|
for i, test := range tests {
|
|
|
|
output := HexToAddress(test.Input).Hex()
|
|
|
|
if output != test.Output {
|
|
|
|
t.Errorf("test #%d: failed to match when it should (%s != %s)", i, output, test.Output)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func BenchmarkAddressHex(b *testing.B) {
|
|
|
|
testAddr := HexToAddress("0x5aaeb6053f3e94c9b9a09f33669435e7ef1beaed")
|
|
|
|
for n := 0; n < b.N; n++ {
|
|
|
|
testAddr.Hex()
|
|
|
|
}
|
|
|
|
}
|
cmd/clef, signer: initial poc of the standalone signer (#16154)
* signer: introduce external signer command
* cmd/signer, rpc: Implement new signer. Add info about remote user to Context
* signer: refactored request/response, made use of urfave.cli
* cmd/signer: Use common flags
* cmd/signer: methods to validate calldata against abi
* cmd/signer: work on abi parser
* signer: add mutex around UI
* cmd/signer: add json 4byte directory, remove passwords from api
* cmd/signer: minor changes
* cmd/signer: Use ErrRequestDenied, enable lightkdf
* cmd/signer: implement tests
* cmd/signer: made possible for UI to modify tx parameters
* cmd/signer: refactors, removed channels in ui comms, added UI-api via stdin/out
* cmd/signer: Made lowercase json-definitions, added UI-signer test functionality
* cmd/signer: update documentation
* cmd/signer: fix bugs, improve abi detection, abi argument display
* cmd/signer: minor change in json format
* cmd/signer: rework json communication
* cmd/signer: implement mixcase addresses in API, fix json id bug
* cmd/signer: rename fromaccount, update pythonpoc with new json encoding format
* cmd/signer: make use of new abi interface
* signer: documentation
* signer/main: remove redundant option
* signer: implement audit logging
* signer: create package 'signer', minor changes
* common: add 0x-prefix to mixcaseaddress in json marshalling + validation
* signer, rules, storage: implement rules + ephemeral storage for signer rules
* signer: implement OnApprovedTx, change signing response (API BREAKAGE)
* signer: refactoring + documentation
* signer/rules: implement dispatching to next handler
* signer: docs
* signer/rules: hide json-conversion from users, ensure context is cleaned
* signer: docs
* signer: implement validation rules, change signature of call_info
* signer: fix log flaw with string pointer
* signer: implement custom 4byte databsae that saves submitted signatures
* signer/storage: implement aes-gcm-backed credential storage
* accounts: implement json unmarshalling of url
* signer: fix listresponse, fix gas->uint64
* node: make http/ipc start methods public
* signer: add ipc capability+review concerns
* accounts: correct docstring
* signer: address review concerns
* rpc: go fmt -s
* signer: review concerns+ baptize Clef
* signer,node: move Start-functions to separate file
* signer: formatting
2018-04-16 07:04:32 -05:00
|
|
|
|
|
|
|
func TestMixedcaseAccount_Address(t *testing.T) {
|
|
|
|
|
|
|
|
// https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md
|
|
|
|
// Note: 0X{checksum_addr} is not valid according to spec above
|
|
|
|
|
|
|
|
var res []struct {
|
|
|
|
A MixedcaseAddress
|
|
|
|
Valid bool
|
|
|
|
}
|
|
|
|
if err := json.Unmarshal([]byte(`[
|
|
|
|
{"A" : "0xae967917c465db8578ca9024c205720b1a3651A9", "Valid": false},
|
|
|
|
{"A" : "0xAe967917c465db8578ca9024c205720b1a3651A9", "Valid": true},
|
|
|
|
{"A" : "0XAe967917c465db8578ca9024c205720b1a3651A9", "Valid": false},
|
|
|
|
{"A" : "0x1111111111111111111112222222222223333323", "Valid": true}
|
|
|
|
]`), &res); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, r := range res {
|
|
|
|
if got := r.A.ValidChecksum(); got != r.Valid {
|
|
|
|
t.Errorf("Expected checksum %v, got checksum %v, input %v", r.Valid, got, r.A.String())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
//These should throw exceptions:
|
|
|
|
var r2 []MixedcaseAddress
|
|
|
|
for _, r := range []string{
|
|
|
|
`["0x11111111111111111111122222222222233333"]`, // Too short
|
|
|
|
`["0x111111111111111111111222222222222333332"]`, // Too short
|
|
|
|
`["0x11111111111111111111122222222222233333234"]`, // Too long
|
|
|
|
`["0x111111111111111111111222222222222333332344"]`, // Too long
|
|
|
|
`["1111111111111111111112222222222223333323"]`, // Missing 0x
|
|
|
|
`["x1111111111111111111112222222222223333323"]`, // Missing 0
|
|
|
|
`["0xG111111111111111111112222222222223333323"]`, //Non-hex
|
|
|
|
} {
|
|
|
|
if err := json.Unmarshal([]byte(r), &r2); err == nil {
|
|
|
|
t.Errorf("Expected failure, input %v", r)
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|