Willem Toorop
d987ec0440
Update examples in the API specification
...
They are now actually working with our implementation
2013-12-11 23:55:35 +01:00
Willem Toorop
372c6772b0
Merge branch 'develop' of github.com:verisign/getdns into develop
...
Conflicts:
src/test/Makefile.in
2013-12-11 23:45:47 +01:00
Willem Toorop
51f0299137
Fix example-reverse (and reverse_address)
...
From the example it is clear that network format addresses are expected for getdns_hostname*
2013-12-11 23:41:21 +01:00
Neel Goyal
0c0d5b63ae
Remove a test that shouldn't have been added
2013-12-11 16:46:56 -05:00
Willem Toorop
8a8accea42
Copied examples from spec and fixed everything ;)
...
Well.. fixed the examples so they work and free memory
and fixed our code to return correct dict format with "just_address_answers"
Now tests are probably broken, and also the example-reverse needs some attention
2013-12-11 16:21:49 +01:00
Neel Goyal
1e9f716b6f
Check for answer on getdns_list_get methods
2013-12-10 18:27:28 -05:00
Neel Goyal
7db1610c95
Have add item default to adding an int of value 0
2013-12-09 14:11:17 -05:00
Neel Goyal
969ce94358
Merge branch 'develop' of github.com:verisign/getdns into develop
2013-12-09 12:55:42 -05:00
Neel Goyal
db23854041
Fix NPE (Issue #42 )
2013-12-09 12:55:33 -05:00
Willem Toorop
4c7a322d71
Merge branch 'develop' of github.com:verisign/getdns into develop
2013-12-09 16:26:48 +01:00
Willem Toorop
391fbdfbd1
getdns_list_set_* on list length mean append
2013-12-09 16:26:18 +01:00
W.C.A. Wijngaards
5bb291ddb6
Doxyfile had wrong version number inside.
2013-12-09 16:21:02 +01:00
W.C.A. Wijngaards
e80082aeaf
autoconf and autoheader recent configure.ac change
2013-12-09 09:11:31 +01:00
Willem Toorop
3dfe92da64
extended memory functions
2013-12-09 00:52:38 +01:00
Willem Toorop
c80cab6929
getdns_strdup, getdns_bindata_(copy|destroy)
...
Restructure a bit to make that work too
2013-12-09 00:05:18 +01:00
Willem Toorop
70e5193b3f
Context has own mem-funcs
...
It keeps using mem funcs for internal state that were given upon context creation.
Only dicts and lists are created with mem funcs set by getdns_context_set_memory_functions
2013-12-08 23:15:57 +01:00
Willem Toorop
8fe9da6503
Header functions, structs/unions and macro's
2013-12-08 22:56:34 +01:00
Willem Toorop
152bffb883
Two forgotten _TEXT quotes
2013-12-06 15:57:22 +01:00
Willem Toorop
3829dca0cc
Get rid of typedefs for structs
2013-12-06 15:54:06 +01:00
Willem Toorop
4b3578c88a
Fix stdbool replacement bug
...
introduced in 1ecf9d9ef8
2013-12-06 15:31:19 +01:00
Willem Toorop
f4b339f10d
Add GETDNS_RETURN_MEMORY_ERROR retcode
2013-12-06 14:51:01 +01:00
Willem Toorop
2e6978af13
Add EUI48 and EUI64 RR types
2013-12-06 14:49:50 +01:00
Willem Toorop
1ecf9d9ef8
Get rid of stdbool.h
2013-12-06 14:10:28 +01:00
Willem Toorop
ab25acbd6f
Quote _TEXT defines
2013-12-06 13:57:58 +01:00
W.C.A. Wijngaards
d5bbb6046b
This commit adds the configure script to the repo.
2013-12-03 16:29:44 +01:00
Willem Toorop
ab75b89da2
Remove/add missing prototypes
2013-12-03 16:09:26 +01:00
Willem Toorop
cb26dd1a45
API update to 0.357
...
To easy compare differences between the API header and our implementation:
Rename the names for types and arguments in the API
Rename the names for function arguments in our implementation
2013-12-03 14:36:06 +01:00
Willem Toorop
0da31aa21b
Remove private functions from getdns.h
...
And also reorder a bit for easy comparison with the original.
2013-12-03 14:13:10 +01:00
W.C.A. Wijngaards
ccf1c1d1d4
OSX. Header more lenient, no linenr in test
...
The line number is not fixed, so __LINE__ does not stay the
same when compiled on different platforms.
2013-12-03 12:13:10 +01:00
W.C.A. Wijngaards
ad9ffb5200
Remove unused flags (libtool adds -fPIC and more)
2013-12-03 10:46:18 +01:00
Willem Toorop
65b420b520
Merge branch 'develop' of github.com:verisign/getdns into develop
2013-12-03 10:38:42 +01:00
Willem Toorop
9f5b22727d
tests_stub_async look up cmd_line specified name
2013-12-03 10:37:23 +01:00
W.C.A. Wijngaards
997fbec46f
Link with -levent if detected, fix examples.
2013-12-02 14:20:03 +01:00
W.C.A. Wijngaards
64c057b82d
Portable with event1.x, test succeeds on FreeBSD
2013-11-30 13:53:57 +01:00
W.C.A. Wijngaards
0761834cf5
Fix shell portability, test succeeds on NetBSD.
2013-11-30 12:32:17 +01:00
W.C.A. Wijngaards
f217ab674e
Compile and test succeeds on OpenBSD
2013-11-30 11:25:50 +01:00
W.C.A. Wijngaards
48b54c3579
compile tests when needed.
2013-11-29 18:07:43 +01:00
W.C.A. Wijngaards
b392679ce4
make test and a testscript and output comparisons.
2013-11-29 16:24:39 +01:00
W.C.A. Wijngaards
69c6d0694b
fix issue #38 : install, uninstall, libtool, configureoutsidesrcdir,
...
the dist compiles. library version set to 0:0:0.
2013-11-29 15:41:06 +01:00
W.C.A. Wijngaards
d9afcf760b
Fixed build target for library slightly nicer.
2013-11-26 17:02:12 +01:00
Melinda Shore
4065396935
Added getdns_convert_ulabel_to_alabel and getdns_convert_alabel_to_ulabel; introduced dependency on libidn11
2013-11-25 17:40:38 -08:00
Melinda Shore
3e0411f8f8
brought doc directory into build process ("make doc")
2013-11-21 17:39:03 -08:00
Melinda Shore
3d108bb105
Improved error message text
2013-11-17 17:36:39 -08:00
Willem Toorop
373e0e4952
Custom mem funcs per dict/list
2013-11-12 17:00:19 +01:00
Willem Toorop
7158291e05
Custom memory management functions in context
2013-11-11 23:10:22 +01:00
Willem Toorop
8e7582232a
Rename use_udp_tcp leftovers in dns_transport
2013-11-08 18:42:14 -08:00
Willem Toorop
0b6d610ea5
Get rid of response_length in synchroneous funcs
2013-11-08 18:39:06 -08:00
Willem Toorop
3827db1ad4
Yay! Segfault resolved. + another little mem leak
...
So the segfault was on destroying the req->extensions dict.
This dict should have been initialized by dns_req_new, when it copied the extensions dict that it had as an argument.
Though, the argument could have been NULL in which case nothing is copied.
To overcome, I've altered dnsget_dict_copy to initialize the target with NULL when the src was NULL.
2013-11-08 15:13:49 -08:00
Neel Goyal
74fcc3c81b
Updating coding style for context.c/h
2013-11-06 13:32:05 -05:00
Neel Goyal
f8380ff862
Ran indent with the indent.pro committed
2013-11-05 15:03:44 -05:00
Neel Goyal
eb14f1212d
Merge branch 'develop' of github.com:verisign/getdns into develop
2013-11-05 13:31:44 -05:00
Neel Goyal
4fb66d8ea7
Handle immediate callback.
2013-11-05 13:31:29 -05:00
Willem Toorop
89a7bdcae6
Fix validate_extensions
2013-11-04 23:26:59 -08:00
Glen Wiley
78cb5480d2
Merge branch 'develop' of https://github.com/verisign/getdns into develop
...
Conflicts:
src/sync.c
2013-11-04 18:45:00 -05:00
Glen Wiley
969ae95f09
added extension validation to the primary entry point to catch bogus
...
extension strings and perform simple type checking on extensions
brief start on man pages, moving MIT license in source code files to BSD
2013-11-04 18:37:54 -05:00
Neel Goyal
266cdb0063
Cleanup some memory issues in simple answers
2013-11-04 15:26:52 -05:00
Neel Goyal
31e7bf1a8a
Some guards and make example_all_functions at least run
2013-11-04 14:43:06 -05:00
Neel Goyal
6289e2cad9
Merge branch 'develop' of github.com:verisign/getdns into develop
2013-11-04 13:44:18 -05:00
Neel Goyal
bf57b1e5b9
Update test messages per efence
2013-11-04 13:44:09 -05:00
Willem Toorop
8206a9e145
Merge branch 'develop' of github.com:verisign/getdns into develop
...
Conflicts:
src/util-internal.c
2013-11-04 10:36:31 -08:00
Willem Toorop
30d1e11a14
Fix some easy to find memory leaks...
2013-11-04 10:34:14 -08:00
Willem Toorop
bd7740fefa
Let tests_stub_sync print reply dict pretty
2013-11-04 10:33:27 -08:00
Neel Goyal
3da70546ca
Fix synchronous example to destroy the extensions dict
2013-11-04 12:57:46 -05:00
Neel Goyal
2db5fdbe0c
Fix some memory leaks
2013-11-04 12:51:13 -05:00
Willem Toorop
2d1ad47f07
And another little typedef fix
2013-11-03 16:08:28 -08:00
Willem Toorop
abd82025f6
Remove typedef from list.h
2013-11-03 16:05:10 -08:00
Glen Wiley
e7cc8eb150
separated libunbound test in configure.ac to give better diag msg
2013-11-03 16:40:24 -05:00
Glen Wiley
e5c18aa3af
Merge branch 'develop' of https://github.com/verisign/getdns into develop
2013-11-03 08:47:57 -05:00
Glen Wiley
2e1fb7b8b8
updates to some docs based on our meeting of 2013-11-02
2013-11-03 08:47:19 -05:00
Willem Toorop
615878f5b8
Merge branch 'develop' into rbtree-dict
2013-11-02 04:10:10 -07:00
Willem Toorop
e0c28a6346
Pretty printing to ldns_buffer
...
This makes it much more readable
2013-11-01 18:07:03 +01:00
Melinda Shore
e3e2247f27
Use ldns_rdf_address_reverse
2013-10-31 12:08:23 -07:00
Willem Toorop
6adb49b8d5
Merge branch 'develop' into rbtree-dict
2013-10-31 10:26:42 +01:00
Willem Toorop
c1ba94c08a
Remove key attribute from getdns_dict_item
...
It is in the node attribute already
2013-10-30 23:33:29 +01:00
Willem Toorop
6843376521
Pretty print safe & complete... but ugly
...
And it needs a bit of documentational comments
2013-10-30 23:23:53 +01:00
Willem Toorop
26b178aba6
Merge branch 'develop' into rbtree-dict
2013-10-30 21:47:10 +01:00
Melinda Shore
d520d62da9
Added address-to-hostname lookup. Note: need a more robust address reverser
2013-10-30 13:16:51 -07:00
Melinda Shore
10a2ebc88b
Added address-to-hostname lookup. Note: need a more robust address reverser
2013-10-30 13:16:20 -07:00
Willem Toorop
6bc33c50ab
Fix stack buffer overflow in _pretty_print_dict
2013-10-30 17:05:49 +01:00
Willem Toorop
6922343542
Merge branch 'remove-pthread' into rbtree-dict
2013-10-30 10:36:49 +01:00
Willem Toorop
3c1114cb7f
Merge branch 'remove-pthread' into develop
2013-10-30 10:34:35 +01:00
Melinda Shore
c377e6e2f0
fixed ordering issue with libgetdns link, added test and example back to make clean
2013-10-30 00:05:31 -07:00
Willem Toorop
8567e63267
Merge branch 'develop' into rbtree-dict
2013-10-30 00:32:51 +01:00
Willem Toorop
ffa9a72073
Make example_tree program comply to the API specs
...
It works with the rbtree-dict now (which implements copy correctly).
2013-10-30 00:31:14 +01:00
Willem Toorop
7111a0959f
A dict based on rbtree
2013-10-30 00:29:30 +01:00
Willem Toorop
e09ad9c519
Oopsy, test needs to know the lists blocksize
2013-10-29 22:10:35 +01:00
Willem Toorop
1336fe3b76
Get rid of pthread usage in getdns_general_sync
2013-10-29 21:25:04 +01:00
Willem Toorop
55d366f854
Hide dict and list internals from getdns.h
2013-10-29 21:02:21 +01:00
Willem Toorop
06ad9a53b5
Pass existing CFLAGS and LDFLAGS through
...
Useful when dependencies are installed at custom locations
2013-10-29 20:31:25 +01:00
Willem Toorop
37fe39e4ae
Make this example conform to API specs
...
Corrections should be reported back eventually...
2013-10-29 16:17:40 +01:00
Willem Toorop
fbff480a31
Correct order of calls for display IP address
2013-10-29 16:16:05 +01:00
Neel Goyal
e4f08150b1
Free extensions dict. Update gitignore
2013-10-22 16:28:28 -04:00
Melinda Shore
69cf72c1c4
Added linking test programs to libunbounc
2013-10-21 21:55:11 -07:00
Neel Goyal
65762811bf
Adding timeout support
2013-10-18 13:55:31 -04:00
Neel Goyal
840939aac8
Fix a bug in list copy for bindata. Fix some memory errors
2013-10-17 20:34:18 -04:00
Neel Goyal
9c75239aaa
Adding cancel and reply formatting
2013-10-17 19:45:25 -04:00
Neel Goyal
da8dad5913
Adding A and AAAA handling for get_address
2013-10-16 18:33:12 -04:00
Neel Goyal
c53c00ee2b
Add recursive and stub support
2013-10-16 14:45:43 -04:00
Neel Goyal
d608d3b670
Initial integration of unbound.
2013-10-15 17:28:23 -04:00
Melinda Shore
1d47471f26
Rudimentary autoconf support for Doxyfile
2013-10-10 16:15:17 -07:00
Melinda Shore
2b96fe8ca3
More doxygen markup cleanup
2013-10-10 13:35:29 -07:00
Melinda Shore
e7bb441c8e
Fixed a minor doxygen markup problem
2013-10-10 11:53:59 -07:00
Melinda Shore
6cd8051692
Update for doxygen
2013-10-09 16:52:31 -07:00
Melinda Shore
d440feb7a1
no longer using automake
2013-10-07 08:10:06 -07:00
Melinda Shore
75cdad16ec
No longer using automake
2013-10-07 08:07:37 -07:00
Melinda Shore
655343e6dc
files added for getdns_get_errorstr_by_id()
2013-09-22 11:31:35 -08:00
Melinda Shore
61ca5e4b52
added getdns_error.[ch]
2013-09-22 11:30:16 -08:00
Neel Goyal
1be26c3c76
Update examples to compile.
2013-09-03 12:12:12 -04:00
Melinda Shore
499c3eac98
Removed event.h conditionalization
2013-08-28 17:31:39 -08:00
Melinda Shore
98c953b6e4
Conditionalized in the correct event.h location for FreeBSD - probably merits further discussion
2013-08-28 17:09:11 -08:00
Neel Goyal
768b360ca9
Add support for sync functs
2013-08-16 16:28:21 -04:00
Neel Goyal
1b057ccfa3
Set the RD flag if in stub mode.
2013-08-16 15:24:06 -04:00
Neel Goyal
425a652542
Add stub async test program.
2013-08-16 15:11:46 -04:00
Neel Goyal
3ad70d686f
Add some utilities.
2013-08-16 14:48:03 -04:00
Neel Goyal
075990d330
Use strncmp and add some utils
2013-08-15 18:16:50 -04:00
Neel Goyal
ff83b43081
Get the async getaddress going
2013-08-15 17:51:26 -04:00
Neel Goyal
0c5d8b2c32
Tweak method sigs
2013-08-15 12:42:35 -04:00
Neel Goyal
6c1dc93edf
Adding some util modules
2013-08-15 12:33:05 -04:00
Neel Goyal
ed6fa12d01
Remove unused scripts
2013-08-15 11:44:05 -04:00
Neel Goyal
ddf9d3d548
Fix build system from code reorg
2013-08-15 10:54:30 -04:00
Neel Goyal
dba0da5adb
Massive restructure and renaming
2013-08-15 10:16:15 -04:00
Neel Goyal
67a07019ba
Remove Makefile.in files. Update gitignore
2013-08-14 17:40:05 -04:00
Neel Goyal
ad20c23f42
More progress on async
2013-08-14 17:19:06 -04:00
Neel Goyal
bf92cb6bb4
Some updates. Need to think about how to not rewrite what ldns and libevent have already done
2013-08-13 16:10:21 -04:00
Neel Goyal
7975c98c3f
Remove getdns_address.c. Update context to use copy.
2013-08-13 10:02:09 -04:00
Neel Goyal
cd1ff4a3b8
Context update
2013-08-13 09:08:54 -04:00
Neel Goyal
84ff383792
Adding ldns integration for context
2013-08-12 19:47:33 -04:00
Neel Goyal
a69c02abcc
Adding context struct and implement some setters
2013-08-12 17:38:05 -04:00
Melinda Shore
cf2cf498f6
added src/test to automake
2013-08-10 11:24:08 -08:00
Melinda Shore
00e2c74867
getting rid of Makefile.in - now generated by automake
2013-08-10 11:23:15 -08:00
Melinda Shore
16ae333802
automake-ified src/test
2013-08-10 11:17:47 -08:00
Melinda Shore
228a5d9868
Added <string.h> include for strdup() declaration (see POSIX.1)
2013-08-10 11:16:54 -08:00
Neel Goyal
b3e2aa19f3
Add Werror to cflags. Remove getdns lib check. Fail configure on dependencies not found.
2013-08-09 17:04:25 -04:00
Neel Goyal
8b60254fe4
Change header include from event to core_only where applicable
2013-08-09 11:34:42 -04:00
Neel Goyal
c2a03c5570
Removed symlink ltmain.sh. Add m4 for lt.
2013-08-09 10:48:22 -04:00
Melinda Shore
1854fc413c
Converted makefile generation to automake
2013-08-08 17:21:05 -08:00
Melinda Shore
6f9deafbb6
moved example code to src/example
2013-08-08 17:19:55 -08:00
Melinda Shore
c8d2005d49
Moved example code to src/example/
2013-08-08 17:17:20 -08:00
Melinda Shore
b5b5232d75
more cleanup
2013-08-08 17:16:09 -08:00
Melinda Shore
0a5f1d3c52
Now using automake to generate Makefile.in
2013-08-08 17:14:43 -08:00
Glen Wiley
6280a1b7b6
the dict and list data types with helper functions work, unit tests
...
are mostly done as well
2013-07-31 16:21:42 -04:00
Glen Wiley
68ae437210
Merge branch 'develop' of https://github.com/verisign/getdns into develop
...
Conflicts:
src/common/Makefile
2013-07-30 17:43:39 -04:00
Glen Wiley
91990993ce
the guts of the dict datatype are working, still need to complete the helper funcs
2013-07-30 17:36:14 -04:00
Melinda Shore
a973779190
More cleanup
2013-07-30 12:46:58 -08:00
Melinda Shore
7494d2b7d5
Moving things around to run configure at top level of directory tree
2013-07-30 11:55:09 -08:00
Melinda Shore
ead261b0b8
Moving things around to run configure at top level of directory tree
2013-07-30 11:50:31 -08:00
Melinda Shore
be749929a9
removed redundant configure.ac
2013-07-30 11:10:23 -08:00
Melinda Shore
6a1e56584a
We should not have Makefiles in the repository
2013-07-28 17:32:07 -08:00
Melinda Shore
67071f3adc
removed src/.deps
2013-07-28 17:29:57 -08:00
Melinda Shore
4937746fe8
deleted: src/common/Makefile.in~ - backup file
2013-07-22 14:58:42 -08:00
Melinda Shore
21875877a6
Removed Makefile, as it's automatically generated from Makefile.in
...
by the configure script
2013-07-22 14:57:27 -08:00
Melinda Shore
e1f6baf37a
modified: src/common/Makefile.in
...
fixed automatic variable incompatibility with
FreeBSD make
2013-07-22 12:53:41 -08:00
Glen Wiley
1ec3886604
Finished implementing list data type (except for dict items) - including
...
a reasonable set of automated unit/regression tests
2013-07-22 15:16:40 -04:00
Glen Wiley
0a6dfa46ae
list data type partially implemented, unit test framework started
2013-07-19 16:19:22 -04:00
Glen Wiley
19e84c8ec4
removed core_only source since all funcs are separated now
2013-07-15 18:46:42 -04:00
Glen Wiley
a3e1c8d255
separated the remaining functions
2013-07-15 18:43:30 -04:00
Glen Wiley
18d58a5892
using suffixes in Makefile, moved changed files from src to common (merged)
2013-07-15 18:20:25 -04:00
Glen Wiley
dc8f06fd92
Merge branch 'develop'
2013-07-15 17:48:20 -04:00
Glen Wiley
38b6909cdd
separated context mangement functions from core source code
2013-07-15 17:42:37 -04:00
Glen Wiley
267200b294
continuing work on comments and code separation
2013-07-02 17:00:20 -04:00
MelindaShore
213772f559
Added generated configure script
2013-07-01 08:28:12 -08:00
Melinda Shore
7b14eda301
Merge
2013-07-01 08:25:07 -08:00
Melinda Shore
c9e2a923ac
See detailed changes below. Basically, moved src/src to
...
src/commit and moved top level configure/build to src.
Added support for building into a different directory
(for example, mkdir build ; cd build ; ../configure ;
make ).
modified: README.md
renamed: src/src/AUTHORS -> src/AUTHORS
renamed: src/src/COPYING -> src/COPYING
renamed: src/src/INSTALL -> src/INSTALL
new file: src/Makefile
renamed: src/src/NEWS -> src/NEWS
renamed: src/src/README -> src/README
renamed: src/src/.DS_Store -> src/common/.DS_Store
renamed: src/src/.deps/example_all_functions.Po -> src/common/.deps/example_all_functions.Po
renamed: src/src/.deps/example_simple_answers.Po -> src/common/.deps/example_simple_answers.Po
renamed: src/src/.deps/example_synchronous.Po -> src/common/.deps/example_synchronous.Po
renamed: src/src/.deps/example_tree.Po -> src/common/.deps/example_tree.Po
renamed: src/src/ChangeLog -> src/common/ChangeLog
new file: src/common/Makefile
new file: src/common/Makefile.in
renamed: src/src/Makefile.in -> src/common/Makefile.in~
renamed: src/src/aclocal.m4 -> src/common/aclocal.m4
renamed: src/src/config.h.in -> src/common/config.h.in
new file: src/common/config.log
renamed: src/src/configure.ac -> src/common/configure.ac
renamed: src/src/depcomp -> src/common/depcomp
renamed: src/src/example-all-functions.c -> src/common/example-all-functions.c
renamed: src/src/example-simple-answers.c -> src/common/example-simple-answers.c
renamed: src/src/example-synchronous.c -> src/common/example-synchronous.c
renamed: src/src/example-tree.c -> src/common/example-tree.c
renamed: src/src/getdns_core_only.c -> src/common/getdns_core_only.c
renamed: src/src/getdns_core_only.h -> src/common/getdns_core_only.h
renamed: src/src/getdns_libevent.h -> src/common/getdns_libevent.h
renamed: src/src/index.html -> src/common/index.html
renamed: src/src/install-sh -> src/common/install-sh
renamed: src/src/make-examples-linux.sh -> src/common/make-examples-linux.sh
renamed: src/src/make-examples-mac.sh -> src/common/make-examples-mac.sh
new file: src/configure.ac
2013-06-30 19:36:46 -08:00
Glen Wiley
23a8f92d22
Added Doxygen config and started formatting comments in sources
2013-06-29 12:57:57 -04:00
Glen Wiley
a659f2562e
began tweaking sources to match BSD coding style
2013-06-28 11:09:10 -04:00
Glen Wiley
3f33ae19b4
minor updates to README, added DNS API description to doc dir
2013-06-28 08:44:23 -04:00
Melinda Shore
15932f2774
updated README.md to reflect changes in dependencies, add institutional affiliation
2013-06-27 13:11:00 -08:00
Melinda Shore
16a2175d4c
Added ldns support
2013-06-24 12:17:24 -08:00
Melinda Shore
096d4e5b77
Fixed a couple of null pointer problems
...
There were two null pointers causing it to dump core. I realize the
code doesn't actually do anything, but still.
2013-06-16 18:00:54 -08:00
Melinda Shore
b3ed4429d6
Initial checkin
...
Rough autoconf-ification of Paul's source. No changes to his code
2013-06-16 17:50:14 -08:00