interesting
/
getdns
mirror of https://github.com/getdnsapi/getdns.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,201 Commits 58 Branches 69 Tags 14 MiB
Commit Graph

26 Commits

Author SHA1 Message Date
Eli Lindsey 2673a5736c register only a single poll_t with libuv 
Most of the time we only need a read _or_ a write callback registered
with libuv - for example, on a UDP request a write callback is
registered, when executed the write callback performs the write,
deregisters itself, and registers a read callback.

However there is one case where getdns registers both read and write
callbacks: when a backlog of TCP requests is going to the same upstream
resolver, we use a single fd and queue the requests. In this instance we
want to listen for both read (to get responses for requests we've
already sent) and write (to continue to send our pending requests).

libuv, like most event libraries, only allows one callback to be
registered per fd. To get notification for both reads and writes, you
should examine the event flags and have appropriate conditional logic
within the single callback. Today getdns incorrectly tries to register
two separate poll_t with libuv, one for read and one for write - this
results in a crash (internal libuv assertion guaranteeing that only a
single poll_t is registered per fd).

Testing was done by using flamethrower
(https://github.com/DNS-OARC/flamethrower) to toss queries at a program
that embeds getdns.

Note that a higher qps trigger a _different_ getdns/libuv crashing bug
that occurs when the TCP backlog grows so large that requests start to
time out. That crash is not addressed in this PR, and will be more
involved to fix.
 2020-06-18 17:31:34 -04:00
Willem Toorop aa74c0a3d5 One more pleasing travis fix 2017-09-14 16:43:10 +02:00
Willem Toorop 473da8966b Library fixed for CFLAGS=-Wextra 2016-12-08 14:05:58 +01:00
Willem Toorop c8a9da69ea Fix libuv.c dependencies 2015-12-18 13:50:17 +01:00
Willem Toorop 5663f914fb Mode debug marco's to own header 
To reduce dependency location fixes in test directory.
 2015-12-18 13:40:52 +01:00
Willem Toorop 4cc4629bdf Don't expose scheduling side of extensions 
Also moved debugging macro's from types-internal.h ro util-internal.h
 2014-11-07 11:38:02 +01:00
Willem Toorop 114e459a43 Make things work on FreeBSD again 2014-10-31 14:17:30 +01:00
Willem Toorop 893605041d libuv extension now working too! 2014-10-15 10:47:36 +02:00
Willem Toorop a1be0c985d Miscelaneous fixes that came out of the unit tests 
TODO: libuv still has issues.  Do we really need a close callback?
 2014-10-15 01:13:39 +02:00
Willem Toorop f61d2ae262 write and run methods for eventloop extension 2014-10-10 14:48:52 +02:00
Willem Toorop 2172a7280a libuv according to new scheme 2014-10-10 11:14:01 +02:00
Willem Toorop 58b3e553de Remove redundant param from schedule_timeout funcs 2014-10-06 20:23:50 +02:00
Willem Toorop 648153f98c Timeouts are 64 bits 2014-10-06 16:10:09 +02:00
Willem Toorop 57b51a5dcc prefer includes local to builddir 2014-05-19 15:50:34 +02:00
Neel Goyal 3f8e8ac098 Possible fix for #21 and tests 2014-03-05 22:13:37 -05:00
Saúl Ibarra Corretgé 785ebf4ed6 Handle possible allocation failure 2014-03-05 14:27:15 +01:00
Saúl Ibarra Corretgé edd2c81bc5 Remove uneeded check 
libuv will always pass the handle to the close callback
 2014-03-05 14:27:15 +01:00
Saúl Ibarra Corretgé d51840efd7 Removed uv_data->polling field 
It's not necessary as uv_is_active can be used to check if a handle
is started or not.
 2014-03-05 14:27:15 +01:00
Neel Goyal 108f72bc36 Fix for issue #18 - allow destroy in callback 2014-03-04 17:00:18 -05:00
Willem Toorop d2c890ab6a Fill in <organization> place holder. 
s/the name of the <organization>/the names of the copyright holders/g
 2014-02-25 14:23:19 +01:00
Willem Toorop 8d77505219 s/Versign/Verisign/g in all files 2014-02-25 14:12:33 +01:00
Neel Goyal deade2b8bb Update extensions to add/remove persistent event based on request count 2014-02-21 18:42:04 -05:00
Neel Goyal 80703de636 Begin refactor out extensions into libs. 2014-02-21 12:23:20 -05:00
Neel Goyal d8f8eeca52 Fix signature on clear timeout for extensions 2014-02-06 00:10:35 -05:00
Neel Goyal 48aacf6c96 Fix include in libuv.c 2014-02-05 21:46:21 -05:00
Neel Goyal 562e2dd6df Add libuv support. Change event loop handling in tests 2014-02-05 00:01:55 -05:00