Commit Graph

2765 Commits

Author SHA1 Message Date
Willem Toorop 2a39b6e2e8 Handle the uninitialized memory error the brutal way
Because clang (or valgrind with clang) is just wrong here
2017-11-28 16:51:28 +01:00
Willem Toorop 72eb8628d0 Report on single unit tests too 2017-11-28 16:44:08 +01:00
Willem Toorop 543435d89d Clang bitfield issue 2017-11-28 16:40:17 +01:00
Willem Toorop 025f1cdff3 set_from_os last to initialize ...
... because it is initialized with values from context itself!
I.e. context->tls_backoff_time, context->tls_connection_retries and context->log are used to initialize upstreams in upstreams_create() called from set_from_os
2017-11-28 16:04:23 +01:00
Willem Toorop 30e440d35c Access of freed memory in stub DNSSEC cleanup code
Should fix the latest core dump reported in getdnsapi/stubby#34
2017-11-27 15:26:45 +01:00
Willem Toorop 323239be58 Scan valgrind logs for errors too 2017-11-27 15:02:32 +01:00
Willem Toorop 27847b9a0a Initialize context->sys_ctxt! 2017-11-23 13:23:00 +01:00
Willem Toorop 6afb02b2f1 Bugfix #359: edns_client_subnet_private should set family
Thanks Daniel Areiza
2017-11-23 13:20:42 +01:00
Willem Toorop c3cdf496e3 Meta queries to upstreams from resolvconf setting 2017-11-23 12:48:48 +01:00
Willem Toorop c0a3babe0a Separate sys_ctxt for meta queries 2017-11-23 12:44:40 +01:00
Willem Toorop 3e16075563 Test getdns_context_create2 with getdns_query 2017-11-23 12:26:40 +01:00
Willem Toorop ed6c7a6b58 getdns_context_create2 and family that set an ...
... alternative resolvconf file
2017-11-22 15:49:30 +01:00
Willem Toorop a7a6240202 Set default resolvconf and hosts during configure 2017-11-22 15:01:38 +01:00
Willem Toorop 3a1cb30c28 BOGUS answer because unable to fetch root DNSKEY...
... should not cause segfault
2017-11-21 15:38:49 +01:00
Willem Toorop 3098ed6fca Merge branch 'develop' 2017-11-11 10:24:55 +08:00
Willem Toorop 8821c1c8cf Merge branch 'release/1.2.1' into develop 2017-11-11 10:24:25 +08:00
Willem Toorop f2f08514ce Set date in ChangeLog 2017-11-11 00:42:25 +08:00
Willem Toorop bf034eb3cd Bump version 2017-11-11 00:28:17 +08:00
Willem Toorop 6aa732b54d Update Stubby 2017-11-11 00:26:18 +08:00
Willem Toorop 260416a859 Ignore SIGPIPE signal (for not suddenly stopping) 2017-11-10 10:42:17 +01:00
Willem Toorop 6f20016889 default_trust_anchor_location in api_information
instead of trust_anchor_file
2017-11-10 10:35:41 +01:00
wtoorop 81bfa68440
Merge pull request #355 from saradickinson/bugfix/create_runstatedir
Add DESTDIR to runstatedir creation path
2017-11-08 12:48:50 +01:00
Sara Dickinson 26eb5b8969 Add DESTDIR to runstatedir creation path 2017-11-08 11:38:52 +00:00
Willem Toorop 5fe979c2e6 Update ChangeLog and configure.ac 2017-11-03 20:26:45 +01:00
Willem Toorop f6517fd3e2 Update Stubby to v0.1.5 2017-11-03 20:12:28 +01:00
wtoorop 168d83ac19
Merge pull request #353 from getdnsapi/devel/errno_handling
Handle more harmless I/O error cases +
2017-11-03 20:00:40 +01:00
Willem Toorop 439f41149b Last rename + explicit EMFILE check replacement 2017-11-03 16:42:38 +01:00
Willem Toorop 9b019b8c6e Check errno is not 0 before testing errors 2017-11-03 16:29:43 +01:00
Willem Toorop 4508ec77fb Few more renames 2017-11-03 16:26:19 +01:00
Willem Toorop 3b7b83e309 Review comments from Jim 2017-11-03 15:41:31 +01:00
Willem Toorop a8fac29a66 Handle more harmless I/O error cases +
- never exit on I/O errors
- never stop listening on I/O errors
- extended platfrom.[ch] with _getdns_strerror()
2017-11-03 13:50:13 +01:00
wtoorop b683cc4870
Merge pull request #352 from saradickinson/bugfix/make_runstatedir
Make sure the runstatedir exists
2017-11-03 13:42:52 +01:00
wtoorop e078f3c51a
Merge pull request #351 from getdnsapi/devel/dnssec_maintenance
Devel/dnssec maintenance
2017-11-03 11:11:23 +01:00
Sara Dickinson 4b8ea64140 Make sure the runstatedir exists 2017-11-02 16:55:25 +00:00
wtoorop c3b86ccc21
Merge pull request #350 from banburybill/features/piddir
Add configure --with-piddir. Use this for runstatedir.
2017-11-02 15:24:44 +01:00
Willem Toorop 546fc1d404 Update ChangeLog 2017-11-02 15:14:07 +01:00
Willem Toorop 843ba4b036 Merge branch 'develop' into devel/dnssec_maintenance 2017-11-02 15:07:16 +01:00
Willem Toorop 5dbfdd4ddb Update ChangeLog 2017-11-02 15:06:56 +01:00
Jim Hague 2d0d1c9e6f Add configure --with-piddir. Use this for runstatedir.
You need autoconf 2.70 (or 2.69 plus patch as in Debian) for runstatedir to be automatically in the configure script. This adds a always-present config option.
2017-11-02 13:21:50 +00:00
Willem Toorop 2434336ead Include all RRSIGs in validation chain
Because we don't know algorithm support of other validators.

But still canonicalize the RRset with the one used to validate just because we can.
2017-11-02 12:42:26 +01:00
Willem Toorop 7e103217c6 unsigned RRs in authority section with BIND
when +CD flag is used
2017-11-01 16:47:28 +01:00
Willem Toorop 270c3d654f Support DNSSEC validation without support records 2017-11-01 15:28:46 +01:00
Willem Toorop b4ae4b7121 Cannot fetch DNSKEY when in DNSKEY callback ...
for the same name in full recursion
2017-11-01 15:01:58 +01:00
Willem Toorop 4669956391 retry full recursion bogus answers only when...
dnssec validation was requested in the first place
2017-11-01 10:59:55 +01:00
Willem Toorop 09b4f6d57d One more _getdns_perror 2017-10-31 16:22:09 +01:00
Willem Toorop e2b26609d4 Stubby back to develop branch 2017-10-27 13:03:49 +02:00
Willem Toorop 725f5d486a Credit Remi Gacogne 2017-10-27 09:58:25 +02:00
wtoorop 24f7ae3ea6 Merge pull request #348 from rgacogne/stubby-libbsd-link
Fix a linking issue in stubby when libbsd is present
2017-10-27 09:57:48 +02:00
Remi Gacogne 8e12d86fc3
Fix a linking issue in stubby when libbsd is present
When libbsd is found on the system during the configure, the result
of `pkg-config --cflags libbsd-overlay` is added to `CFLAGS`:

`-DLIBBSD_OVERLAY -isystem /usr/include/bsd`

The result of `pkg-config --libs libbsd-overlay` is added to `LIBS`,
but not to `STUBBY_LIBS`, which is used when linking stubby.

Because of the new `CFLAGS`, the preprocessor replaces the call to
`getopt()` in stubby.c with a call to `bsd_getop()`:

```
 #ifdef LIBBSD_OVERLAY
 #undef getopt
 #define getopt(argc, argv, optstr) bsd_getopt(argc, argv, optstr)
 #endif
```

But since `-lbsd` has not been added to `STUBBY_LIBS`, the linking of
stubby fails with an unresolved symbol:

```
../libtool --tag=CC --mode=link gcc -o stubby stubby.lo convert_yaml_to_json.lo gbuffer.lo -lyaml  libgetdns.la
libtool: link: gcc -o .libs/stubby .libs/stubby.o .libs/convert_yaml_to_json.o .libs/gbuffer.o  -lyaml ./.libs/libgetdns.so
/usr/bin/ld: .libs/stubby.o: undefined reference to symbol 'bsd_getopt@@LIBBSD_0.0'
/usr/lib/libbsd.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
```

Simply adding the result of `pkg-config --libs libbsd-overlay` to
`STUBBY_LIBS` in addition to `LIBS` fixes the issue.
2017-10-22 17:36:45 +02:00
Sara Dickinson cb6af78944 Merge pull request #347 from saradickinson/update_stubby_commit
Update stubby to use the 0.1.4 release
2017-10-20 08:38:40 -07:00