Rename return_call_debugging to return_call_reporting. Update index.html with change of content.

ChangeLog

@@ -1,3 +1,7 @@
+* 
+  * Enable TCP Fast Open when possible. Add OSX support for TFO.
+  * Rename return_call_debugging to return_call_reporting
+
 * 2015-11-18: Version 0.5.1
   * Bugfix: growing upstreams arrow.
   * Bugfix: Segfault on timeout in specific conditions

doc/libgetdns.3.in

@@ -275,10 +275,10 @@ GETDNS_BAD_DNS_CNAME_RETURNED_FOR_OTHER_TYPE: query type for other than CNAME re
 Set to the DNS class number (other than Internet (IN) class desired in query.
 
 .HP 3
-"return_call_debugging" (int)
+"return_call_reporting" (int)
 
 Set to GETDNS_EXTENSION_TRUE to add the name
-.I call_debugging
+.I call_reporting
 (list) to the top level of the response object that includes a dict for each call made to the API.  TBD: more detail
 
 .LP

spec/index.html

@@ -668,7 +668,7 @@ getdns_dict_destroy(extensions);
 
 <li><code>specify_class</code></li>
 
-<li><code>return_call_debugging</code></li>
+<li><code>return_call_reporting</code></li>
 
 </ul>
 
@@ -865,9 +865,9 @@ contains the class number. Few applications will ever use this extension.</p>
 <h2>3.6 Extensions Relating to the API</h2>
 
 <p>An application might want to see debugging information for queries such as the length of time it
-takes for each query to return to the API. Use the <code>return_call_debugging</code> extension. The
+takes for each query to return to the API. Use the <code>return_call_reporting</code> extension. The
 extension's value (an int) is set to <code>GETDNS_EXTENSION_TRUE</code> to add the name
-<code>call_debugging</code> (a list) to the top level of the response object. Each member of the
+<code>call_reporting</code> (a list) to the top level of the response object. Each member of the
 list is a dict that represents one call made for the call to the API. Each member has the following
 names:</p>
 
@@ -875,10 +875,10 @@ names:</p>
 <li><code>query_name</code> (a bindata) is the name that was sent</li>
 <li><code>query_type</code> (an int) is the type that was queried for</li>
 <li><code>query_to</code> (a bindata) is the address to which the query was sent</li>
-<li><code>start_time</code> (a bindata) is the time the query started in milliseconds since the epoch,
+<li><code>run_time</code> (a bindata) is the difference between the time the successful
-represented as a uint64_t</li>
+query started and ended in milliseconds, represented
-<li><code>end_time</code> (a bindata) is the time the query was received in milliseconds since the epoch,
+as a uint32_t (this does not include time taken for connection set up
-represented as a uint64_t</li>
+or transport fallback)</li>
 <li><code>entire_reply</code> (a bindata) is the entire response received</li>
 <li><code>dnssec_result</code> (an int) is the DNSSEC status, or <code>GETDNS_DNSSEC_NOT_PERFORMED</code>
 if DNSSEC validation was not performed</li>

src/request-internal.c

@@ -132,7 +132,7 @@ network_req_init(getdns_network_req *net_req, getdns_dns_req *owner,
 	net_req->response_len = 0;
         net_req->base_query_option_sz = opt_options_size;
 
-	/* Some fields to record info for return_call_debugging */
+	/* Some fields to record info for return_call_reporting */
 	net_req->debug_start_time = 0;
 	net_req->debug_end_time = 0;
 	net_req->debug_tls_auth_status = 0;
@@ -488,8 +488,8 @@ _getdns_dns_req_new(getdns_context *context, getdns_eventloop *loop,
 #endif
 	result->edns_client_subnet_private     = context->edns_client_subnet_private;
 	result->tls_query_padding_blocksize    = context->tls_query_padding_blocksize;
-	result->return_call_debugging
+	result->return_call_reporting
-		= is_extension_set(extensions, "return_call_debugging");
+		= is_extension_set(extensions, "return_call_reporting");
 	
 	/* will be set by caller */
 	result->user_pointer = NULL;

src/types-internal.h

@@ -226,7 +226,7 @@ typedef struct getdns_network_req
 	/* Network requests scheduled to write after me */
 	struct getdns_network_req *write_queue_tail;
 
-	/* Some fields to record info for return_call_debugging */
+	/* Some fields to record info for return_call_reporting */
 	uint64_t                    debug_start_time;
 	uint64_t                    debug_end_time;
 	size_t                      debug_tls_auth_status;
@@ -289,7 +289,7 @@ typedef struct getdns_dns_req {
 	int edns_cookies;
 	int edns_client_subnet_private;
 	uint16_t tls_query_padding_blocksize;
-	int return_call_debugging;
+	int return_call_reporting;
 
 	/* Internally used by return_validation_chain */
 	int dnssec_ok_checking_disabled;

src/util-internal.c

@@ -72,7 +72,7 @@ static getdns_extension_format extformats[] = {
 #endif
 	{"return_api_information", t_int},
 	{"return_both_v4_and_v6", t_int},
-	{"return_call_debugging", t_int},
+	{"return_call_reporting", t_int},
 	{"specify_class", t_int},
 };
 
@@ -676,7 +676,7 @@ success:
 }
 
 getdns_dict *
-_getdns_create_call_debugging_dict(
+_getdns_create_call_reporting_dict(
     getdns_context *context, getdns_network_req *netreq)
 {
 	getdns_bindata  qname;
@@ -751,7 +751,7 @@ _getdns_create_getdns_response(getdns_dns_req *completed_request)
 	getdns_list *just_addrs = NULL;
 	getdns_list *replies_full;
 	getdns_list *replies_tree;
-	getdns_list *call_debugging = NULL;
+	getdns_list *call_reporting = NULL;
 	getdns_network_req *netreq, **netreq_p;
 	int rrsigs_in_answer = 0;
 	getdns_dict *reply;
@@ -792,8 +792,8 @@ _getdns_create_getdns_response(getdns_dns_req *completed_request)
 	if (!(replies_tree = getdns_list_create_with_context(context)))
 		goto error_free_replies_full;
 
-	if (completed_request->return_call_debugging &&
+	if (completed_request->return_call_reporting &&
-	    !(call_debugging = getdns_list_create_with_context(context)))
+	    !(call_reporting = getdns_list_create_with_context(context)))
 		goto error_free_replies_full;
 
 	for ( netreq_p = completed_request->netreqs
@@ -853,13 +853,13 @@ _getdns_create_getdns_response(getdns_dns_req *completed_request)
 			goto error;
 		}
 		
-		if (call_debugging) {
+		if (call_reporting) {
 			if (!(netreq_debug =
-			   _getdns_create_call_debugging_dict(context,netreq)))
+			   _getdns_create_call_reporting_dict(context,netreq)))
 				goto error;
 
 			if (_getdns_list_append_dict(
-			    call_debugging, netreq_debug)) {
+			    call_reporting, netreq_debug)) {
 
 				getdns_dict_destroy(netreq_debug);
 				goto error;
@@ -879,9 +879,9 @@ _getdns_create_getdns_response(getdns_dns_req *completed_request)
 		goto error;
 	getdns_list_destroy(replies_tree);
 
-	if (call_debugging &&
+	if (call_reporting &&
-	    getdns_dict_set_list(result, "call_debugging", call_debugging))
+	    getdns_dict_set_list(result, "call_reporting", call_reporting))
-	    goto error_free_call_debugging;
+	    goto error_free_call_reporting;
 
 	if (getdns_dict_set_list(result, "replies_full", replies_full))
 		goto error_free_replies_full;
@@ -906,8 +906,8 @@ _getdns_create_getdns_response(getdns_dns_req *completed_request)
 error:
 	/* cleanup */
 	getdns_list_destroy(replies_tree);
-error_free_call_debugging:
+error_free_call_reporting:
-	getdns_list_destroy(call_debugging);
+	getdns_list_destroy(call_reporting);
 error_free_replies_full:
 	getdns_list_destroy(replies_full);
 error_free_result: