interesting
/
getdns
mirror of https://github.com/getdnsapi/getdns.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Dead assignment

This commit is contained in:
Willem Toorop 2017-10-19 14:14:37 +02:00
parent f8e1ed78b8
commit fc073267f1
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/stub.c
View File

@ -524,9 +524,8 @@ upstream_failed(getdns_upstream *upstream, int during_setup)
when idle.*/ when idle.*/
/* [TLS1]TODO: Work out how to re-open the connection and re-try /* [TLS1]TODO: Work out how to re-open the connection and re-try
the queries if there is only one upstream.*/ the queries if there is only one upstream.*/
GETDNS_CLEAR_EVENT(upstream->loop, &upstream->event);
if (during_setup) { if (during_setup) {
/* Reset timeout on setup failure to trigger fallback handling.*/
GETDNS_CLEAR_EVENT(upstream->loop, &upstream->event);
/* Special case if failure was due to authentication issues since this /* Special case if failure was due to authentication issues since this
upstream could be used oppotunistically with no problem.*/ upstream could be used oppotunistically with no problem.*/
if (!(upstream->transport == GETDNS_TRANSPORT_TLS && if (!(upstream->transport == GETDNS_TRANSPORT_TLS &&
@ -538,12 +537,9 @@ upstream_failed(getdns_upstream *upstream, int during_setup)
} }
upstream->conn_state = GETDNS_CONN_TEARDOWN; upstream->conn_state = GETDNS_CONN_TEARDOWN;
if (upstream->write_queue) { while (upstream->write_queue)
if (!during_setup) upstream_write_cb(upstream);
during_setup = -1;
while (upstream->write_queue)
upstream_write_cb(upstream);
}
while (upstream->netreq_by_query_id.count) { while (upstream->netreq_by_query_id.count) {
netreq = (getdns_network_req *) netreq = (getdns_network_req *)
_getdns_rbtree_first(&upstream->netreq_by_query_id); _getdns_rbtree_first(&upstream->netreq_by_query_id);