interesting
/
getdns
mirror of https://github.com/getdnsapi/getdns.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use mkstemp instead of tmpnam to eliminate warning

This commit is contained in:
Willem Toorop 2015-12-24 10:50:58 +01:00
parent 71b2a44945
commit 8bde787703
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/context.c
View File

@ -1582,8 +1582,9 @@ getdns_return_t
getdns_context_set_dns_root_servers( getdns_context_set_dns_root_servers(
getdns_context *context, getdns_list *addresses) getdns_context *context, getdns_list *addresses)
{ {
char tmpfn[L_tmpnam]; char tmpfn[FILENAME_MAX] = P_tmpdir "/getdns-root-dns-servers-XXXXXX";
FILE *fh; FILE *fh;
int fd;
size_t i; size_t i;
getdns_dict *rr_dict; getdns_dict *rr_dict;
getdns_return_t r; getdns_return_t r;
@ -1613,10 +1614,10 @@ getdns_context_set_dns_root_servers(
context, GETDNS_CONTEXT_CODE_DNS_ROOT_SERVERS); context, GETDNS_CONTEXT_CODE_DNS_ROOT_SERVERS);
return GETDNS_RETURN_GOOD; return GETDNS_RETURN_GOOD;
} }
if (!tmpnam(tmpfn)) if ((fd = mkstemp(tmpfn)) < 0)
return GETDNS_RETURN_CONTEXT_UPDATE_FAIL; return GETDNS_RETURN_CONTEXT_UPDATE_FAIL;
if (!(fh = fopen(tmpfn, "w"))) if (!(fh = fdopen(fd, "w")))
return GETDNS_RETURN_CONTEXT_UPDATE_FAIL; return GETDNS_RETURN_CONTEXT_UPDATE_FAIL;
for (i=0; (!(r = getdns_list_get_dict(addresses, i, &rr_dict))); i++) { for (i=0; (!(r = getdns_list_get_dict(addresses, i, &rr_dict))); i++) {
@ -1666,7 +1667,7 @@ getdns_context_set_dns_root_servers(
if (context->root_servers_fn[0]) if (context->root_servers_fn[0])
unlink(context->root_servers_fn); unlink(context->root_servers_fn);
(void) memcpy(context->root_servers_fn, tmpfn, L_tmpnam); (void) memcpy(context->root_servers_fn, tmpfn, strlen(tmpfn));
dispatch_updated(context, GETDNS_CONTEXT_CODE_DNS_ROOT_SERVERS); dispatch_updated(context, GETDNS_CONTEXT_CODE_DNS_ROOT_SERVERS);
return GETDNS_RETURN_GOOD; return GETDNS_RETURN_GOOD;

2
src/context.h
View File

@ -169,7 +169,7 @@ struct getdns_context {
uint64_t idle_timeout; uint64_t idle_timeout;
getdns_redirects_t follow_redirects; getdns_redirects_t follow_redirects;
getdns_list *dns_root_servers; getdns_list *dns_root_servers;
char root_servers_fn[L_tmpnam]; char root_servers_fn[FILENAME_MAX];
getdns_append_name_t append_name; getdns_append_name_t append_name;
struct getdns_list *suffix; struct getdns_list *suffix;
uint8_t *trust_anchors; uint8_t *trust_anchors;