interesting
/
getdns
mirror of https://github.com/getdnsapi/getdns.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

DS is always a delegation and never at the apex

This commit is contained in:
Willem Toorop 2018-06-10 16:57:40 +02:00
parent 25231aa686
commit 884f6ddc5e
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/dnssec.c
View File

@ -2720,13 +2720,18 @@ static int chain_head_validate_with_ta(struct mem_funcs *mf,
debug_sec_print_rrset("Validating ", &head->rrset); debug_sec_print_rrset("Validating ", &head->rrset);
debug_sec_print_rrset("\twith trust anchor ", ta); debug_sec_print_rrset("\twith trust anchor ", ta);
/* A DS is never at the apex */
if ( head->rrset.rr_type == GETDNS_RRTYPE_DS
&& head->parent->parent)
parent = head->parent->parent;
/* Only at the apex, a NSEC is signed with a DNSKEY with the same /* Only at the apex, a NSEC is signed with a DNSKEY with the same
* owner name. All other are signed by the parent domain or higher. * owner name. All other are signed by the parent domain or higher.
* Besides a shortcut, choosing to search for a trusted key from the * Besides a shortcut, choosing to search for a trusted key from the
* parent is essential for NSECs at a delagation point! (which would * parent is essential for NSECs at a delagation point! (which would
* otherwise turn out BOGUS). * otherwise turn out BOGUS).
*/ */
if ( head->rrset.rr_type == GETDNS_RRTYPE_NSEC else if (head->rrset.rr_type == GETDNS_RRTYPE_NSEC
&& head->parent->parent && head->parent->parent
&& (nsec_rr = _getdns_rrtype_iter_init(&nsec_spc, &head->rrset)) && (nsec_rr = _getdns_rrtype_iter_init(&nsec_spc, &head->rrset))
&& (bitmap = _getdns_rdf_iter_init_at( && (bitmap = _getdns_rdf_iter_init_at(
@ -2739,8 +2744,7 @@ static int chain_head_validate_with_ta(struct mem_funcs *mf,
* so a search for a trusted key at that name gives either INSECURE * so a search for a trusted key at that name gives either INSECURE
* (with opt-out) or BOGUS! ) * (with opt-out) or BOGUS! )
*/ */
else else if (head->rrset.rr_type == GETDNS_RRTYPE_NSEC3
if (head->rrset.rr_type == GETDNS_RRTYPE_NSEC3
&& head->parent->parent) && head->parent->parent)
parent = head->parent->parent; parent = head->parent->parent;
else else