Merge branch 'devel/tpkg-maintenance' into develop

src/server.c

@@ -255,7 +255,12 @@ _getdns_cancel_reply(getdns_context *context, connection *conn)
 {
 	struct mem_funcs *mf;
 
-	if (!context || !conn)
+	if (!conn)
+		return;
+
+	if (context && context->server &&
+	    _getdns_rbtree_search(&context->server->connections_set, conn)
+	    != &conn->super)
 		return;
 
 	if (conn->l->transport == GETDNS_TRANSPORT_TCP) {
@@ -293,13 +298,14 @@ getdns_reply(
 	size_t len;
 	getdns_return_t r;
 
-	if (!context || !conn)
+	if (!conn)
 		return GETDNS_RETURN_INVALID_PARAMETER;
 
-	if (!context->server)
-		return GETDNS_RETURN_GENERIC_ERROR;;
+	if (!context || !context->server) {
+		if (!context)
+			context = conn->l->set->context;
 
-	if (_getdns_rbtree_search(&context->server->connections_set, conn)
+	} else if (_getdns_rbtree_search(&context->server->connections_set, conn)
 	    != &conn->super)
 		return GETDNS_RETURN_NO_SUCH_LIST_ITEM;
 
@@ -750,11 +756,16 @@ static void free_listen_set_when_done(listen_set *set)
 	for (i = 0; i < set->count; i++) {
 		listener *l = &set->items[i];
 
-		if (l->fd >= 0)
+		if (l->fd >= 0) {
+			DEBUG_SERVER("Listener %d still listening on %d\n",
+			    (int)i, l->fd);
 			return;
-
-		if (l->connections)
+		}
+		if (l->connections) {
+			DEBUG_SERVER("Listener %d still has connections %p\n",
+			    (int)i, (void *)l->connections);
 			return;
+		}
 	}
 	GETDNS_FREE(*mf, set);
 	DEBUG_SERVER("Listen set: %p freed\n", (void *)set);

src/test/tpkg/100-compile.tpkg/100-compile.pre

@@ -25,4 +25,4 @@ done
 rm -fr "${BUILDDIR}/build"
 mkdir  "${BUILDDIR}/build"
 cd "${BUILDDIR}/build"
-"${SRCROOT}/configure" $* --prefix "${BUILDDIR}/install" --enable-debug-anchor
+"${SRCROOT}/configure" $* --prefix "${BUILDDIR}/install"

src/test/tpkg/100-compile.tpkg/100-compile.test

@@ -5,4 +5,4 @@
 [ -f .tpkg.var.test ] && source .tpkg.var.test
 
 cd "${BUILDDIR}/build"
-make XTRA_CFLAGS='-Werror' -j 4
+make XTRA_CFLAGS='-g -Werror' -j 4

src/test/tpkg/105-install.tpkg/105-install.test

@@ -5,4 +5,6 @@
 [ -f .tpkg.var.test ] && source .tpkg.var.test
 
 cd "${BUILDDIR}/build"
-make -j 4 install
+make -j 4 install \
+    && echo "export GETDNS_QUERY=\"${BUILDDIR}/build/src/tools/getdns_query\"" \
+       >> ../.tpkg.var.master

src/test/tpkg/110-link.tpkg/110-link.dsc

@@ -1,16 +0,0 @@
-BaseName: 110-link
-Version: 1.0
-Description: Link getdns_query program
-CreationDate: do dec 10 11:10:11 CET 2015
-Maintainer: Willem Toorop
-Category: 
-Component:
-CmdDepends: 
-Depends: 100-compile.tpkg
-Help:
-Pre: 
-Post: 
-Test: 110-link.test
-AuxFiles: 
-Passed:
-Failure:

src/test/tpkg/110-link.tpkg/110-link.test

@@ -1,10 +0,0 @@
-# #-- 110-link.test --#
-# source the master var file when it's there
-[ -f ../.tpkg.var.master ] && source ../.tpkg.var.master
-# use .tpkg.var.test for in test variable passing
-[ -f .tpkg.var.test ] && source .tpkg.var.test
-
-cd "${BUILDDIR}/build"
-make -j 4 getdns_query \
-    &&  echo "export GETDNS_QUERY=\"${BUILDDIR}/build/src/tools/getdns_query\"" \
-        >> ../.tpkg.var.master

src/test/tpkg/115-install-linked.tpkg/115-install-linked.dsc

@@ -1,16 +0,0 @@
-BaseName: 115-install-linked
-Version: 1.0
-Description: Install the getdns_query program
-CreationDate: vr dec 18 10:52:26 CET 2015
-Maintainer: Willem Toorop
-Category: 
-Component:
-CmdDepends: 
-Depends: 110-link.tpkg
-Help:
-Pre: 
-Post: 
-Test: 115-install-linked.test
-AuxFiles: 
-Passed:
-Failure:

src/test/tpkg/115-install-linked.tpkg/115-install-linked.test

@@ -1,8 +0,0 @@
-# #-- 115-install-linked.test --#
-# source the master var file when it's there
-[ -f ../.tpkg.var.master ] && source ../.tpkg.var.master
-# use .tpkg.var.test for in test variable passing
-[ -f .tpkg.var.test ] && source .tpkg.var.test
-
-cd "${BUILDDIR}/build"
-make -j 4 install-getdns_query

src/test/tpkg/120-run-getdns_query.tpkg/120-run-getdns_query.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: 
-Depends: 110-link.tpkg
+Depends: 105-install.tpkg
 Help:
 Pre: 
 Post: 

src/test/tpkg/125-valgrind-checks.tpkg/125-valgrind-checks.ds

@@ -1 +1,2 @@
 .	DS	19036 8 2 49aac11d7b6f6446702e54a1607371607a1a41855200fd2ce1cdde32f24e8fb5
+.	DS	20326 8 2 e06d44b80b8f1d39a95c0b0d7c65d08458e880409bbc683457104237c7f8ec8d

src/test/tpkg/125-valgrind-checks.tpkg/125-valgrind-checks.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: valgrind
-Depends: 110-link.tpkg
+Depends: 105-install.tpkg
 Help:
 Pre: 
 Post: 

src/test/tpkg/130-run-unit-tests.tpkg/130-run-unit-tests.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: 
-Depends: 110-link.tpkg
+Depends: 105-install.tpkg
 Help:
 Pre: 
 Post: 

src/test/tpkg/200-stub-only-compile-install.tpkg/200-stub-only-compile-install.dsc

@@ -1,4 +1,4 @@
-BaseName: 200-stub-only-compile
+BaseName: 200-stub-only-compile-install
 Version: 1.0
 Description: Create builddir and compile stub only
 CreationDate: do dec 10 11:08:24 CET 2015
@@ -8,9 +8,9 @@ Component:
 CmdDepends: 
 Depends: 
 Help:
-Pre: 200-stub-only-compile.pre
-Post: 200-stub-only-compile.post
-Test: 200-stub-only-compile.test
+Pre: 200-stub-only-compile-install.pre
+Post: 200-stub-only-compile-install.post
+Test: 200-stub-only-compile-install.test
 AuxFiles: 
 Passed:
 Failure:

src/test/tpkg/200-stub-only-compile-install.tpkg/200-stub-only-compile-install.pre

@@ -25,4 +25,4 @@ done
 rm -fr "${BUILDDIR}/build-stub-only"
 mkdir  "${BUILDDIR}/build-stub-only"
 cd "${BUILDDIR}/build-stub-only"
-"${SRCROOT}/configure" $* --prefix "${BUILDDIR}/install-stub-only" --enable-stub-only
+"${SRCROOT}/configure" $* --prefix "${BUILDDIR}/install-stub-only" --enable-stub-only --enable-debug-server --enable-debug-anchor

src/test/tpkg/200-stub-only-compile-install.tpkg/200-stub-only-compile-install.test

@@ -5,4 +5,6 @@
 [ -f .tpkg.var.test ] && source .tpkg.var.test
 
 cd "${BUILDDIR}/build-stub-only"
-make XTRA_CFLAGS='-Werror' -j 4
+make XTRA_CFLAGS='-g -Werror' -j 4 install \
+    && echo "export GETDNS_STUB_QUERY=\"${BUILDDIR}/build-stub-only/src/tools/getdns_query\"" \
+       >> ../.tpkg.var.master

src/test/tpkg/210-stub-only-link.tpkg/210-stub-only-link.dsc

@@ -1,16 +0,0 @@
-BaseName: 210-stub-only-link
-Version: 1.0
-Description: Link getdns_query program
-CreationDate: do dec 10 11:08:37 CET 2015
-Maintainer: Willem Toorop
-Category: 
-Component:
-CmdDepends: 
-Depends: 200-stub-only-compile.tpkg
-Help:
-Pre: 
-Post: 
-Test: 210-stub-only-link.test
-AuxFiles: 
-Passed:
-Failure:

src/test/tpkg/210-stub-only-link.tpkg/210-stub-only-link.test

@@ -1,10 +0,0 @@
-# #-- 210-stub-only-link.test --#
-# source the master var file when it's there
-[ -f ../.tpkg.var.master ] && source ../.tpkg.var.master
-# use .tpkg.var.test for in test variable passing
-[ -f .tpkg.var.test ] && source .tpkg.var.test
-
-cd "${BUILDDIR}/build-stub-only"
-make -j 4 getdns_query \
-    &&  echo "export GETDNS_STUB_QUERY=\"${BUILDDIR}/build-stub-only/src/tools/getdns_query\"" \
-        >> ../.tpkg.var.master

src/test/tpkg/220-stub-only-run-getdns_query.tpkg/220-stub-only-run-getdns_query.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: 
-Depends: 210-stub-only-link.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 
 Post: 

src/test/tpkg/225-stub-only-valgrind-checks.tpkg/225-stub-only-valgrind-checks.ds

@@ -1 +0,0 @@
-.	DS	19036 8 2 49aac11d7b6f6446702e54a1607371607a1a41855200fd2ce1cdde32f24e8fb5

src/test/tpkg/225-stub-only-valgrind-checks.tpkg/225-stub-only-valgrind-checks.dsc

@@ -1,12 +1,12 @@
 BaseName: 225-stub-only-valgrind-checks
 Version: 1.0
-Description: Run valgrind to detect memory leaks
+Description: Run getdns_query in valgrind + Zero configuration DNSSEC test
 CreationDate: ma mrt 21 16:24:56 CET 2016
 Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: valgrind
-Depends: 210-stub-only-link.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 
 Post: 

src/test/tpkg/230-stub-only-run-unit-tests.tpkg/230-stub-only-run-unit-tests.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: 
-Depends: 210-stub-only-link.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 
 Post: 

src/test/tpkg/250-json-pointers.tpkg/250-json-pointers.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: 
-Depends: 200-stub-only-compile.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 250-json-pointers.pre
 Post: 

src/test/tpkg/255-yaml-config.tpkg/255-yaml-config.dsc

@@ -6,7 +6,7 @@ Maintainer: Jim Hague
 Category: 
 Component:
 CmdDepends: 
-Depends: 200-stub-only-compile.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 255-yaml-config.pre
 Post: 

src/test/tpkg/260-conversion-functions.tpkg/260-conversion-functions.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: 
-Depends: 200-stub-only-compile.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help: 260-conversion-functions.help
 Pre: 260-conversion-functions.pre
 Post: 

src/test/tpkg/265-supported-rrs.tpkg/265-supported-rrs.dsc

@@ -6,7 +6,7 @@ Maintainer: Hoda Rohani
 Category: 
 Component:
 CmdDepends: 
-Depends: 200-stub-only-compile.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 265-supported-rrs.pre
 Post: 

src/test/tpkg/270-header-extension.tpkg/270-header-extension.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: 
 Component:
 CmdDepends: 
-Depends: 200-stub-only-compile.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 270-header-extension.pre
 Post: 

src/test/tpkg/275-server-capabilities.tpkg/275-server-capabilities.dsc

@@ -6,7 +6,7 @@ Maintainer: Hoda Rohani
 Category: 
 Component:
 CmdDepends: 
-Depends: 210-stub-only-link.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 275-server-capabilities.pre
 Post: 

src/test/tpkg/275-server-capabilities.tpkg/275-server-capabilities.test

@@ -21,10 +21,14 @@ make && "${BUILDDIR}/build-stub-only/libtool" exec valgrind -v --log-file=valgri
 
 	${GETDNS_STUB_QUERY} -s -q @${LOCALHOST}:$PORT TXT quit.
 )
-if grep -q 'definitely lost: [^0]' valgrind.log
+if ! awk '/^==.*(definitely|indirectly|possibly) lost/{print;if($4>0)exit(1)}' valgrind.log
+then
+	cat valgrind.log
+	exit 1
+fi
+if ! awk '/^==.* ERROR SUMMARY/{print;if($4>0)exit(1)}' valgrind.log
 then
 	cat valgrind.log
-	echo "error: Memory loss!"
 	exit 1
 fi
 if ! grep -q '"status": GETDNS_RESPSTATUS_ALL_TIMEOUT' time_out

src/test/tpkg/280-limit_outstanding_queries.tpkg/280-limit_outstanding_queries.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: Resource depletion
 Component:
 CmdDepends: 
-Depends: 210-stub-only-link.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 280-limit_outstanding_queries.pre
 Post: 

src/test/tpkg/280-limit_outstanding_queries.tpkg/280-limit_outstanding_queries.test

@@ -19,13 +19,13 @@ echo "# queries: $NQUERIES"
 # which is smaller than 5 seconds default query timeout value,
 # so the test should succeed.
 
-make && "./${TPKG_NAME}" ${LOCALHOST} | (
+make && "${BUILDDIR}/build-stub-only/libtool" exec valgrind -v --log-file=valgrind.log --leak-check=full --error-exitcode=1 --track-origins=yes "./${TPKG_NAME}" ${LOCALHOST} | (
 	read PORT
-	${GETDNS_STUB_QUERY} @${LOCALHOST}:$PORT TXT \
+	${GETDNS_STUB_QUERY} -s @${LOCALHOST}:$PORT TXT \
 	    -a -F "./${TPKG_NAME}.queries" \
 	          "{limit_outstanding_queries:$QLIMIT}" 2>&1 > out
 
-	${GETDNS_STUB_QUERY} -q @${LOCALHOST}:$PORT TXT quit.
+	${GETDNS_STUB_QUERY} -s -q @${LOCALHOST}:$PORT TXT quit.
 ) && grep '"n_requests: [0-9][0-9]*"' out | sed -e 's/^.*n_requests: //g' -e 's/".*$//g' \
     | awk -vQLIMIT=$QLIMIT -vNQUERIES=$NQUERIES '
 
@@ -43,4 +43,15 @@ END{
 		exit(-1);
 	} else
 		print "SUCCESS: No more than "QLIMIT" outstanding queries: "max_outstanding;
-}'
+}' && (
+	if ! awk '/^==.*(definitely|indirectly|possibly) lost/{print;if($4>0)exit(1)}' valgrind.log
+	then
+		cat valgrind.log
+		exit 1
+	fi
+	if ! awk '/^==.* ERROR SUMMARY/{print;if($4>0)exit(1)}' valgrind.log
+	then
+		cat valgrind.log
+		exit 1
+	fi
+)

src/test/tpkg/285-out_of_filedescriptors.tpkg/285-out_of_filedescriptors.dsc

@@ -6,7 +6,7 @@ Maintainer: Willem Toorop
 Category: Resource depletion
 Component:
 CmdDepends: 
-Depends: 210-stub-only-link.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 285-out_of_filedescriptors.pre
 Post: 

src/test/tpkg/285-out_of_filedescriptors.tpkg/285-out_of_filedescriptors.test

@@ -27,13 +27,13 @@ echo "# queries: $NQUERIES"
 # which is smaller than 5 seconds default query timeout value,
 # so the test should succeed.
 
-make && "./${TPKG_NAME}" ${LOCALHOST}| (
+make && "${BUILDDIR}/build-stub-only/libtool" exec valgrind -v --log-file=valgrind.log --leak-check=full --error-exitcode=1 --track-origins=yes "./${TPKG_NAME}" ${LOCALHOST}| (
 	read PORT
 	ulimit -n $QLIMIT
-	${GETDNS_STUB_QUERY} @${LOCALHOST}:$PORT TXT \
+	${GETDNS_STUB_QUERY} -s @${LOCALHOST}:$PORT TXT \
 	    -a -F "./${TPKG_NAME}.queries" 2>&1 > out
 
-	${GETDNS_STUB_QUERY} -q @${LOCALHOST}:$PORT TXT quit.
+	${GETDNS_STUB_QUERY} -s -q @${LOCALHOST}:$PORT TXT quit.
 ) && grep '"n_requests: [0-9][0-9]*"' out | sed -e 's/^.*n_requests: //g' -e 's/".*$//g' \
     | awk -vQLIMIT=$QLIMIT -vNQUERIES=$NQUERIES '
 
@@ -51,4 +51,15 @@ END{
 		exit(-1);
 	} else
 		print "SUCCESS: No more than "QLIMIT" outstanding queries: "max_outstanding;
-}'
+}' && (
+	if ! awk '/^==.*(definitely|indirectly|possibly) lost/{print;if($4>0)exit(1)}' valgrind.log
+	then
+		cat valgrind.log
+		exit 1
+	fi
+	if ! awk '/^==.* ERROR SUMMARY/{print;if($4>0)exit(1)}' valgrind.log
+	then
+		cat valgrind.log
+		exit 1
+	fi
+)

src/test/tpkg/290-transports.tpkg/290-transports.dsc

@@ -6,7 +6,7 @@ Maintainer: Hoda Rohani
 Category: 
 Component:
 CmdDepends: 
-Depends: 210-stub-only-link.tpkg
+Depends: 200-stub-only-compile-install.tpkg
 Help:
 Pre: 
 Post: 

src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.test

@@ -5,4 +5,4 @@
 [ -f .tpkg.var.test ] && source .tpkg.var.test
 
 cd "${BUILDDIR}/build-event-loops"
-make XTRA_CFLAGS=-Werror -j 4
+make XTRA_CFLAGS="-g -Werror" -j 4 install