From 770c0a1282c7e86e4c034d2f76d313539f320646 Mon Sep 17 00:00:00 2001 From: Willem Toorop Date: Wed, 12 Feb 2020 12:28:50 +0100 Subject: [PATCH] Fix unit tests (for changed world) - Google started to respond NOTIMP on unknown RR types! - willem.getdnsapi.net has been removed --- src/test/check_getdns_address_sync.h | 4 ++-- src/test/check_getdns_general.h | 8 ++++---- src/test/check_getdns_general_sync.h | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/test/check_getdns_address_sync.h b/src/test/check_getdns_address_sync.h index c5c4ae92..fd1e22ef 100644 --- a/src/test/check_getdns_address_sync.h +++ b/src/test/check_getdns_address_sync.h @@ -145,7 +145,7 @@ START_TEST (getdns_address_sync_6) { /* - * name = "willem.getdnsapi.net" need to replace this with domain from unbound zone + * name = "d2a8n3.rootcanary.net" need to replace this with domain from unbound zone * expect: NOERROR/NODATA response: * status = GETDNS_RESPSTATUS_NO_DATA * rcode = 0 @@ -156,7 +156,7 @@ CONTEXT_CREATE(TRUE); - ASSERT_RC(getdns_address_sync(context, "willem.getdnsapi.net", NULL, &response), + ASSERT_RC(getdns_address_sync(context, "d2a8n3.rootcanary.net", NULL, &response), GETDNS_RETURN_GOOD, "Return code from getdns_address_sync()"); EXTRACT_RESPONSE; diff --git a/src/test/check_getdns_general.h b/src/test/check_getdns_general.h index 8464b1b4..d35ecf1e 100644 --- a/src/test/check_getdns_general.h +++ b/src/test/check_getdns_general.h @@ -179,7 +179,7 @@ START_TEST (getdns_general_7) { /* - * name = "google.com" + * name = "nlnetlabs.nl" * request_type = 65279 (maximum unassigned RRTYPE) * expect: NOERROR/NODATA response: * status = GETDNS_RESPSTATUS_NO_NAME @@ -195,7 +195,7 @@ CONTEXT_CREATE(TRUE); EVENT_BASE_CREATE; - ASSERT_RC(getdns_general(context, "google.com", 65279, NULL, + ASSERT_RC(getdns_general(context, "nlnetlabs.nl", 65279, NULL, &fn_ref, &transaction_id, callbackfn), GETDNS_RETURN_GOOD, "Return code from getdns_general()"); @@ -322,7 +322,7 @@ START_TEST (getdns_general_11) { /* - * name = "willem.getdnsapi.net" and unbound zone + * name = "d2a8n3.rootcanary.net" and unbound zone * request_type = GETDNS_RRTYPE_MX * expect: NOERROR/NODATA response: * status = GETDNS_RESPSTATUS_NO_NAME @@ -338,7 +338,7 @@ CONTEXT_CREATE(TRUE); EVENT_BASE_CREATE; - ASSERT_RC(getdns_general(context, "willem.getdnsapi.net", GETDNS_RRTYPE_MX, NULL, + ASSERT_RC(getdns_general(context, "d2a8n3.rootcanary.net", GETDNS_RRTYPE_MX, NULL, &fn_ref, &transaction_id, callbackfn), GETDNS_RETURN_GOOD, "Return code from getdns_general()"); diff --git a/src/test/check_getdns_general_sync.h b/src/test/check_getdns_general_sync.h index c89f99f2..e69a2855 100644 --- a/src/test/check_getdns_general_sync.h +++ b/src/test/check_getdns_general_sync.h @@ -152,7 +152,7 @@ START_TEST (getdns_general_sync_7) { /* - * name = "google.com" + * name = "nlnetlabs.nl" * request_type = 65279 (maximum unassigned RRTYPE) * expect: NOERROR/NODATA response: * status = GETDNS_RESPSTATUS_NO_NAME @@ -164,7 +164,7 @@ CONTEXT_CREATE(TRUE); - ASSERT_RC(getdns_general_sync(context, "google.com", 65279, NULL, &response), + ASSERT_RC(getdns_general_sync(context, "nlnetlabs.nl", 65279, NULL, &response), GETDNS_RETURN_GOOD, "Return code from getdns_general_sync()"); EXTRACT_RESPONSE; @@ -267,7 +267,7 @@ START_TEST (getdns_general_sync_11) { /* - * name = "willem.getdnsapi.net" an unbound zone (as in no MX) + * name = "d2a8n3.rootcanary.net" an unbound zone (as in no MX) * request_type = GETDNS_RRTYPE_MX * expect: NOERROR/NODATA response: * status = GETDNS_RESPSTATUS_NO_NAME @@ -279,7 +279,7 @@ CONTEXT_CREATE(TRUE); - ASSERT_RC(getdns_general_sync(context, "willem.getdnsapi.net", GETDNS_RRTYPE_MX, NULL, &response), + ASSERT_RC(getdns_general_sync(context, "d2a8n3.rootcanary.net", GETDNS_RRTYPE_MX, NULL, &response), GETDNS_RETURN_GOOD, "Return code from getdns_general_sync()"); EXTRACT_RESPONSE;