interesting
/
getdns
mirror of https://github.com/getdnsapi/getdns.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Rename _getdns_tls_connection_verify() to _getdns_tls_connection_certificate_verify(). 

I managed to mislead myself about what it did, which suggests the name should be clearer.
This commit is contained in:
Jim Hague 2018-12-07 11:09:20 +00:00
parent b0c057e8ae
commit 64f0d6aaa8
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gnutls/tls.c
View File

@ -327,7 +327,7 @@ getdns_return_t _getdns_tls_connection_set_host_pinset(_getdns_tls_connection* c
return GETDNS_RETURN_GOOD; return GETDNS_RETURN_GOOD;
} }
getdns_return_t _getdns_tls_connection_verify(_getdns_tls_connection* conn, long* errnum, const char** errmsg) getdns_return_t _getdns_tls_connection_certificate_verify(_getdns_tls_connection* conn, long* errnum, const char** errmsg)
{ {
(void) errnum; (void) errnum;
(void) errmsg; (void) errmsg;

2
src/openssl/tls.c
View File

@ -507,7 +507,7 @@ getdns_return_t _getdns_tls_connection_set_host_pinset(_getdns_tls_connection* c
return GETDNS_RETURN_GOOD; return GETDNS_RETURN_GOOD;
} }
getdns_return_t _getdns_tls_connection_verify(_getdns_tls_connection* conn, long* errnum, const char** errmsg) getdns_return_t _getdns_tls_connection_certificate_verify(_getdns_tls_connection* conn, long* errnum, const char** errmsg)
{ {
if (!conn || !conn->ssl) if (!conn || !conn->ssl)
return GETDNS_RETURN_INVALID_PARAMETER; return GETDNS_RETURN_INVALID_PARAMETER;

2
src/stub.c
View File

@ -957,7 +957,7 @@ tls_do_handshake(getdns_upstream *upstream)
long verify_errno; long verify_errno;
const char* verify_errmsg; const char* verify_errmsg;
if (_getdns_tls_connection_verify(upstream->tls_obj, &verify_errno, &verify_errmsg)) { if (_getdns_tls_connection_certificate_verify(upstream->tls_obj, &verify_errno, &verify_errmsg)) {
upstream->tls_auth_state = GETDNS_AUTH_OK; upstream->tls_auth_state = GETDNS_AUTH_OK;
if (verify_errno != 0) { if (verify_errno != 0) {
_getdns_upstream_log(upstream, _getdns_upstream_log(upstream,

2
src/tls.h
View File

@ -271,7 +271,7 @@ getdns_return_t _getdns_tls_connection_set_host_pinset(_getdns_tls_connection* c
* @return GETDNS_RETURN_INVALID_PARAMETER if conn is null or has no SSL. * @return GETDNS_RETURN_INVALID_PARAMETER if conn is null or has no SSL.
* @return GETDNS_RETURN_GENERIC_ERROR if verification failed. * @return GETDNS_RETURN_GENERIC_ERROR if verification failed.
*/ */
getdns_return_t _getdns_tls_connection_verify(_getdns_tls_connection* conn, long* errnum, const char** errmsg); getdns_return_t _getdns_tls_connection_certificate_verify(_getdns_tls_connection* conn, long* errnum, const char** errmsg);
/** /**
* Read from TLS. * Read from TLS.