diff --git a/spec/example/Makefile.in b/spec/example/Makefile.in index 8ff7f2d1..7bf5e016 100644 --- a/spec/example/Makefile.in +++ b/spec/example/Makefile.in @@ -149,24 +149,16 @@ depend: # Dependencies for the examples example-all-functions.lo example-all-functions.o: $(srcdir)/example-all-functions.c $(srcdir)/getdns_libevent.h \ - ../../src/config.h \ - ../../src/getdns/getdns.h \ - $(srcdir)/../../src/getdns/getdns_ext_libevent.h \ - ../../src/getdns/getdns_extra.h -example-reverse.lo example-reverse.o: $(srcdir)/example-reverse.c $(srcdir)/getdns_libevent.h \ - ../../src/config.h \ - ../../src/getdns/getdns.h \ - $(srcdir)/../../src/getdns/getdns_ext_libevent.h \ + ../../src/config.h ../../src/getdns/getdns.h \ + $(srcdir)/../../src/getdns/getdns_ext_libevent.h ../../src/getdns/getdns_extra.h +example-reverse.lo example-reverse.o: $(srcdir)/example-reverse.c $(srcdir)/getdns_libevent.h ../../src/config.h \ + ../../src/getdns/getdns.h $(srcdir)/../../src/getdns/getdns_ext_libevent.h \ ../../src/getdns/getdns_extra.h example-simple-answers.lo example-simple-answers.o: $(srcdir)/example-simple-answers.c $(srcdir)/getdns_libevent.h \ - ../../src/config.h \ - ../../src/getdns/getdns.h \ - $(srcdir)/../../src/getdns/getdns_ext_libevent.h \ - ../../src/getdns/getdns_extra.h + ../../src/config.h ../../src/getdns/getdns.h \ + $(srcdir)/../../src/getdns/getdns_ext_libevent.h ../../src/getdns/getdns_extra.h example-synchronous.lo example-synchronous.o: $(srcdir)/example-synchronous.c $(srcdir)/getdns_core_only.h \ ../../src/getdns/getdns.h -example-tree.lo example-tree.o: $(srcdir)/example-tree.c $(srcdir)/getdns_libevent.h \ - ../../src/config.h \ - ../../src/getdns/getdns.h \ - $(srcdir)/../../src/getdns/getdns_ext_libevent.h \ +example-tree.lo example-tree.o: $(srcdir)/example-tree.c $(srcdir)/getdns_libevent.h ../../src/config.h \ + ../../src/getdns/getdns.h $(srcdir)/../../src/getdns/getdns_ext_libevent.h \ ../../src/getdns/getdns_extra.h diff --git a/src/Makefile.in b/src/Makefile.in index c8f214dd..d0824c81 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -225,189 +225,114 @@ depend: FORCE: # Dependencies for gldns, utils, the extensions and compat functions -const-info.lo const-info.o: $(srcdir)/const-info.c \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/const-info.h -context.lo context.o: $(srcdir)/context.c \ - config.h $(srcdir)/debug.h \ - $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/wire2str.h $(srcdir)/context.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h \ +const-info.lo const-info.o: $(srcdir)/const-info.c getdns/getdns.h getdns/getdns_extra.h \ + getdns/getdns.h $(srcdir)/const-info.h +context.lo context.o: $(srcdir)/context.c config.h $(srcdir)/debug.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h \ + $(srcdir)/gldns/wire2str.h $(srcdir)/context.h getdns/getdns.h getdns/getdns_extra.h \ + getdns/getdns.h $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h \ + $(srcdir)/extension/default_eventloop.h config.h getdns/getdns_extra.h $(srcdir)/ub_loop.h \ $(srcdir)/util-internal.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h \ - $(srcdir)/dnssec.h $(srcdir)/stub.h $(srcdir)/list.h $(srcdir)/dict.h $(srcdir)/pubkey-pinning.h -convert.lo convert.o: $(srcdir)/convert.c \ - config.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/util-internal.h $(srcdir)/context.h $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h \ - $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h \ - $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/gldns/wire2str.h $(srcdir)/gldns/str2wire.h \ - $(srcdir)/gldns/rrdef.h $(srcdir)/dict.h $(srcdir)/list.h $(srcdir)/convert.h -dict.lo dict.o: $(srcdir)/dict.c \ - config.h \ - $(srcdir)/types-internal.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/util/rbtree.h $(srcdir)/util-internal.h $(srcdir)/context.h $(srcdir)/extension/default_eventloop.h \ + $(srcdir)/dnssec.h $(srcdir)/gldns/rrdef.h $(srcdir)/stub.h $(srcdir)/list.h $(srcdir)/dict.h $(srcdir)/pubkey-pinning.h +convert.lo convert.o: $(srcdir)/convert.c config.h getdns/getdns.h getdns/getdns_extra.h \ + getdns/getdns.h $(srcdir)/util-internal.h $(srcdir)/context.h $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h \ + $(srcdir)/extension/default_eventloop.h config.h getdns/getdns_extra.h $(srcdir)/ub_loop.h \ + $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h \ + $(srcdir)/gldns/wire2str.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/dict.h $(srcdir)/list.h $(srcdir)/convert.h +dict.lo dict.o: $(srcdir)/dict.c config.h $(srcdir)/types-internal.h getdns/getdns.h \ + getdns/getdns_extra.h getdns/getdns.h $(srcdir)/util/rbtree.h $(srcdir)/util-internal.h \ + $(srcdir)/context.h $(srcdir)/extension/default_eventloop.h config.h getdns/getdns_extra.h \ $(srcdir)/ub_loop.h $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h \ $(srcdir)/dict.h $(srcdir)/list.h $(srcdir)/const-info.h $(srcdir)/gldns/wire2str.h -dnssec.lo dnssec.o: $(srcdir)/dnssec.c \ - config.h $(srcdir)/debug.h \ - getdns/getdns.h \ - $(srcdir)/context.h \ - getdns/getdns_extra.h \ - $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h \ +dnssec.lo dnssec.o: $(srcdir)/dnssec.c config.h $(srcdir)/debug.h getdns/getdns.h $(srcdir)/context.h \ + getdns/getdns_extra.h getdns/getdns.h $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h \ + $(srcdir)/extension/default_eventloop.h config.h getdns/getdns_extra.h $(srcdir)/ub_loop.h \ $(srcdir)/util-internal.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h \ - $(srcdir)/dnssec.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/wire2str.h $(srcdir)/gldns/keyraw.h \ - $(srcdir)/gldns/parseutil.h $(srcdir)/general.h $(srcdir)/dict.h $(srcdir)/list.h $(srcdir)/util/val_secalgo.h -general.lo general.o: $(srcdir)/general.c \ - config.h $(srcdir)/general.h \ - getdns/getdns.h \ - $(srcdir)/types-internal.h \ - getdns/getdns_extra.h \ - $(srcdir)/util/rbtree.h $(srcdir)/ub_loop.h $(srcdir)/debug.h $(srcdir)/gldns/wire2str.h $(srcdir)/context.h \ - $(srcdir)/extension/default_eventloop.h $(srcdir)/util-internal.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h \ - $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/dnssec.h $(srcdir)/stub.h $(srcdir)/dict.h -list.lo list.o: $(srcdir)/list.c $(srcdir)/types-internal.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/util/rbtree.h $(srcdir)/util-internal.h \ - config.h $(srcdir)/context.h \ - $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h \ - $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/list.h $(srcdir)/dict.h -pubkey-pinning.lo pubkey-pinning.o: $(srcdir)/pubkey-pinning.c \ - config.h $(srcdir)/debug.h \ - getdns/getdns.h \ - $(srcdir)/context.h \ - getdns/getdns_extra.h \ - $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h \ - $(srcdir)/util-internal.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h -request-internal.lo request-internal.o: $(srcdir)/request-internal.c \ - config.h \ - $(srcdir)/types-internal.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/util/rbtree.h $(srcdir)/util-internal.h $(srcdir)/context.h $(srcdir)/extension/default_eventloop.h \ - $(srcdir)/ub_loop.h $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h \ - $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/dict.h -rr-dict.lo rr-dict.o: $(srcdir)/rr-dict.c $(srcdir)/rr-dict.h \ - config.h \ - getdns/getdns.h \ - $(srcdir)/gldns/gbuffer.h $(srcdir)/util-internal.h $(srcdir)/context.h \ - getdns/getdns_extra.h \ - $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h \ - $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/gldns/pkthdr.h $(srcdir)/dict.h -rr-iter.lo rr-iter.o: $(srcdir)/rr-iter.c $(srcdir)/rr-iter.h \ - getdns/getdns.h \ - $(srcdir)/rr-dict.h config.h \ + $(srcdir)/dnssec.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/wire2str.h \ + $(srcdir)/gldns/keyraw.h $(srcdir)/gldns/parseutil.h $(srcdir)/general.h $(srcdir)/dict.h $(srcdir)/list.h \ + $(srcdir)/util/val_secalgo.h +general.lo general.o: $(srcdir)/general.c config.h $(srcdir)/general.h getdns/getdns.h $(srcdir)/types-internal.h \ + getdns/getdns_extra.h getdns/getdns.h $(srcdir)/util/rbtree.h $(srcdir)/ub_loop.h $(srcdir)/debug.h \ + $(srcdir)/gldns/wire2str.h $(srcdir)/context.h $(srcdir)/extension/default_eventloop.h config.h \ + getdns/getdns_extra.h $(srcdir)/util-internal.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h \ + $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/dnssec.h $(srcdir)/gldns/rrdef.h $(srcdir)/stub.h $(srcdir)/dict.h +list.lo list.o: $(srcdir)/list.c $(srcdir)/types-internal.h getdns/getdns.h getdns/getdns_extra.h \ + getdns/getdns.h $(srcdir)/util/rbtree.h $(srcdir)/util-internal.h config.h $(srcdir)/context.h \ + $(srcdir)/extension/default_eventloop.h config.h getdns/getdns_extra.h $(srcdir)/ub_loop.h \ + $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/list.h $(srcdir)/dict.h +pubkey-pinning.lo pubkey-pinning.o: $(srcdir)/pubkey-pinning.c config.h $(srcdir)/debug.h getdns/getdns.h \ + $(srcdir)/context.h getdns/getdns.h getdns/getdns_extra.h $(srcdir)/types-internal.h \ + $(srcdir)/util/rbtree.h $(srcdir)/extension/default_eventloop.h config.h \ + getdns/getdns_extra.h $(srcdir)/ub_loop.h $(srcdir)/util-internal.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h \ + $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h +request-internal.lo request-internal.o: $(srcdir)/request-internal.c config.h $(srcdir)/types-internal.h \ + getdns/getdns.h getdns/getdns_extra.h getdns/getdns.h $(srcdir)/util/rbtree.h \ + $(srcdir)/util-internal.h $(srcdir)/context.h $(srcdir)/extension/default_eventloop.h config.h \ + getdns/getdns_extra.h $(srcdir)/ub_loop.h $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h \ + $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/str2wire.h \ + $(srcdir)/gldns/rrdef.h $(srcdir)/dict.h $(srcdir)/convert.h +rr-dict.lo rr-dict.o: $(srcdir)/rr-dict.c $(srcdir)/rr-dict.h config.h getdns/getdns.h $(srcdir)/gldns/gbuffer.h \ + $(srcdir)/util-internal.h $(srcdir)/context.h getdns/getdns_extra.h getdns/getdns.h \ + $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h $(srcdir)/extension/default_eventloop.h config.h \ + getdns/getdns_extra.h $(srcdir)/ub_loop.h $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/gldns/pkthdr.h $(srcdir)/dict.h +rr-iter.lo rr-iter.o: $(srcdir)/rr-iter.c $(srcdir)/rr-iter.h getdns/getdns.h $(srcdir)/rr-dict.h config.h \ $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/gldns/rrdef.h -stub.lo stub.o: $(srcdir)/stub.c \ - config.h $(srcdir)/debug.h \ - $(srcdir)/stub.h \ - getdns/getdns.h \ - $(srcdir)/types-internal.h \ - getdns/getdns_extra.h \ - $(srcdir)/util/rbtree.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/gldns/rrdef.h \ - $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/wire2str.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h \ - $(srcdir)/context.h $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h $(srcdir)/util-internal.h \ - $(srcdir)/general.h $(srcdir)/pubkey-pinning.h -sync.lo sync.o: $(srcdir)/sync.c \ - getdns/getdns.h \ - config.h $(srcdir)/context.h \ - getdns/getdns_extra.h \ - $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h \ +stub.lo stub.o: $(srcdir)/stub.c config.h $(srcdir)/debug.h $(srcdir)/stub.h getdns/getdns.h $(srcdir)/types-internal.h \ + getdns/getdns_extra.h getdns/getdns.h $(srcdir)/util/rbtree.h $(srcdir)/gldns/gbuffer.h \ + $(srcdir)/gldns/pkthdr.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h \ + $(srcdir)/gldns/wire2str.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/context.h \ + $(srcdir)/extension/default_eventloop.h config.h getdns/getdns_extra.h $(srcdir)/ub_loop.h \ + $(srcdir)/util-internal.h $(srcdir)/general.h $(srcdir)/pubkey-pinning.h +sync.lo sync.o: $(srcdir)/sync.c getdns/getdns.h config.h $(srcdir)/context.h getdns/getdns_extra.h \ + getdns/getdns.h $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h \ + $(srcdir)/extension/default_eventloop.h config.h getdns/getdns_extra.h $(srcdir)/ub_loop.h \ $(srcdir)/debug.h $(srcdir)/general.h $(srcdir)/util-internal.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h \ - $(srcdir)/gldns/pkthdr.h $(srcdir)/dnssec.h $(srcdir)/stub.h $(srcdir)/gldns/wire2str.h -ub_loop.lo ub_loop.o: $(srcdir)/ub_loop.c $(srcdir)/ub_loop.h \ - config.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h $(srcdir)/debug.h -util-internal.lo util-internal.o: $(srcdir)/util-internal.c \ - config.h \ - getdns/getdns.h \ - $(srcdir)/dict.h $(srcdir)/util/rbtree.h $(srcdir)/types-internal.h \ - getdns/getdns_extra.h \ - $(srcdir)/list.h $(srcdir)/util-internal.h $(srcdir)/context.h $(srcdir)/extension/default_eventloop.h $(srcdir)/ub_loop.h \ - $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h \ - $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h -gbuffer.lo gbuffer.o: $(srcdir)/gldns/gbuffer.c \ - config.h \ - $(srcdir)/gldns/gbuffer.h -keyraw.lo keyraw.o: $(srcdir)/gldns/keyraw.c \ - config.h \ - $(srcdir)/gldns/keyraw.h $(srcdir)/gldns/rrdef.h -parse.lo parse.o: $(srcdir)/gldns/parse.c \ - config.h \ - $(srcdir)/gldns/parse.h $(srcdir)/gldns/parseutil.h $(srcdir)/gldns/gbuffer.h -parseutil.lo parseutil.o: $(srcdir)/gldns/parseutil.c \ - config.h \ - $(srcdir)/gldns/parseutil.h -rrdef.lo rrdef.o: $(srcdir)/gldns/rrdef.c \ - config.h \ - $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/parseutil.h -str2wire.lo str2wire.o: $(srcdir)/gldns/str2wire.c \ - config.h \ - $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/wire2str.h $(srcdir)/gldns/gbuffer.h \ - $(srcdir)/gldns/parse.h $(srcdir)/gldns/parseutil.h -wire2str.lo wire2str.o: $(srcdir)/gldns/wire2str.c \ - config.h \ - $(srcdir)/gldns/wire2str.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/pkthdr.h \ - $(srcdir)/gldns/parseutil.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/keyraw.h -arc4_lock.lo arc4_lock.o: $(srcdir)/compat/arc4_lock.c \ - config.h -arc4random.lo arc4random.o: $(srcdir)/compat/arc4random.c \ - config.h \ - $(srcdir)/compat/chacha_private.h -arc4random_uniform.lo arc4random_uniform.o: $(srcdir)/compat/arc4random_uniform.c \ - config.h -explicit_bzero.lo explicit_bzero.o: $(srcdir)/compat/explicit_bzero.c \ - config.h -getentropy_linux.lo getentropy_linux.o: $(srcdir)/compat/getentropy_linux.c \ - config.h -getentropy_osx.lo getentropy_osx.o: $(srcdir)/compat/getentropy_osx.c \ - config.h -getentropy_solaris.lo getentropy_solaris.o: $(srcdir)/compat/getentropy_solaris.c \ - config.h -getentropy_win.lo getentropy_win.o: $(srcdir)/compat/getentropy_win.c -inet_ntop.lo inet_ntop.o: $(srcdir)/compat/inet_ntop.c \ - config.h -inet_pton.lo inet_pton.o: $(srcdir)/compat/inet_pton.c \ - config.h -sha512.lo sha512.o: $(srcdir)/compat/sha512.c \ - config.h -strlcpy.lo strlcpy.o: $(srcdir)/compat/strlcpy.c \ - config.h -rbtree.lo rbtree.o: $(srcdir)/util/rbtree.c \ - config.h \ - $(srcdir)/util/log.h $(srcdir)/debug.h $(srcdir)/util/fptr_wlist.h $(srcdir)/util/rbtree.h -val_secalgo.lo val_secalgo.o: $(srcdir)/util/val_secalgo.c \ - config.h \ - $(srcdir)/util/val_secalgo.h $(srcdir)/util/log.h $(srcdir)/debug.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/keyraw.h \ - $(srcdir)/gldns/gbuffer.h -default_eventloop.lo default_eventloop.o: $(srcdir)/extension/default_eventloop.c \ - $(srcdir)/extension/default_eventloop.h \ - config.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ + $(srcdir)/gldns/pkthdr.h $(srcdir)/dnssec.h $(srcdir)/gldns/rrdef.h $(srcdir)/stub.h $(srcdir)/gldns/wire2str.h +ub_loop.lo ub_loop.o: $(srcdir)/ub_loop.c $(srcdir)/ub_loop.h config.h getdns/getdns.h \ + getdns/getdns_extra.h getdns/getdns.h $(srcdir)/types-internal.h $(srcdir)/util/rbtree.h \ $(srcdir)/debug.h -libev.lo libev.o: $(srcdir)/extension/libev.c \ - config.h \ - $(srcdir)/types-internal.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/util/rbtree.h $(srcdir)/getdns/getdns_ext_libev.h -libevent.lo libevent.o: $(srcdir)/extension/libevent.c \ - config.h \ - $(srcdir)/types-internal.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/util/rbtree.h $(srcdir)/getdns/getdns_ext_libevent.h -libuv.lo libuv.o: $(srcdir)/extension/libuv.c \ - config.h $(srcdir)/debug.h \ - $(srcdir)/types-internal.h \ - getdns/getdns.h \ - getdns/getdns_extra.h \ - $(srcdir)/util/rbtree.h $(srcdir)/getdns/getdns_ext_libuv.h +util-internal.lo util-internal.o: $(srcdir)/util-internal.c config.h getdns/getdns.h $(srcdir)/dict.h \ + $(srcdir)/util/rbtree.h $(srcdir)/types-internal.h getdns/getdns_extra.h getdns/getdns.h \ + $(srcdir)/list.h $(srcdir)/util-internal.h $(srcdir)/context.h $(srcdir)/extension/default_eventloop.h config.h \ + getdns/getdns_extra.h $(srcdir)/ub_loop.h $(srcdir)/debug.h $(srcdir)/rr-iter.h $(srcdir)/rr-dict.h \ + $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/pkthdr.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h $(srcdir)/dnssec.h \ + $(srcdir)/gldns/rrdef.h +version.lo version.o: version.c +gbuffer.lo gbuffer.o: $(srcdir)/gldns/gbuffer.c config.h $(srcdir)/gldns/gbuffer.h +keyraw.lo keyraw.o: $(srcdir)/gldns/keyraw.c config.h $(srcdir)/gldns/keyraw.h $(srcdir)/gldns/rrdef.h +parse.lo parse.o: $(srcdir)/gldns/parse.c config.h $(srcdir)/gldns/parse.h $(srcdir)/gldns/parseutil.h \ + $(srcdir)/gldns/gbuffer.h +parseutil.lo parseutil.o: $(srcdir)/gldns/parseutil.c config.h $(srcdir)/gldns/parseutil.h +rrdef.lo rrdef.o: $(srcdir)/gldns/rrdef.c config.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/parseutil.h +str2wire.lo str2wire.o: $(srcdir)/gldns/str2wire.c config.h $(srcdir)/gldns/str2wire.h $(srcdir)/gldns/rrdef.h \ + $(srcdir)/gldns/wire2str.h $(srcdir)/gldns/gbuffer.h $(srcdir)/gldns/parse.h $(srcdir)/gldns/parseutil.h +wire2str.lo wire2str.o: $(srcdir)/gldns/wire2str.c config.h $(srcdir)/gldns/wire2str.h $(srcdir)/gldns/str2wire.h \ + $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/pkthdr.h $(srcdir)/gldns/parseutil.h $(srcdir)/gldns/gbuffer.h \ + $(srcdir)/gldns/keyraw.h +arc4_lock.lo arc4_lock.o: $(srcdir)/compat/arc4_lock.c config.h +arc4random.lo arc4random.o: $(srcdir)/compat/arc4random.c config.h $(srcdir)/compat/chacha_private.h +arc4random_uniform.lo arc4random_uniform.o: $(srcdir)/compat/arc4random_uniform.c config.h +explicit_bzero.lo explicit_bzero.o: $(srcdir)/compat/explicit_bzero.c config.h +getentropy_linux.lo getentropy_linux.o: $(srcdir)/compat/getentropy_linux.c config.h +getentropy_osx.lo getentropy_osx.o: $(srcdir)/compat/getentropy_osx.c config.h +getentropy_solaris.lo getentropy_solaris.o: $(srcdir)/compat/getentropy_solaris.c config.h +getentropy_win.lo getentropy_win.o: $(srcdir)/compat/getentropy_win.c +inet_ntop.lo inet_ntop.o: $(srcdir)/compat/inet_ntop.c config.h +inet_pton.lo inet_pton.o: $(srcdir)/compat/inet_pton.c config.h +sha512.lo sha512.o: $(srcdir)/compat/sha512.c config.h +strlcpy.lo strlcpy.o: $(srcdir)/compat/strlcpy.c config.h +rbtree.lo rbtree.o: $(srcdir)/util/rbtree.c config.h $(srcdir)/util/log.h $(srcdir)/debug.h config.h \ + $(srcdir)/util/fptr_wlist.h $(srcdir)/util/rbtree.h +val_secalgo.lo val_secalgo.o: $(srcdir)/util/val_secalgo.c config.h $(srcdir)/util/val_secalgo.h $(srcdir)/util/log.h \ + $(srcdir)/debug.h config.h $(srcdir)/gldns/rrdef.h $(srcdir)/gldns/keyraw.h $(srcdir)/gldns/gbuffer.h +default_eventloop.lo default_eventloop.o: $(srcdir)/extension/default_eventloop.c \ + $(srcdir)/extension/default_eventloop.h config.h getdns/getdns.h \ + getdns/getdns_extra.h $(srcdir)/debug.h config.h +libev.lo libev.o: $(srcdir)/extension/libev.c config.h $(srcdir)/types-internal.h getdns/getdns.h \ + getdns/getdns_extra.h getdns/getdns.h $(srcdir)/util/rbtree.h \ + $(srcdir)/getdns/getdns_ext_libev.h getdns/getdns_extra.h +libevent.lo libevent.o: $(srcdir)/extension/libevent.c config.h $(srcdir)/types-internal.h \ + getdns/getdns.h getdns/getdns_extra.h getdns/getdns.h $(srcdir)/util/rbtree.h \ + $(srcdir)/getdns/getdns_ext_libevent.h getdns/getdns_extra.h +libuv.lo libuv.o: $(srcdir)/extension/libuv.c config.h $(srcdir)/debug.h config.h $(srcdir)/types-internal.h \ + getdns/getdns.h getdns/getdns_extra.h getdns/getdns.h $(srcdir)/util/rbtree.h \ + $(srcdir)/getdns/getdns_ext_libuv.h getdns/getdns_extra.h diff --git a/src/convert.c b/src/convert.c index cf23633f..65af8d79 100644 --- a/src/convert.c +++ b/src/convert.c @@ -755,20 +755,31 @@ getdns_wire2msg_dict_scan( if (!getdns_dict_get_int(reply, "/header/" #X, &n)) \ GLDNS_ ## Y ## _SET(header, n); #define SET_HEADER_BIT(X,Y) \ - if (!getdns_dict_get_int(reply, "/header/" #X, &n) && n) \ - GLDNS_ ## Y ## _SET(header); + if (!getdns_dict_get_int(reply, "/header/" #X, &n)) { \ + if (n) GLDNS_ ## Y ## _SET(header); \ + else GLDNS_ ## Y ## _CLR(header); \ + } -static getdns_return_t -_getdns_reply_dict2wire(const getdns_dict *reply, gldns_buffer *buf) +getdns_return_t +_getdns_reply_dict2wire( + const getdns_dict *reply, gldns_buffer *buf, int reuse_header) { - uint8_t header[GLDNS_HEADER_SIZE]; + uint8_t header_spc[GLDNS_HEADER_SIZE], *header; uint32_t n, qtype, qclass = GETDNS_RRCLASS_IN; size_t pkt_start, i; getdns_list *section; getdns_dict *rr_dict; getdns_bindata *qname; - (void) memset(header, 0, sizeof(GLDNS_HEADER_SIZE)); + pkt_start = gldns_buffer_position(buf); + if (reuse_header) { + if (gldns_buffer_remaining(buf) < GLDNS_HEADER_SIZE) + return GETDNS_RETURN_NEED_MORE_SPACE; + header = gldns_buffer_current(buf); + gldns_buffer_skip(buf, GLDNS_HEADER_SIZE); + } else + (void) memset((header = header_spc), 0, GLDNS_HEADER_SIZE); + SET_HEADER_INT(id, ID); SET_HEADER_BIT(qr, QR); SET_HEADER_BIT(aa, AA); @@ -781,8 +792,8 @@ _getdns_reply_dict2wire(const getdns_dict *reply, gldns_buffer *buf) SET_HEADER_INT(rcode, RCODE); SET_HEADER_BIT(z, Z); - pkt_start = gldns_buffer_position(buf); - gldns_buffer_write(buf, header, sizeof(header)); + if (!reuse_header) + gldns_buffer_write(buf, header, GLDNS_HEADER_SIZE); if (!getdns_dict_get_bindata(reply, "/question/qname", &qname) && !getdns_dict_get_int(reply, "/question/qtype", &qtype)) { @@ -791,6 +802,14 @@ _getdns_reply_dict2wire(const getdns_dict *reply, gldns_buffer *buf) gldns_buffer_write_u16(buf, (uint16_t)qtype); gldns_buffer_write_u16(buf, (uint16_t)qclass); gldns_buffer_write_u16_at(buf, pkt_start+GLDNS_QDCOUNT_OFF, 1); + if (reuse_header) { + gldns_buffer_write_u16_at( + buf, pkt_start+GLDNS_ANCOUNT_OFF, 0); + gldns_buffer_write_u16_at( + buf, pkt_start+GLDNS_NSCOUNT_OFF, 0); + gldns_buffer_write_u16_at( + buf, pkt_start+GLDNS_ARCOUNT_OFF, 0); + } } if (!getdns_dict_get_list(reply, "answer", §ion)) { for ( n = 0, i = 0 @@ -822,7 +841,7 @@ _getdns_reply_dict2wire(const getdns_dict *reply, gldns_buffer *buf) return GETDNS_RETURN_GOOD; } -static getdns_return_t +getdns_return_t _getdns_msg_dict2wire_buf(const getdns_dict *msg_dict, gldns_buffer *gbuf) { getdns_return_t r; @@ -833,11 +852,11 @@ _getdns_msg_dict2wire_buf(const getdns_dict *msg_dict, gldns_buffer *gbuf) if ((r = getdns_dict_get_list(msg_dict, "replies_tree", &replies))) { if (r != GETDNS_RETURN_NO_SUCH_DICT_NAME) return r; - return _getdns_reply_dict2wire(msg_dict, gbuf); + return _getdns_reply_dict2wire(msg_dict, gbuf, 0); } for (i = 0; r == GETDNS_RETURN_GOOD; i++) { if (!(r = getdns_list_get_dict(replies, i, &reply))) - r = _getdns_reply_dict2wire(reply, gbuf); + r = _getdns_reply_dict2wire(reply, gbuf, 0); } return r == GETDNS_RETURN_NO_SUCH_LIST_ITEM ? GETDNS_RETURN_GOOD : r; } @@ -894,10 +913,9 @@ getdns_msg_dict2wire_scan( getdns_return_t r; gldns_buffer gbuf; - if (!msg_dict || !wire || !*wire || !wire_sz) + if (!msg_dict || !wire || !wire_sz || (!*wire && *wire_sz)) return GETDNS_RETURN_INVALID_PARAMETER; - gldns_buffer_init_frm_data(&gbuf, *wire, *wire_sz); if ((r = _getdns_msg_dict2wire_buf(msg_dict, &gbuf))) return r; diff --git a/src/convert.h b/src/convert.h index 18b982ed..5b66412c 100644 --- a/src/convert.h +++ b/src/convert.h @@ -53,5 +53,8 @@ getdns_return_t _getdns_str2rr_dict(struct mem_funcs *mf, const char *str, getdns_return_t _getdns_fp2rr_list(struct mem_funcs *mf, FILE *in, getdns_list **rr_list, const char *origin, uint32_t default_ttl); +getdns_return_t _getdns_reply_dict2wire( + const getdns_dict *reply, gldns_buffer *buf, int reuse_header); + #endif /* convert.h */ diff --git a/src/dict.c b/src/dict.c index 1f1c9a25..910e0d28 100644 --- a/src/dict.c +++ b/src/dict.c @@ -603,6 +603,24 @@ getdns_dict_set_list( /*---------------------------------------- getdns_dict_set_bindata */ +getdns_return_t +_getdns_dict_set_this_bindata( + getdns_dict *dict, const char *name, getdns_bindata *bindata) +{ + getdns_item *item; + getdns_return_t r; + + if (!dict || !name || !bindata) + return GETDNS_RETURN_INVALID_PARAMETER; + + if ((r = _getdns_dict_find_and_add(dict, name, &item))) + return r; + + item->dtype = t_bindata; + item->data.bindata = bindata; + return GETDNS_RETURN_GOOD; +} + getdns_return_t _getdns_dict_set_const_bindata( getdns_dict *dict, const char *name, size_t size, const void *data) diff --git a/src/dnssec.c b/src/dnssec.c index 093ee40b..7c851aba 100644 --- a/src/dnssec.c +++ b/src/dnssec.c @@ -268,23 +268,6 @@ static uint8_t *_dname_label_copy(uint8_t *dst, const uint8_t *src, size_t dst_l return r; } -inline static void _dname_canonicalize(const uint8_t *src, uint8_t *dst) -{ - const uint8_t *next_label; - - while (*src) { - next_label = src + *src + 1; - *dst++ = *src++; - while (src < next_label) - *dst++ = (uint8_t)tolower((unsigned char)*src++); - } -} - -inline static void _dname_canonicalize2(uint8_t *dname) -{ - _dname_canonicalize(dname, dname); -} - /* Fills the array pointed to by labels (of at least 128 uint8_t * pointers) * with pointers to labels in given dname in reversed order. So that @@ -736,6 +719,8 @@ typedef struct chain_node chain_node; struct chain_head { struct mem_funcs my_mf; + size_t lock; + chain_head *next; chain_node *parent; size_t node_count; /* Number of nodes attached directly @@ -857,6 +842,7 @@ static chain_head *add_rrset2val_chain(struct mem_funcs *mf, head = *chain_p = (chain_head *)region; head->my_mf = *mf; + head->lock = 1; head->next = NULL; head->rrset.name = head->name_spc; memcpy(head->name_spc, rrset->name, dname_len); @@ -865,7 +851,7 @@ static chain_head *add_rrset2val_chain(struct mem_funcs *mf, head->rrset.pkt = rrset->pkt; head->rrset.pkt_len = rrset->pkt_len; head->netreq = netreq; - head->signer = 0; + head->signer = -1; head->node_count = node_count; if (!node_count) { @@ -894,8 +880,8 @@ static chain_head *add_rrset2val_chain(struct mem_funcs *mf, node->ds_req = NULL; node->dnskey_req = NULL; node->soa_req = NULL; - node->ds_signer = 0; - node->dnskey_signer = 0; + node->ds_signer = -1; + node->dnskey_signer = -1; node->chains = *chain_p; } @@ -1319,6 +1305,7 @@ static void val_chain_node_cb(getdns_dns_req *dnsreq) default : check_chain_complete(node->chains); return; } + node->lock++; n_signers = 0; for ( i = rrset_iter_init(&i_spc,netreq->response,netreq->response_len) ; i @@ -1344,6 +1331,7 @@ static void val_chain_node_cb(getdns_dns_req *dnsreq) */ val_chain_sched_soa_node(node->parent); + node->lock--; check_chain_complete(node->chains); } @@ -1363,17 +1351,21 @@ static void val_chain_node_soa_cb(getdns_dns_req *dnsreq) ! _dname_equal(node->ds.name, rrset->name)) node = node->parent; - if (node) + if (node) { + node->lock++; val_chain_sched_ds_node(node); - else { + } else { /* SOA for a different name */ node = (chain_node *)dnsreq->user_pointer; + node->lock++; val_chain_sched_soa_node(node->parent); } - } else if (node->parent) + } else if (node->parent) { + node->lock++; val_chain_sched_soa_node(node->parent); - + } + node->lock--; check_chain_complete(node->chains); } @@ -1528,21 +1520,6 @@ inline static void canon_rdata_iter_next(canon_rdata_iter *i) i->pos++; } -inline static int _dnssec_rdata_to_canonicalize(uint16_t rr_type) -{ - return rr_type == GLDNS_RR_TYPE_NS || rr_type == GLDNS_RR_TYPE_MD - || rr_type == GLDNS_RR_TYPE_MF || rr_type == GLDNS_RR_TYPE_CNAME - || rr_type == GLDNS_RR_TYPE_SOA || rr_type == GLDNS_RR_TYPE_MB - || rr_type == GLDNS_RR_TYPE_MG || rr_type == GLDNS_RR_TYPE_MR - || rr_type == GLDNS_RR_TYPE_PTR || rr_type == GLDNS_RR_TYPE_MINFO - || rr_type == GLDNS_RR_TYPE_MX || rr_type == GLDNS_RR_TYPE_RP - || rr_type == GLDNS_RR_TYPE_AFSDB || rr_type == GLDNS_RR_TYPE_RT - || rr_type == GLDNS_RR_TYPE_SIG || rr_type == GLDNS_RR_TYPE_PX - || rr_type == GLDNS_RR_TYPE_NXT || rr_type == GLDNS_RR_TYPE_NAPTR - || rr_type == GLDNS_RR_TYPE_KX || rr_type == GLDNS_RR_TYPE_SRV - || rr_type == GLDNS_RR_TYPE_DNAME || rr_type == GLDNS_RR_TYPE_RRSIG; -} - static int _rr_iter_rdata_cmp(const void *a, const void *b) { _getdns_rr_iter *x = (_getdns_rr_iter *)a; @@ -1656,6 +1633,7 @@ static int _getdns_verify_rrsig(struct mem_funcs *mf, if (!_dnssec_rdata_to_canonicalize(rrset->rr_type)) for (i = 0; i < n_rrs; i++) { + /* Get rid of doubles */ if (i && !_rr_iter_rdata_cmp( &val_rrset[i], &val_rrset[i-1])) continue; @@ -3003,7 +2981,7 @@ static size_t count_outstanding_requests(chain_head *head) if (!head) return 0; - for ( node = head->parent, count = 0 + for ( node = head->parent, count = head->lock ; node ; node = node->parent) { @@ -3047,6 +3025,77 @@ static int rrset_in_list(getdns_rrset *rrset, getdns_list *list) return 0; } +static void append_rrset2val_chain_list( + getdns_list *val_chain_list, getdns_rrset *rrset, int signer) +{ + _getdns_rr_iter val_rrset_spc[VAL_RRSET_SPC_SZ]; + _getdns_rr_iter *val_rrset = val_rrset_spc; + rrtype_iter rr_spc, *rr; + size_t n_rrs, i; + uint32_t orig_ttl; + getdns_dict *rr_dict; + rrsig_iter *rrsig, rrsig_spc; + + assert(val_chain_list && rrset); + + if (signer < 0) + return; + + for ( rrsig = rrsig_iter_init(&rrsig_spc, rrset) + ; rrsig && + ( rrsig->rr_i.nxt < rrsig->rr_i.rr_type + 28 + || gldns_read_uint16(rrsig->rr_i.rr_type + 26) + != (signer & 0xFFFF)) + ; rrsig = rrsig_iter_next(rrsig)) + ; /* pass */ + + if (!rrsig) + return; + + /* keytag was already read, so orig_ttl should cause no problem */ + assert(rrsig->rr_i.nxt >= rrsig->rr_i.rr_type + 18); + + orig_ttl = gldns_read_uint32(rrsig->rr_i.rr_type + 14); + + for (;;) { + for ( rr = rrtype_iter_init(&rr_spc, rrset), n_rrs = 0 + ; rr + ; rr = rrtype_iter_next(rr), n_rrs++) { + + if (n_rrs < VAL_RRSET_SPC_SZ || + val_rrset != val_rrset_spc) + val_rrset[n_rrs] = rr->rr_i; + } + /* Did everything fit? Then break */ + if (val_rrset != val_rrset_spc || n_rrs <= VAL_RRSET_SPC_SZ) + break; + + /* More space needed for val_rrset */ + val_rrset = GETDNS_XMALLOC( + val_chain_list->mf, _getdns_rr_iter, n_rrs); + } + qsort(val_rrset, n_rrs, sizeof(_getdns_rr_iter), _rr_iter_rdata_cmp); + for (i = 0; i < n_rrs; i++) { + /* Get rid of doubles */ + if (i && !_rr_iter_rdata_cmp(&val_rrset[i], &val_rrset[i-1])) + continue; + + if (!(rr_dict = _getdns_rr_iter2rr_dict_canonical( + &val_chain_list->mf, &val_rrset[i], &orig_ttl))) + continue; + + if (_getdns_list_append_this_dict(val_chain_list, rr_dict)) + getdns_dict_destroy(rr_dict); + } + if ((rr_dict = _getdns_rr_iter2rr_dict_canonical( + &val_chain_list->mf, &rrsig->rr_i, &orig_ttl)) && + _getdns_list_append_this_dict(val_chain_list, rr_dict)) + getdns_dict_destroy(rr_dict); + + if (val_rrset != val_rrset_spc) + GETDNS_FREE(val_chain_list->mf, val_rrset); +} + static void append_rrs2val_chain_list(getdns_context *ctxt, getdns_list *val_chain_list, getdns_network_req *netreq, int signer) { @@ -3072,6 +3121,15 @@ static void append_rrs2val_chain_list(getdns_context *ctxt, rrset->rr_type != GETDNS_RRTYPE_DS) continue; + if (signer > 0) { + /* We have a signer! Return RRset in canonical + * form and order with only the RRSIG that signed + * the RRset. + */ + append_rrset2val_chain_list( + val_chain_list, rrset, signer); + continue; + } for ( rr = rrtype_iter_init(&rr_spc, rrset) ; rr; rr = rrtype_iter_next(rr)) { @@ -3085,16 +3143,7 @@ static void append_rrs2val_chain_list(getdns_context *ctxt, for ( rrsig = rrsig_iter_init(&rrsig_spc, rrset) ; rrsig; rrsig = rrsig_iter_next(rrsig)) { - if (/* No space for keytag & signer in rrsig rdata? */ - rrsig->rr_i.nxt < rrsig->rr_i.rr_type + 28 - - /* We have a signer and it doesn't match? */ - || ((signer & 0xFFFF) && - gldns_read_uint16(rrsig->rr_i.rr_type + 26) - != (signer & 0xFFFF)) - - /* Could not convert to rr_dict */ - || !(rr_dict = _getdns_rr_iter2rr_dict( + if (!(rr_dict = _getdns_rr_iter2rr_dict( &ctxt->mf, &rrsig->rr_i))) continue; @@ -3139,7 +3188,7 @@ static void check_chain_complete(chain_head *chain) getdns_dns_req *dnsreq; getdns_context *context; size_t o, node_count; - chain_head *head, *next; + chain_head *head, *next, *same_chain; chain_node *node; getdns_list *val_chain_list; getdns_dict *response_dict; @@ -3181,7 +3230,7 @@ static void check_chain_complete(chain_head *chain) && !dnsreq->avoid_dnssec_roadblocks && dnsreq->netreqs[0]->dnssec_status == GETDNS_DNSSEC_BOGUS) { - getdns_return_t r = GETDNS_RETURN_GOOD; + int r = GETDNS_RETURN_GOOD; getdns_network_req **netreq_p, *netreq; dnsreq->avoid_dnssec_roadblocks = 1; @@ -3203,22 +3252,39 @@ static void check_chain_complete(chain_head *chain) /* Walk chain to add values to val_chain_list and to cleanup */ for ( head = chain; head ; head = next ) { next = head->next; + if (dnsreq->dnssec_return_full_validation_chain && + head->node_count && head->signer > 0) { + + append_rrset2val_chain_list( + val_chain_list, &head->rrset, head->signer); + + for ( same_chain = next + ; same_chain && same_chain->signer == head->signer + ; same_chain = same_chain->next) { + append_rrset2val_chain_list(val_chain_list, + &same_chain->rrset, same_chain->signer); + same_chain->signer = -1; + } + } for ( node_count = head->node_count, node = head->parent ; node_count ; node_count--, node = node->parent ) { if (node->dnskey_req) { - append_rrs2val_chain_list( - context, val_chain_list, - node->dnskey_req, node->dnskey_signer); + if (val_chain_list) + append_rrs2val_chain_list( + context, val_chain_list, + node->dnskey_req, + node->dnskey_signer); _getdns_dns_req_free(node->dnskey_req->owner); } if (node->ds_req) { - append_rrs2val_chain_list( - context, val_chain_list, - node->ds_req, node->ds_signer); + if (val_chain_list) + append_rrs2val_chain_list( + context, val_chain_list, + node->ds_req, node->ds_signer); - if (!node->ds_signer && + if (val_chain_list && node->ds_signer == -1 && !rrset_has_rrs(&node->ds)) { /* Add empty DS, to prevent less * specific to be able to authenticate @@ -3245,6 +3311,7 @@ static void check_chain_complete(chain_head *chain) } /* Final user callback */ + dnsreq->validating = 0; _getdns_call_user_callback(dnsreq, response_dict); } @@ -3252,7 +3319,11 @@ static void check_chain_complete(chain_head *chain) void _getdns_get_validation_chain(getdns_dns_req *dnsreq) { getdns_network_req *netreq, **netreq_p; - chain_head *chain = NULL; + chain_head *chain = NULL, *chain_p; + + if (dnsreq->validating) + return; + dnsreq->validating = 1; for (netreq_p = dnsreq->netreqs; (netreq = *netreq_p) ; netreq_p++) { if (! netreq->response @@ -3277,11 +3348,15 @@ void _getdns_get_validation_chain(getdns_dns_req *dnsreq) , netreq ); } - if (chain) + if (chain) { + for (chain_p = chain; chain_p; chain_p = chain_p->next) + chain_p->lock--; check_chain_complete(chain); - else + } else { + dnsreq->validating = 0; _getdns_call_user_callback(dnsreq, _getdns_create_getdns_response(dnsreq)); + } } diff --git a/src/dnssec.h b/src/dnssec.h index 263d6e0e..ae131efc 100644 --- a/src/dnssec.h +++ b/src/dnssec.h @@ -41,6 +41,7 @@ #include "getdns/getdns.h" #include "config.h" #include "gldns/gbuffer.h" +#include "gldns/rrdef.h" #include "types-internal.h" /* Do some additional requests to fetch the complete validation chain */ @@ -48,6 +49,21 @@ void _getdns_get_validation_chain(getdns_dns_req *dns_req); uint16_t _getdns_parse_ta_file(time_t *ta_mtime, gldns_buffer *gbuf); +inline static int _dnssec_rdata_to_canonicalize(uint16_t rr_type) +{ + return rr_type == GLDNS_RR_TYPE_NS || rr_type == GLDNS_RR_TYPE_MD + || rr_type == GLDNS_RR_TYPE_MF || rr_type == GLDNS_RR_TYPE_CNAME + || rr_type == GLDNS_RR_TYPE_SOA || rr_type == GLDNS_RR_TYPE_MB + || rr_type == GLDNS_RR_TYPE_MG || rr_type == GLDNS_RR_TYPE_MR + || rr_type == GLDNS_RR_TYPE_PTR || rr_type == GLDNS_RR_TYPE_MINFO + || rr_type == GLDNS_RR_TYPE_MX || rr_type == GLDNS_RR_TYPE_RP + || rr_type == GLDNS_RR_TYPE_AFSDB || rr_type == GLDNS_RR_TYPE_RT + || rr_type == GLDNS_RR_TYPE_SIG || rr_type == GLDNS_RR_TYPE_PX + || rr_type == GLDNS_RR_TYPE_NXT || rr_type == GLDNS_RR_TYPE_NAPTR + || rr_type == GLDNS_RR_TYPE_KX || rr_type == GLDNS_RR_TYPE_SRV + || rr_type == GLDNS_RR_TYPE_DNAME || rr_type == GLDNS_RR_TYPE_RRSIG; +} + #endif /* dnssec.h */ diff --git a/src/general.c b/src/general.c index 4de98853..1119106d 100644 --- a/src/general.c +++ b/src/general.c @@ -161,7 +161,7 @@ void _getdns_check_dns_req_complete(getdns_dns_req *dns_req) { getdns_network_req **netreq_p, *netreq; - int results_found = 0; + int results_found = 0, r; for (netreq_p = dns_req->netreqs; (netreq = *netreq_p); netreq_p++) if (netreq->state != NET_REQ_FINISHED && @@ -198,8 +198,11 @@ _getdns_check_dns_req_complete(getdns_dns_req *dns_req) ; (netreq = *netreq_p) ; netreq_p++ ) { _getdns_netreq_reinit(netreq); - if (_getdns_submit_netreq(netreq)) + if ((r = _getdns_submit_netreq(netreq))) { + if (r == DNS_REQ_FINISHED) + return; netreq->state = NET_REQ_FINISHED; + } } _getdns_check_dns_req_complete(dns_req); return; @@ -233,8 +236,11 @@ _getdns_check_dns_req_complete(getdns_dns_req *dns_req) ; (netreq = *netreq_p) ; netreq_p++ ) { _getdns_netreq_reinit(netreq); - if (_getdns_submit_netreq(netreq)) + if ((r = _getdns_submit_netreq(netreq))) { + if (r == DNS_REQ_FINISHED) + return; netreq->state = NET_REQ_FINISHED; + } } _getdns_check_dns_req_complete(dns_req); return; @@ -312,13 +318,16 @@ ub_resolve_callback(void* arg, int err, struct ub_result* ub_res) #endif -getdns_return_t +int _getdns_submit_netreq(getdns_network_req *netreq) { getdns_return_t r; getdns_dns_req *dns_req = netreq->owner; char name[1024]; - + int dnsreq_freed = 0; +#ifdef HAVE_LIBUNBOUND + int ub_resolve_r; +#endif #ifdef STUB_NATIVE_DNSSEC # ifdef DNSSEC_ROADBLOCK_AVOIDANCE @@ -351,24 +360,34 @@ _getdns_submit_netreq(getdns_network_req *netreq) dns_req->name_len, name, sizeof(name)); #ifdef HAVE_LIBUNBOUND + dns_req->freed = &dnsreq_freed; #ifdef HAVE_UNBOUND_EVENT_API if (_getdns_ub_loop_enabled(&dns_req->context->ub_loop)) - return ub_resolve_event(dns_req->context->unbound_ctx, + ub_resolve_r = ub_resolve_event(dns_req->context->unbound_ctx, name, netreq->request_type, netreq->owner->request_class, netreq, ub_resolve_event_callback, &(netreq->unbound_id)) ? GETDNS_RETURN_GENERIC_ERROR : GETDNS_RETURN_GOOD; else #endif - return ub_resolve_async(dns_req->context->unbound_ctx, + ub_resolve_r = ub_resolve_async(dns_req->context->unbound_ctx, name, netreq->request_type, netreq->owner->request_class, netreq, ub_resolve_callback, &(netreq->unbound_id)) ? GETDNS_RETURN_GENERIC_ERROR : GETDNS_RETURN_GOOD; + if (dnsreq_freed) + return DNS_REQ_FINISHED; + dns_req->freed = NULL; + return ub_resolve_r ? GETDNS_RETURN_GENERIC_ERROR : GETDNS_RETURN_GOOD; #else return GETDNS_RETURN_NOT_IMPLEMENTED; #endif } /* Submit with stub resolver */ - return _getdns_submit_stub_request(netreq); + dns_req->freed = &dnsreq_freed; + r = _getdns_submit_stub_request(netreq); + if (dnsreq_freed) + return DNS_REQ_FINISHED; + dns_req->freed = NULL; + return r; } @@ -403,6 +422,7 @@ validate_extensions(struct getdns_dict * extensions) {"add_opt_parameters" , t_dict, 1}, {"add_warning_for_bad_dns" , t_int , 1}, {"dnssec_return_all_statuses" , t_int , 1}, + {"dnssec_return_full_validation_chain", t_int , 1}, {"dnssec_return_only_secure" , t_int , 1}, {"dnssec_return_status" , t_int , 1}, {"dnssec_return_validation_chain", t_int , 1}, @@ -418,6 +438,7 @@ validate_extensions(struct getdns_dict * extensions) #else 0}, #endif + {"header" , t_dict, 1}, {"return_api_information" , t_int , 1}, {"return_both_v4_and_v6" , t_int , 1}, {"return_call_reporting" , t_int , 1}, @@ -456,7 +477,7 @@ getdns_general_ns(getdns_context *context, getdns_eventloop *loop, void *userarg, getdns_network_req **return_netreq_p, getdns_callback_t callbackfn, internal_cb_t internal_cb, int usenamespaces) { - getdns_return_t r = GETDNS_RETURN_GOOD; + int r = GETDNS_RETURN_GOOD; getdns_network_req *netreq, **netreq_p; getdns_dns_req *req; getdns_dict *localnames_response; @@ -495,8 +516,16 @@ getdns_general_ns(getdns_context *context, getdns_eventloop *loop, /* issue all network requests */ for ( netreq_p = req->netreqs ; !r && (netreq = *netreq_p) - ; netreq_p++) - r = _getdns_submit_netreq(netreq); + ; netreq_p++) { + if ((r = _getdns_submit_netreq(netreq))) { + if (r == DNS_REQ_FINISHED) { + if (return_netreq_p) + *return_netreq_p = NULL; + return GETDNS_RETURN_GOOD; + } + netreq->state = NET_REQ_FINISHED; + } + } else for (i = 0; i < context->namespace_count; i++) { if (context->namespaces[i] == GETDNS_NAMESPACE_LOCALNAMES) { @@ -517,14 +546,21 @@ getdns_general_ns(getdns_context *context, getdns_eventloop *loop, r = GETDNS_RETURN_GOOD; for ( netreq_p = req->netreqs ; !r && (netreq = *netreq_p) - ; netreq_p++) - r = _getdns_submit_netreq(netreq); + ; netreq_p++) { + if ((r = _getdns_submit_netreq(netreq))) { + if (r == DNS_REQ_FINISHED) { + if (return_netreq_p) + *return_netreq_p = NULL; + return GETDNS_RETURN_GOOD; + } + netreq->state = NET_REQ_FINISHED; + } + } break; } else r = GETDNS_RETURN_BAD_CONTEXT; } - - if (r != 0) { + if (r > 0) { /* i.e. r != GETDNS_RETURN_GOOD && r != DNS_REQ_FINISHED */ /* clean up the request */ _getdns_context_clear_outbound_request(req); _getdns_dns_req_free(req); diff --git a/src/general.h b/src/general.h index e9a4529e..29b52f47 100644 --- a/src/general.h +++ b/src/general.h @@ -42,9 +42,11 @@ /* private inner helper used by sync and async */ +#define DNS_REQ_FINISHED -1 + void _getdns_call_user_callback(getdns_dns_req *, getdns_dict *); void _getdns_check_dns_req_complete(getdns_dns_req *dns_req); -getdns_return_t _getdns_submit_netreq(getdns_network_req *netreq); +int _getdns_submit_netreq(getdns_network_req *netreq); getdns_return_t diff --git a/src/gldns/gbuffer.h b/src/gldns/gbuffer.h index 3d3190ed..2db9e250 100644 --- a/src/gldns/gbuffer.h +++ b/src/gldns/gbuffer.h @@ -164,7 +164,7 @@ gldns_buffer_invariant(gldns_buffer *buffer) assert(buffer != NULL); assert(buffer->_position <= buffer->_limit || buffer->_fixed); assert(buffer->_limit <= buffer->_capacity); - assert(buffer->_data != NULL); + assert(buffer->_data != NULL || (buffer->_capacity == 0 && buffer->_fixed)); } #endif diff --git a/src/request-internal.c b/src/request-internal.c index a81587f8..b36cb85e 100644 --- a/src/request-internal.c +++ b/src/request-internal.c @@ -42,6 +42,7 @@ #include "gldns/pkthdr.h" #include "dict.h" #include "debug.h" +#include "convert.h" /* MAXIMUM_TSIG_SPACE = TSIG name (dname) : 256 * TSIG type (uint16_t) : 2 @@ -143,7 +144,7 @@ network_req_init(getdns_network_req *net_req, getdns_dns_req *owner, int edns_maximum_udp_payload_size, uint8_t edns_extended_rcode, uint8_t edns_version, int edns_do_bit, uint16_t opt_options_size, size_t noptions, getdns_list *options, - size_t wire_data_sz, size_t max_query_sz) + size_t wire_data_sz, size_t max_query_sz, getdns_dict *extensions) { uint8_t *buf; getdns_dict *option; @@ -151,6 +152,7 @@ network_req_init(getdns_network_req *net_req, getdns_dns_req *owner, getdns_bindata *option_data; size_t i; int r = 0; + gldns_buffer gbuf; /* variables that stay the same on reinit, don't touch */ @@ -204,6 +206,10 @@ network_req_init(getdns_network_req *net_req, getdns_dns_req *owner, gldns_write_uint16(buf + GLDNS_ARCOUNT_OFF, with_opt ? 1 : 0); buf = netreq_reset(net_req); + gldns_buffer_init_frm_data( + &gbuf, net_req->query, net_req->wire_data_sz - 2); + _getdns_reply_dict2wire(extensions, &gbuf, 1); + if (with_opt) { net_req->opt = buf; buf[0] = 0; /* dname for . */ @@ -640,7 +646,8 @@ _getdns_dns_req_free(getdns_dns_req * req) req->loop->vmt->clear(req->loop, &req->timeout); req->timeout.timeout_cb = NULL; } - + if (req->freed) + *req->freed = 1; GETDNS_FREE(req->my_mf, req); } @@ -658,6 +665,8 @@ _getdns_dns_req_new(getdns_context *context, getdns_eventloop *loop, = is_extension_set(extensions, "dnssec_return_only_secure"); int dnssec_return_all_statuses = is_extension_set(extensions, "dnssec_return_all_statuses"); + int dnssec_return_full_validation_chain + = is_extension_set(extensions, "dnssec_return_full_validation_chain"); int dnssec_return_validation_chain = is_extension_set(extensions, "dnssec_return_validation_chain"); int edns_cookies @@ -674,6 +683,7 @@ _getdns_dns_req_new(getdns_context *context, getdns_eventloop *loop, int dnssec_extension_set = dnssec_return_status || dnssec_return_only_secure || dnssec_return_all_statuses || dnssec_return_validation_chain + || dnssec_return_full_validation_chain || (extensions == dnssec_ok_checking_disabled) || (extensions == dnssec_ok_checking_disabled_roadblock_avoidance) || (extensions == dnssec_ok_checking_disabled_avoid_roadblocks) @@ -874,7 +884,10 @@ _getdns_dns_req_new(getdns_context *context, getdns_eventloop *loop, result->dnssec_return_status = dnssec_return_status; result->dnssec_return_only_secure = dnssec_return_only_secure; result->dnssec_return_all_statuses = dnssec_return_all_statuses; - result->dnssec_return_validation_chain = dnssec_return_validation_chain; + result->dnssec_return_full_validation_chain = + dnssec_return_full_validation_chain; + result->dnssec_return_validation_chain = dnssec_return_validation_chain + || dnssec_return_full_validation_chain; result->edns_cookies = edns_cookies; #ifdef DNSSEC_ROADBLOCK_AVOIDANCE result->dnssec_roadblock_avoidance = dnssec_roadblock_avoidance; @@ -901,13 +914,16 @@ _getdns_dns_req_new(getdns_context *context, getdns_eventloop *loop, result->upstreams->referenced++; result->finished_next = NULL; + result->freed = NULL; + result->validating = 0; network_req_init(result->netreqs[0], result, request_type, dnssec_extension_set, with_opt, edns_maximum_udp_payload_size, edns_extended_rcode, edns_version, edns_do_bit, opt_options_size, noptions, options, - netreq_sz - sizeof(getdns_network_req), max_query_sz); + netreq_sz - sizeof(getdns_network_req), max_query_sz, + extensions); if (a_aaaa_query) network_req_init(result->netreqs[1], result, @@ -917,7 +933,8 @@ _getdns_dns_req_new(getdns_context *context, getdns_eventloop *loop, edns_maximum_udp_payload_size, edns_extended_rcode, edns_version, edns_do_bit, opt_options_size, noptions, options, - netreq_sz - sizeof(getdns_network_req), max_query_sz); + netreq_sz - sizeof(getdns_network_req), max_query_sz, + extensions); return result; } diff --git a/src/rr-dict.c b/src/rr-dict.c index bc7a77cd..76972997 100644 --- a/src/rr-dict.c +++ b/src/rr-dict.c @@ -1147,12 +1147,14 @@ getdns_return_t _getdns_rr_dict2wire(const getdns_dict *rr_dict, gldns_buffer *buf) { getdns_return_t r = GETDNS_RETURN_GOOD; + getdns_bindata root = { 1, (void *)"" }; getdns_bindata *name; getdns_bindata *rdata_raw; getdns_dict *rdata; uint32_t rr_type; uint32_t rr_class = GETDNS_RRCLASS_IN; uint32_t rr_ttl = 0; + uint32_t value; const _getdns_rr_def *rr_def; const _getdns_rdata_def *rd_def, *rep_rd_def; int n_rdata_fields, rep_n_rdata_fields; @@ -1164,18 +1166,35 @@ _getdns_rr_dict2wire(const getdns_dict *rr_dict, gldns_buffer *buf) assert(rr_dict); assert(buf); - if ((r = getdns_dict_get_bindata(rr_dict, "name", &name))) - return r; - gldns_buffer_write(buf, name->data, name->size); - if ((r = getdns_dict_get_int(rr_dict, "type", &rr_type))) return r; + if ((r = getdns_dict_get_bindata(rr_dict, "name", &name))) { + if (r == GETDNS_RETURN_NO_SUCH_DICT_NAME && + rr_type == GETDNS_RRTYPE_OPT) { + name = &root; + } else + return r; + } + gldns_buffer_write(buf, name->data, name->size); gldns_buffer_write_u16(buf, (uint16_t)rr_type); (void) getdns_dict_get_int(rr_dict, "class", &rr_class); + if (rr_type == GETDNS_RRTYPE_OPT) + (void) getdns_dict_get_int( + rr_dict, "udp_payload_size", &rr_class); gldns_buffer_write_u16(buf, (uint16_t)rr_class); (void) getdns_dict_get_int(rr_dict, "ttl", &rr_ttl); + if (rr_type == GETDNS_RRTYPE_OPT) { + if (!getdns_dict_get_int(rr_dict, "extended_rcode", &value)) + rr_ttl = (rr_ttl & 0x00FFFFFF)|((value & 0xFF) << 24); + if (!getdns_dict_get_int(rr_dict, "version", &value)) + rr_ttl = (rr_ttl & 0xFF00FFFF)|((value & 0xFF) << 16); + if (!getdns_dict_get_int(rr_dict, "z", &value)) + rr_ttl = (rr_ttl & 0xFFFF0000)| (value & 0xFFFF); + if (!getdns_dict_get_int(rr_dict, "do", &value)) + rr_ttl = (rr_ttl & 0xFFFF7FFF)| (value ? 0x8000 : 0); + } gldns_buffer_write_u32(buf, rr_ttl); /* Does rdata contain compressed names? diff --git a/src/test/Makefile.in b/src/test/Makefile.in index 03e1cce1..fbc72f8d 100644 --- a/src/test/Makefile.in +++ b/src/test/Makefile.in @@ -221,24 +221,21 @@ depend: .PHONY: clean test # Dependencies for the unit tests -check_getdns.lo check_getdns.o: $(srcdir)/check_getdns.c \ - ../getdns/getdns.h \ - $(srcdir)/check_getdns_common.h \ - ../getdns/getdns_extra.h \ - $(srcdir)/check_getdns_general.h $(srcdir)/check_getdns_general_sync.h \ - $(srcdir)/check_getdns_address.h $(srcdir)/check_getdns_address_sync.h \ - $(srcdir)/check_getdns_hostname.h $(srcdir)/check_getdns_hostname_sync.h \ - $(srcdir)/check_getdns_context_create.h $(srcdir)/check_getdns_context_destroy.h \ - $(srcdir)/check_getdns_cancel_callback.h $(srcdir)/check_getdns_list_get_length.h \ - $(srcdir)/check_getdns_list_get_data_type.h $(srcdir)/check_getdns_list_get_dict.h \ - $(srcdir)/check_getdns_list_get_list.h $(srcdir)/check_getdns_list_get_int.h \ - $(srcdir)/check_getdns_list_get_bindata.h $(srcdir)/check_getdns_dict_get_names.h \ - $(srcdir)/check_getdns_dict_get_data_type.h $(srcdir)/check_getdns_dict_get_dict.h \ - $(srcdir)/check_getdns_dict_get_list.h $(srcdir)/check_getdns_dict_get_bindata.h \ - $(srcdir)/check_getdns_dict_get_int.h $(srcdir)/check_getdns_dict_destroy.h \ - $(srcdir)/check_getdns_dict_set_dict.h $(srcdir)/check_getdns_dict_set_list.h \ - $(srcdir)/check_getdns_dict_set_bindata.h $(srcdir)/check_getdns_dict_set_int.h \ - $(srcdir)/check_getdns_convert_ulabel_to_alabel.h \ +check_getdns.lo check_getdns.o: $(srcdir)/check_getdns.c ../getdns/getdns.h $(srcdir)/check_getdns_common.h \ + ../getdns/getdns_extra.h $(srcdir)/check_getdns_general.h \ + $(srcdir)/check_getdns_general_sync.h $(srcdir)/check_getdns_address.h \ + $(srcdir)/check_getdns_address_sync.h $(srcdir)/check_getdns_hostname.h \ + $(srcdir)/check_getdns_hostname_sync.h $(srcdir)/check_getdns_context_create.h \ + $(srcdir)/check_getdns_context_destroy.h $(srcdir)/check_getdns_cancel_callback.h \ + $(srcdir)/check_getdns_list_get_length.h $(srcdir)/check_getdns_list_get_data_type.h \ + $(srcdir)/check_getdns_list_get_dict.h $(srcdir)/check_getdns_list_get_list.h \ + $(srcdir)/check_getdns_list_get_int.h $(srcdir)/check_getdns_list_get_bindata.h \ + $(srcdir)/check_getdns_dict_get_names.h $(srcdir)/check_getdns_dict_get_data_type.h \ + $(srcdir)/check_getdns_dict_get_dict.h $(srcdir)/check_getdns_dict_get_list.h \ + $(srcdir)/check_getdns_dict_get_bindata.h $(srcdir)/check_getdns_dict_get_int.h \ + $(srcdir)/check_getdns_dict_destroy.h $(srcdir)/check_getdns_dict_set_dict.h \ + $(srcdir)/check_getdns_dict_set_list.h $(srcdir)/check_getdns_dict_set_bindata.h \ + $(srcdir)/check_getdns_dict_set_int.h $(srcdir)/check_getdns_convert_ulabel_to_alabel.h \ $(srcdir)/check_getdns_convert_alabel_to_ulabel.h $(srcdir)/check_getdns_pretty_print_dict.h \ $(srcdir)/check_getdns_display_ip_address.h \ $(srcdir)/check_getdns_context_set_context_update_callback.h \ @@ -246,63 +243,36 @@ check_getdns.lo check_getdns.o: $(srcdir)/check_getdns.c \ $(srcdir)/check_getdns_context_set_upstream_recursive_servers.h \ $(srcdir)/check_getdns_service.h $(srcdir)/check_getdns_service_sync.h \ $(srcdir)/check_getdns_transport.h -check_getdns_common.lo check_getdns_common.o: $(srcdir)/check_getdns_common.c \ - ../getdns/getdns.h \ - ../config.h \ - $(srcdir)/check_getdns_common.h \ - ../getdns/getdns_extra.h \ +check_getdns_common.lo check_getdns_common.o: $(srcdir)/check_getdns_common.c ../getdns/getdns.h \ + ../config.h $(srcdir)/check_getdns_common.h ../getdns/getdns_extra.h \ $(srcdir)/check_getdns_eventloop.h check_getdns_context_set_timeout.lo check_getdns_context_set_timeout.o: $(srcdir)/check_getdns_context_set_timeout.c \ $(srcdir)/check_getdns_context_set_timeout.h $(srcdir)/check_getdns_common.h \ - ../getdns/getdns.h \ - ../getdns/getdns_extra.h + ../getdns/getdns.h ../getdns/getdns_extra.h check_getdns_libev.lo check_getdns_libev.o: $(srcdir)/check_getdns_libev.c $(srcdir)/check_getdns_eventloop.h \ - ../config.h \ - ../getdns/getdns.h \ - $(srcdir)/../getdns/getdns_ext_libev.h \ - ../getdns/getdns_extra.h \ - $(srcdir)/check_getdns_common.h + ../config.h ../getdns/getdns.h $(srcdir)/../getdns/getdns_ext_libev.h \ + ../getdns/getdns_extra.h $(srcdir)/check_getdns_common.h check_getdns_libevent.lo check_getdns_libevent.o: $(srcdir)/check_getdns_libevent.c $(srcdir)/check_getdns_eventloop.h \ - ../config.h \ - ../getdns/getdns.h \ - $(srcdir)/../getdns/getdns_ext_libevent.h \ - ../getdns/getdns_extra.h \ - $(srcdir)/check_getdns_libevent.h $(srcdir)/check_getdns_common.h + ../config.h ../getdns/getdns.h $(srcdir)/../getdns/getdns_ext_libevent.h \ + ../getdns/getdns_extra.h $(srcdir)/check_getdns_libevent.h $(srcdir)/check_getdns_common.h check_getdns_libuv.lo check_getdns_libuv.o: $(srcdir)/check_getdns_libuv.c $(srcdir)/check_getdns_eventloop.h \ - ../config.h \ - ../getdns/getdns.h \ - $(srcdir)/../getdns/getdns_ext_libuv.h \ - ../getdns/getdns_extra.h \ - $(srcdir)/check_getdns_common.h + ../config.h ../getdns/getdns.h $(srcdir)/../getdns/getdns_ext_libuv.h \ + ../getdns/getdns_extra.h $(srcdir)/check_getdns_common.h check_getdns_selectloop.lo check_getdns_selectloop.o: $(srcdir)/check_getdns_selectloop.c \ - $(srcdir)/check_getdns_eventloop.h \ - ../config.h \ - ../getdns/getdns.h \ + $(srcdir)/check_getdns_eventloop.h ../config.h ../getdns/getdns.h \ ../getdns/getdns_extra.h check_getdns_transport.lo check_getdns_transport.o: $(srcdir)/check_getdns_transport.c \ - $(srcdir)/check_getdns_transport.h $(srcdir)/check_getdns_common.h \ - ../getdns/getdns.h \ + $(srcdir)/check_getdns_transport.h $(srcdir)/check_getdns_common.h ../getdns/getdns.h \ ../getdns/getdns_extra.h -getdns_query.lo getdns_query.o: $(srcdir)/getdns_query.c \ - ../config.h \ - $(srcdir)/../debug.h \ - ../getdns/getdns.h \ - ../getdns/getdns_extra.h -scratchpad.template.lo scratchpad.template.o: scratchpad.template.c \ - ../getdns/getdns.h \ +getdns_query.lo getdns_query.o: $(srcdir)/getdns_query.c ../config.h $(srcdir)/../debug.h ../config.h \ + ../getdns/getdns.h ../getdns/getdns_extra.h +scratchpad.template.lo scratchpad.template.o: scratchpad.template.c ../getdns/getdns.h \ ../getdns/getdns_extra.h testmessages.lo testmessages.o: $(srcdir)/testmessages.c $(srcdir)/testmessages.h -tests_dict.lo tests_dict.o: $(srcdir)/tests_dict.c $(srcdir)/testmessages.h \ - ../getdns/getdns.h -tests_list.lo tests_list.o: $(srcdir)/tests_list.c $(srcdir)/testmessages.h \ - ../getdns/getdns.h -tests_namespaces.lo tests_namespaces.o: $(srcdir)/tests_namespaces.c $(srcdir)/testmessages.h \ - ../getdns/getdns.h -tests_stub_async.lo tests_stub_async.o: $(srcdir)/tests_stub_async.c \ - ../config.h \ - $(srcdir)/testmessages.h \ - ../getdns/getdns.h \ - ../getdns/getdns_extra.h -tests_stub_sync.lo tests_stub_sync.o: $(srcdir)/tests_stub_sync.c $(srcdir)/testmessages.h \ - ../getdns/getdns.h \ +tests_dict.lo tests_dict.o: $(srcdir)/tests_dict.c $(srcdir)/testmessages.h ../getdns/getdns.h +tests_list.lo tests_list.o: $(srcdir)/tests_list.c $(srcdir)/testmessages.h ../getdns/getdns.h +tests_namespaces.lo tests_namespaces.o: $(srcdir)/tests_namespaces.c $(srcdir)/testmessages.h ../getdns/getdns.h +tests_stub_async.lo tests_stub_async.o: $(srcdir)/tests_stub_async.c ../config.h $(srcdir)/testmessages.h \ + ../getdns/getdns.h ../getdns/getdns_extra.h +tests_stub_sync.lo tests_stub_sync.o: $(srcdir)/tests_stub_sync.c $(srcdir)/testmessages.h ../getdns/getdns.h \ ../getdns/getdns_extra.h diff --git a/src/test/getdns_query.c b/src/test/getdns_query.c index ba0e8c47..737a3b11 100644 --- a/src/test/getdns_query.c +++ b/src/test/getdns_query.c @@ -474,6 +474,7 @@ print_usage(FILE *out, const char *progname) fprintf(out, "\t+dnssec_return_only_secure\n"); fprintf(out, "\t+dnssec_return_all_statuses\n"); fprintf(out, "\t+dnssec_return_validation_chain\n"); + fprintf(out, "\t+dnssec_return_full_validation_chain\n"); #ifdef DNSSEC_ROADBLOCK_AVOIDANCE fprintf(out, "\t+dnssec_roadblock_avoidance\n"); #endif diff --git a/src/test/tpkg/100-compile.tpkg/100-compile.dsc b/src/test/tpkg/100-compile.tpkg/100-compile.dsc index e39ac6a7..8f73a87f 100644 --- a/src/test/tpkg/100-compile.tpkg/100-compile.dsc +++ b/src/test/tpkg/100-compile.tpkg/100-compile.dsc @@ -9,7 +9,7 @@ CmdDepends: Depends: Help: Pre: 100-compile.pre -Post: +Post: 100-compile.post Test: 100-compile.test AuxFiles: Passed: diff --git a/src/test/tpkg/100-compile.tpkg/100-compile.post b/src/test/tpkg/100-compile.tpkg/100-compile.post new file mode 100644 index 00000000..7744f6e7 --- /dev/null +++ b/src/test/tpkg/100-compile.tpkg/100-compile.post @@ -0,0 +1,20 @@ +# #-- 100-compile.post --# +# source the master var file when it's there +if [ -f ../.tpkg.var.master ] +then + source ../.tpkg.var.master +else + ( + cd .. + [ -f "${TPKG_SRCDIR}/setup-env.sh" ] \ + && sh "${TPKG_SRCDIR}/setup-env.sh" + ) && source ../.tpkg.var.master +fi +# use .tpkg.var.test for in test variable passing +[ -f .tpkg.var.test ] && source .tpkg.var.test + +for f in `cat restore-srcdir-configure-settings` +do + mv "${SRCROOT}/${f}.build" "${SRCROOT}/${f}" +done + diff --git a/src/test/tpkg/100-compile.tpkg/100-compile.pre b/src/test/tpkg/100-compile.tpkg/100-compile.pre index a0272ed3..95fbced2 100644 --- a/src/test/tpkg/100-compile.tpkg/100-compile.pre +++ b/src/test/tpkg/100-compile.tpkg/100-compile.pre @@ -13,6 +13,15 @@ fi # use .tpkg.var.test for in test variable passing [ -f .tpkg.var.test ] && source .tpkg.var.test +echo "" > restore-srcdir-configure-settings +for f in `grep 'CONFIG_[FH][IE][LA][ED][SE]' "${SRCROOT}/configure.ac" | sed -e 's/^.*(\[//g' -e 's/\])//g'` +do + if [ -f "${SRCROOT}/$f" ] + then + mv "${SRCROOT}/${f}" "${SRCROOT}/${f}.build" && \ + echo "$f" >> restore-srcdir-configure-settings + fi +done rm -fr "${BUILDDIR}/build" mkdir "${BUILDDIR}/build" cd "${BUILDDIR}/build" diff --git a/src/test/tpkg/125-valgrind-checks.tpkg/125-valgrind-checks.test b/src/test/tpkg/125-valgrind-checks.tpkg/125-valgrind-checks.test index 60f216c7..0e7c4981 100644 --- a/src/test/tpkg/125-valgrind-checks.tpkg/125-valgrind-checks.test +++ b/src/test/tpkg/125-valgrind-checks.tpkg/125-valgrind-checks.test @@ -6,8 +6,12 @@ cat >queries < restore-srcdir-configure-settings +for f in `grep 'CONFIG_[FH][IE][LA][ED][SE]' "${SRCROOT}/configure.ac" | sed -e 's/^.*(\[//g' -e 's/\])//g'` +do + if [ -f "${SRCROOT}/$f" ] + then + mv "${SRCROOT}/${f}" "${SRCROOT}/${f}.build-stub-only" && \ + echo "$f" >> restore-srcdir-configure-settings + fi +done rm -fr "${BUILDDIR}/build-stub-only" mkdir "${BUILDDIR}/build-stub-only" cd "${BUILDDIR}/build-stub-only" diff --git a/src/test/tpkg/270-header-extension.tpkg/270-header-extension.Makefile b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.Makefile new file mode 100644 index 00000000..708341a1 --- /dev/null +++ b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.Makefile @@ -0,0 +1,15 @@ +builddir = @BUILDDIR@ +testname = @TPKG_NAME@ +LIBTOOL = $(builddir)/libtool + +CFLAGS=-I$(builddir)/src +LDLIBS=$(builddir)/src/libgetdns.la + +.SUFFIXES: .c .o .a .lo .h + +.c.lo: + $(LIBTOOL) --quiet --tag=CC --mode=compile $(CC) $(CFLAGS) -c $< -o $@ + +$(testname): $(testname).lo + $(LIBTOOL) --tag=CC --mode=link $(CC) $(LDLIBS) $(LDFLAGS) -o $@ $< + diff --git a/src/test/tpkg/270-header-extension.tpkg/270-header-extension.c b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.c new file mode 100644 index 00000000..e845299b --- /dev/null +++ b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.c @@ -0,0 +1,115 @@ +#include +#include +#include + +/* Example setting header bits to do a direct authoritative query */ + +int main() +{ + getdns_return_t r; + getdns_context *ctx = NULL; + getdns_dict *extensions = NULL; + getdns_bindata ipv4 = { 4, (uint8_t*)"IPv4" }; + /* 185.49.141.37 */ + getdns_bindata nsip = { 4, (uint8_t*)"\xb9\x31\x8c\x3c" }; + getdns_dict *upstream = NULL; + getdns_list *upstreams = NULL; + getdns_dict *response = NULL; + uint32_t value; + char *str; + + if ((r = getdns_context_create(&ctx, 1))) + fprintf(stderr, "Could not create context"); + + else if (!(extensions = getdns_dict_create_with_context(ctx))) { + fprintf(stderr, "Could not create dictionary"); + r = GETDNS_RETURN_MEMORY_ERROR; + + } else if ((r = getdns_dict_set_int(extensions, "/header/rd", 0))) + fprintf(stderr, "Could not set RD bit"); + + else if ((r = getdns_dict_set_int(extensions, "/add_opt_parameters/do_bit", 1))) + fprintf(stderr, "Could not set qtype"); + + else if (!(upstream = getdns_dict_create_with_context(ctx))) { + fprintf(stderr, "Could not create upstream dictionary"); + r = GETDNS_RETURN_MEMORY_ERROR; + + } else if ((r = getdns_dict_set_bindata(upstream, "address_type", &ipv4))) + fprintf(stderr, "Could set \"address_type\""); + + else if ((r = getdns_dict_set_bindata(upstream, "address_data", &nsip))) + fprintf(stderr, "Could set \"address_data\""); + + else if (!(upstreams = getdns_list_create_with_context(ctx))) { + fprintf(stderr, "Could not create upstreams list"); + r = GETDNS_RETURN_MEMORY_ERROR; + + } else if ((r = getdns_list_set_dict(upstreams, 0, upstream))) + fprintf(stderr, "Could not append upstream to upstreams list"); + + else if ((r = getdns_context_set_resolution_type(ctx, GETDNS_RESOLUTION_STUB))) + fprintf(stderr, "Could not set stub mode"); + + else if ((r = getdns_context_set_upstream_recursive_servers(ctx, upstreams))) + fprintf(stderr, "Could not set upstreams list"); + + else if ((r = getdns_general_sync(ctx, "bogus.nlnetlabs.nl.", GETDNS_RRTYPE_TXT, extensions, &response))) + fprintf(stderr, "Could not do lookup"); + + else if ((r = getdns_dict_get_int(response, "status", &value))) + fprintf(stderr, "Could not get status from response"); + + else if (value != GETDNS_RESPSTATUS_GOOD) { + fprintf(stderr, "response['status'] != GETDNS_RESPSTATUS_GOOD"); + r = GETDNS_RETURN_GENERIC_ERROR; + + } else if ((r = getdns_dict_get_int(response, "/replies_tree/0/header/rd", &value))) + fprintf(stderr, "Could not get RD bit from header"); + + else if (value != 0) { + fprintf(stderr, "RD bit != 0"); + r = GETDNS_RETURN_GENERIC_ERROR; + + } else if ((r = getdns_dict_get_int(response, "/replies_tree/0/header/ancount", &value))) + fprintf(stderr, "Could not get ANCOUNT from header"); + + else if (value != 2) { + fprintf(stderr, "ANCOUNT != 2"); + r = GETDNS_RETURN_GENERIC_ERROR; + + } else if ((r = getdns_dict_set_int(extensions, "/header/opcode", GETDNS_OPCODE_STATUS))) + fprintf(stderr, "Could not set opcode"); + + else if ((r = getdns_general_sync(ctx, "bogus.nlnetlabs.nl.", GETDNS_RRTYPE_TXT, extensions, &response))) + fprintf(stderr, "Could not do lookup"); + + else if ((r = getdns_dict_remove_name(response, "replies_full"))) + fprintf(stderr, "Could not remove reponse['replies_full']"); + + else if ((r = getdns_dict_remove_name(response, "/replies_tree/0/header/id"))) + fprintf(stderr, "Could not remove ID from response"); + + else if (!(str = getdns_pretty_print_dict(response))) + fprintf(stderr, "Could not pretty print dict"); + + else if(printf("%s\n", str), free(str), 0) + ; + + if (response) + getdns_dict_destroy(response); + if (upstreams) + getdns_list_destroy(upstreams); + if (upstream) + getdns_dict_destroy(upstream); + if (extensions) + getdns_dict_destroy(extensions); + if (ctx) + getdns_context_destroy(ctx); + + if (r) { + fprintf(stderr, ": %s\n", getdns_get_errorstr_by_id(r)); + exit(EXIT_FAILURE); + } + exit(EXIT_SUCCESS); +} diff --git a/src/test/tpkg/270-header-extension.tpkg/270-header-extension.dsc b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.dsc new file mode 100644 index 00000000..2ac9ae37 --- /dev/null +++ b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.dsc @@ -0,0 +1,16 @@ +BaseName: 270-header-extension +Version: 1.0 +Description: Test json pointers +CreationDate: do 28 apr 2016 13:48:05 CEST +Maintainer: Willem Toorop +Category: +Component: +CmdDepends: +Depends: 200-stub-only-compile.tpkg +Help: +Pre: 270-header-extension.pre +Post: +Test: 270-header-extension.test +AuxFiles: +Passed: +Failure: diff --git a/src/test/tpkg/270-header-extension.tpkg/270-header-extension.good b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.good new file mode 100644 index 00000000..2419d76b --- /dev/null +++ b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.good @@ -0,0 +1,32 @@ +{ + "answer_type": GETDNS_NAMETYPE_DNS, + "canonical_name": , + "replies_tree": + [ + { + "additional": [], + "answer": [], + "answer_type": GETDNS_NAMETYPE_DNS, + "authority": [], + "canonical_name": , + "header": + { + "aa": 0, + "ad": 0, + "ancount": 0, + "arcount": 0, + "cd": 0, + "nscount": 0, + "opcode": GETDNS_OPCODE_STATUS, + "qdcount": 0, + "qr": 1, + "ra": 0, + "rcode": GETDNS_RCODE_NOTIMP, + "rd": 0, + "tc": 0, + "z": 0 + } + } + ], + "status": GETDNS_RESPSTATUS_NO_NAME +} diff --git a/src/test/tpkg/270-header-extension.tpkg/270-header-extension.pre b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.pre new file mode 100644 index 00000000..f6db2030 --- /dev/null +++ b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.pre @@ -0,0 +1,14 @@ +# #-- 270-header-extension.test --# +# source the master var file when it's there +[ -f ../.tpkg.var.master ] && source ../.tpkg.var.master +# use .tpkg.var.test for in test variable passing +[ -f .tpkg.var.test ] && source .tpkg.var.test + +( + grep '^CC=' "${BUILDDIR}/build-stub-only/src/Makefile" + grep '^LDFLAGS=' "${BUILDDIR}/build-stub-only/src/Makefile" + + BUILDDIR4SED=`echo "${BUILDDIR}/build-stub-only" | sed 's/\//\\\\\//g'` + sed -e "s/@BUILDDIR@/${BUILDDIR4SED}/g" \ + -e "s/@TPKG_NAME@/${TPKG_NAME}/g" "${TPKG_NAME}.Makefile" +) > Makefile diff --git a/src/test/tpkg/270-header-extension.tpkg/270-header-extension.test b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.test new file mode 100644 index 00000000..b9f372ac --- /dev/null +++ b/src/test/tpkg/270-header-extension.tpkg/270-header-extension.test @@ -0,0 +1,7 @@ +# #-- 270-header-extension.test --# +# source the master var file when it's there +[ -f ../.tpkg.var.master ] && source ../.tpkg.var.master +# use .tpkg.var.test for in test variable passing +[ -f .tpkg.var.test ] && source .tpkg.var.test + +make && "./${TPKG_NAME}" | tee out && diff out "${TPKG_NAME}.good" diff --git a/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.dsc b/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.dsc index 96d36c48..61defe2c 100644 --- a/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.dsc +++ b/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.dsc @@ -8,8 +8,8 @@ Component: CmdDepends: Depends: 300-event-loops-configure.tpkg Help: -Pre: -Post: +Pre: 320-event-loops-compile.pre +Post: 320-event-loops-compile.post Test: 320-event-loops-compile.test AuxFiles: Passed: diff --git a/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.post b/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.post new file mode 100644 index 00000000..a3e29076 --- /dev/null +++ b/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.post @@ -0,0 +1,20 @@ +# #-- 320-event-loops-compile.post --# +# source the master var file when it's there +if [ -f ../.tpkg.var.master ] +then + source ../.tpkg.var.master +else + ( + cd .. + [ -f "${TPKG_SRCDIR}/setup-env.sh" ] \ + && sh "${TPKG_SRCDIR}/setup-env.sh" + ) && source ../.tpkg.var.master +fi +# use .tpkg.var.test for in test variable passing +[ -f .tpkg.var.test ] && source .tpkg.var.test + +for f in `cat restore-srcdir-configure-settings` +do + mv "${SRCROOT}/${f}.build-event-loops" "${SRCROOT}/${f}" +done + diff --git a/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.pre b/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.pre new file mode 100644 index 00000000..a48754d4 --- /dev/null +++ b/src/test/tpkg/320-event-loops-compile.tpkg/320-event-loops-compile.pre @@ -0,0 +1,24 @@ +# #-- 320-event-loops-compile.pre--# +# source the master var file when it's there +if [ -f ../.tpkg.var.master ] +then + source ../.tpkg.var.master +else + ( + cd .. + [ -f "${TPKG_SRCDIR}/setup-env.sh" ] \ + && sh "${TPKG_SRCDIR}/setup-env.sh" + ) && source ../.tpkg.var.master +fi +# use .tpkg.var.test for in test variable passing +[ -f .tpkg.var.test ] && source .tpkg.var.test + +echo "" > restore-srcdir-configure-settings +for f in `grep 'CONFIG_[FH][IE][LA][ED][SE]' "${SRCROOT}/configure.ac" | sed -e 's/^.*(\[//g' -e 's/\])//g'` +do + if [ -f "${SRCROOT}/$f" ] + then + mv "${SRCROOT}/${f}" "${SRCROOT}/${f}.build-event-loops" && \ + echo "$f" >> restore-srcdir-configure-settings + fi +done diff --git a/src/test/tpkg/330-event-loops-unit-tests.tpkg/330-event-loops-unit-tests.test b/src/test/tpkg/330-event-loops-unit-tests.tpkg/330-event-loops-unit-tests.test index e80948e0..c6539115 100644 --- a/src/test/tpkg/330-event-loops-unit-tests.tpkg/330-event-loops-unit-tests.test +++ b/src/test/tpkg/330-event-loops-unit-tests.tpkg/330-event-loops-unit-tests.test @@ -5,4 +5,10 @@ [ -f .tpkg.var.test ] && source .tpkg.var.test cd "${BUILDDIR}/build-event-loops" -make test +if make test +then + if grep ERROR "${BUILDDIR}/build-event-loops/src/test/*.log" + then + exit 1 + fi +fi diff --git a/src/types-internal.h b/src/types-internal.h index 9e9a4d34..f63fde13 100644 --- a/src/types-internal.h +++ b/src/types-internal.h @@ -272,37 +272,50 @@ typedef struct getdns_dns_req { uint8_t name[256]; size_t name_len; - getdns_append_name_t append_name; - const uint8_t *suffix; - size_t suffix_len; - int suffix_appended; - uint16_t request_class; - /* canceled flag */ - int canceled; - /* context that owns the request */ struct getdns_context *context; + getdns_append_name_t append_name; + const uint8_t *suffix; + size_t suffix_len; + int suffix_appended : 1; + + /* canceled flag */ + int canceled : 1; + /* request extensions */ - int dnssec_return_status; - int dnssec_return_only_secure; - int dnssec_return_all_statuses; - int dnssec_return_validation_chain; + int dnssec_return_status : 1; + int dnssec_return_only_secure : 1; + int dnssec_return_all_statuses : 1; + int dnssec_return_validation_chain : 1; + int dnssec_return_full_validation_chain : 1; #ifdef DNSSEC_ROADBLOCK_AVOIDANCE - int dnssec_roadblock_avoidance; - int avoid_dnssec_roadblocks; + int dnssec_roadblock_avoidance : 1; + int avoid_dnssec_roadblocks : 1; #endif - int edns_cookies; - int edns_client_subnet_private; - uint16_t tls_query_padding_blocksize; - int return_call_reporting; - int add_warning_for_bad_dns; + int edns_cookies : 1; + int edns_client_subnet_private : 1; + int return_call_reporting : 1; + int add_warning_for_bad_dns : 1; /* Internally used by return_validation_chain */ - int dnssec_ok_checking_disabled; - int is_sync_request; + int dnssec_ok_checking_disabled : 1; + int is_sync_request : 1; + + /* The validating and freed variables are used to make sure a single + * code path is followed while processing a DNS request, even when + * callbacks are already fired whilst the registering/scheduling call + * (i.e. ub_resolve_event) has not returned yet. + * + * validating is touched by _getdns_get_validation_chain only and + * freed is touched by _getdns_submit_netreq only + */ + int validating : 1; + int *freed; + + uint16_t tls_query_padding_blocksize; /* internally scheduled request */ internal_cb_t internal_cb; diff --git a/src/util-internal.c b/src/util-internal.c index 0fe67591..1809c8cb 100644 --- a/src/util-internal.c +++ b/src/util-internal.c @@ -51,6 +51,7 @@ #include "gldns/str2wire.h" #include "gldns/gbuffer.h" #include "gldns/pkthdr.h" +#include "dnssec.h" getdns_return_t @@ -145,11 +146,12 @@ _getdns_sockaddr_to_dict(struct getdns_context *context, struct sockaddr_storage } getdns_dict * -_getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) +_getdns_rr_iter2rr_dict_canonical( + struct mem_funcs *mf, _getdns_rr_iter *i, uint32_t *orig_ttl) { getdns_dict *rr_dict, *rdata_dict; const uint8_t *bin_data; - size_t bin_size; + size_t bin_size, owner_len = 0, rdata_sz; uint32_t int_val = 0; enum wf_data_type { wf_int, wf_bindata, wf_special } val_type; _getdns_rdf_iter rdf_storage, *rdf; @@ -157,6 +159,10 @@ _getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) getdns_dict *repeat_dict = NULL; uint8_t ff_bytes[256]; uint16_t rr_type; + int canonicalize; + gldns_buffer gbuf; + getdns_bindata *bindata; + uint8_t *data; assert(i); if (!(rr_dict = _getdns_dict_create_with_mf(mf))) @@ -165,6 +171,12 @@ _getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) bin_data = _getdns_owner_if_or_as_decompressed( i, ff_bytes, &bin_size); + if (orig_ttl) { + if (bin_data != ff_bytes) + bin_data = memcpy(ff_bytes, bin_data, bin_size); + _dname_canonicalize2(ff_bytes); + owner_len = bin_size; + } /* question */ if (_getdns_rr_iter_section(i) == GLDNS_SECTION_QUESTION) { @@ -186,6 +198,9 @@ _getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) goto error; } + canonicalize = orig_ttl && _dnssec_rdata_to_canonicalize(rr_type) + && (i->rr_type + 12 <= i->nxt) /* To estimate rdata size */; + if (rr_type == GETDNS_RRTYPE_OPT) { int_val = gldns_read_uint16(i->rr_type + 6); @@ -210,7 +225,8 @@ _getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) (uint32_t) gldns_read_uint16(i->rr_type + 2)) || getdns_dict_set_int(rr_dict, "ttl", - (uint32_t) gldns_read_uint32(i->rr_type + 4)) || + ( orig_ttl && rr_type != GETDNS_RRTYPE_RRSIG + ? *orig_ttl : (uint32_t) gldns_read_uint32(i->rr_type + 4))) || _getdns_dict_set_const_bindata( rr_dict, "name", bin_size, bin_data)) { @@ -220,15 +236,21 @@ _getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) if (!(rdata_dict = _getdns_dict_create_with_mf(mf))) return NULL; - if (i->rr_type + 10 <= i->nxt) { + if (i->rr_type + 10 <= i->nxt && !canonicalize) { bin_size = i->nxt - (i->rr_type + 10); bin_data = i->rr_type + 10; if (_getdns_dict_set_const_bindata( rdata_dict, "rdata_raw", bin_size, bin_data)) goto rdata_error; } + if (canonicalize) + rdata_sz = 0; + for ( rdf = _getdns_rdf_iter_init(&rdf_storage, i) ; rdf; rdf = _getdns_rdf_iter_next(rdf)) { + if (canonicalize && !(rdf->rdd_pos->type & GETDNS_RDF_DNAME)) { + rdata_sz += rdf->nxt - rdf->pos; + } if (rdf->rdd_pos->type & GETDNS_RDF_INTEGER) { val_type = wf_int; switch (rdf->rdd_pos->type & GETDNS_RDF_FIXEDSZ) { @@ -247,6 +269,12 @@ _getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) bin_data = _getdns_rdf_if_or_as_decompressed( rdf, ff_bytes, &bin_size); + if (canonicalize) { + if (bin_data != ff_bytes) + bin_data = memcpy(ff_bytes, bin_data, bin_size); + _dname_canonicalize2(ff_bytes); + rdata_sz += bin_size; + } } else if (rdf->rdd_pos->type & GETDNS_RDF_BINDATA) { val_type = wf_bindata; if (rdf->rdd_pos->type & GETDNS_RDF_FIXEDSZ) { @@ -376,6 +404,23 @@ _getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) if (_getdns_dict_set_this_dict(rr_dict, "rdata", rdata_dict)) goto rdata_error; + if (canonicalize && rdata_sz) { + if (!(data = GETDNS_XMALLOC( + *mf, uint8_t, owner_len + 10 + rdata_sz))) + return rr_dict; + + gldns_buffer_init_frm_data(&gbuf, data, owner_len+10+rdata_sz); + if (_getdns_rr_dict2wire(rr_dict, &gbuf) || + gldns_buffer_position(&gbuf) != owner_len + 10 + rdata_sz || + !(bindata = GETDNS_MALLOC(*mf, struct getdns_bindata))) { + GETDNS_FREE(*mf, data); + return rr_dict; + } + bindata->size = rdata_sz; + bindata->data = memmove(data, data + owner_len + 10, rdata_sz); + (void) _getdns_dict_set_this_bindata(rr_dict, + "/rdata/rdata_raw", bindata); + } return rr_dict; rdata_error: @@ -387,6 +432,12 @@ error: return NULL; } +getdns_dict * +_getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i) +{ + return _getdns_rr_iter2rr_dict_canonical(mf, i, NULL); +} + int _getdns_dname_equal(const uint8_t *s1, const uint8_t *s2) { diff --git a/src/util-internal.h b/src/util-internal.h index 37e6f73b..d3c05ab7 100644 --- a/src/util-internal.h +++ b/src/util-internal.h @@ -41,6 +41,7 @@ #include "config.h" #include "context.h" #include "rr-iter.h" +#include #define UNCONST_UINT8_p uint8_t * @@ -95,6 +96,9 @@ getdns_return_t _getdns_dict_set_this_list(getdns_dict *dict, getdns_return_t _getdns_dict_set_const_bindata(getdns_dict *dict, const char *name, size_t size, const void *data); +getdns_return_t _getdns_dict_set_this_bindata(getdns_dict *dict, + const char *name, getdns_bindata *child_bindata); + /** * private function (API users should not be calling this), this uses library * routines to make a copy of the list - would be faster to make the copy directly @@ -138,6 +142,10 @@ getdns_return_t _getdns_sockaddr_to_dict(struct getdns_context *context, getdns_dict * _getdns_rr_iter2rr_dict(struct mem_funcs *mf, _getdns_rr_iter *i); +getdns_dict * +_getdns_rr_iter2rr_dict_canonical( + struct mem_funcs *mf, _getdns_rr_iter *i, uint32_t *orig_ttl); + struct getdns_dns_req; struct getdns_dict *_getdns_create_getdns_response(struct getdns_dns_req *completed_request); @@ -178,5 +186,22 @@ INLINE getdns_eventloop_event *getdns_eventloop_event_init( #define GETDNS_SCHEDULE_EVENT(loop, fd, timeout, event) \ do { (loop)->vmt->schedule((loop),(fd),(timeout),(event)); } while(0) +INLINE void _dname_canonicalize(const uint8_t *src, uint8_t *dst) +{ + const uint8_t *next_label; + + while (*src) { + next_label = src + *src + 1; + *dst++ = *src++; + while (src < next_label) + *dst++ = (uint8_t)tolower((unsigned char)*src++); + } +} + +INLINE void _dname_canonicalize2(uint8_t *dname) +{ + _dname_canonicalize(dname, dname); +} + #endif /* util-internal.h */