gocomplete: better pakcages listing

use go/build package
only read one level of packages, and not all packages
This commit is contained in:
Eyal Posener 2017-05-19 00:11:30 +03:00
parent b3f5ec22d3
commit 3555a6948a
1 changed files with 46 additions and 30 deletions

View File

@ -1,50 +1,66 @@
package main package main
import ( import (
"bytes" "go/build"
"encoding/json" "io/ioutil"
"os/exec" "os"
"strings" "path/filepath"
"github.com/posener/complete" "github.com/posener/complete"
) )
const goListFormat = `{"Name": "{{.Name}}", "Path": "{{.Dir}}", "FilesString": "{{.GoFiles}}"}`
func predictPackages(a complete.Args) (prediction []string) { func predictPackages(a complete.Args) (prediction []string) {
dir := a.Directory() for {
pkgs := listPackages(dir) prediction = complete.PredictFilesSet(listPackages(a)).Predict(a)
files := make([]string, 0, len(pkgs)) // if the number of prediction is not 1, we either have many results or
for _, p := range pkgs { // have no results, so we return it.
files = append(files, p.Path) if len(prediction) != 1 {
return
}
// if the result is only one item, we might want to recursively check
// for more accurate results.
if prediction[0] == a.Last {
return
}
// only try deeper, if the one item is a directory
if stat, err := os.Stat(prediction[0]); err != nil || !stat.IsDir() {
return
}
a.Last = prediction[0]
} }
return complete.PredictFilesSet(files).Predict(a)
} }
type pack struct { func listPackages(a complete.Args) (dirctories []string) {
Name string dir := a.Directory()
Path string complete.Log("listing packages in %s", dir)
FilesString string // import current directory
Files []string pkg, err := build.ImportDir(dir, 0)
}
func listPackages(dir string) (pkgs []pack) {
dir = strings.TrimRight(dir, "/") + "/..."
out, err := exec.Command("go", "list", "-f", goListFormat, dir).Output()
if err != nil { if err != nil {
complete.Log("failed importing directory %s: %s", dir, err)
return return
} }
lines := bytes.Split(out, []byte("\n")) dirctories = append(dirctories, pkg.Dir)
for _, line := range lines {
var p pack // import subdirectories
err := json.Unmarshal(line, &p) files, err := ioutil.ReadDir(dir)
if err != nil { if err != nil {
complete.Log("failed reading directory %s: %s", dir, err)
return
}
for _, f := range files {
if !f.IsDir() {
continue continue
} }
// parse the FileString from a string "[file1 file2 file3]" to a list of files pkg, err := build.ImportDir(filepath.Join(dir, f.Name()), 0)
p.Files = strings.Split(strings.Trim(p.FilesString, "[]"), " ") if err != nil {
pkgs = append(pkgs, p) complete.Log("failed importing subdirectory %s: %s", filepath.Join(dir, f.Name()), err)
continue
}
dirctories = append(dirctories, pkg.Dir)
} }
return return
} }