From ef86d0d15aed5ac0fbb8b71772590090441415f1 Mon Sep 17 00:00:00 2001 From: Pietro Gagliardi Date: Wed, 12 Mar 2014 14:43:40 -0400 Subject: [PATCH] Gave Listboxes a border on Windows by implementing the subset of LBS_STANDARD we want, not just WS_VSCROLL. This will also allow us to have selection changed events later. --- sysdata_windows.go | 5 +++-- todo.md | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/sysdata_windows.go b/sysdata_windows.go index 3cc5730..fbba1fd 100644 --- a/sysdata_windows.go +++ b/sysdata_windows.go @@ -83,9 +83,10 @@ var classTypes = [nctypes]*classData{ c_listbox: &classData{ name: "LISTBOX", // TODO also _WS_HSCROLL? - style: _WS_VSCROLL | controlstyle, + // we don't use _LBS_STANDARD because it sorts + style: _LBS_NOTIFY | _WS_BORDER | _WS_VSCROLL | controlstyle, xstyle: 0 | controlxstyle, - altStyle: _LBS_EXTENDEDSEL | _WS_VSCROLL | controlstyle, + altStyle: _LBS_EXTENDEDSEL | _LBS_NOTIFY | _WS_BORDER | _WS_VSCROLL | controlstyle, font: &controlFont, appendMsg: _LB_ADDSTRING, insertBeforeMsg: _LB_INSERTSTRING, diff --git a/todo.md b/todo.md index cd48250..57d2ff2 100644 --- a/todo.md +++ b/todo.md @@ -7,8 +7,8 @@ so I don't forget: - character-limited entry fields, numeric entry fields, multiline entry fields - possible rename of LineEdit? - especially for password fields - NewPasswordEntry()? -- [Windows, Mac OS X] should ListBox have a border style? - - [Windows] a different border on LineEdits? +- [Mac OS X] Listbox should have a border style + - [Windows] a different border on LineEdits and Listboxes? - padding and spacing in Stack - allow Combobox to have initial settings - Combobox and Listbox insertions and deletions should allow bulk (...string)