From cf604f7b05bf003f0cb9a28980960baf1271ebbc Mon Sep 17 00:00:00 2001 From: Pietro Gagliardi Date: Thu, 14 Aug 2014 13:44:24 -0400 Subject: [PATCH] Fine-tuned margin/spacing values on Mac OS X. Also more future plans. --- redo/container_darwin.go | 11 +++++------ redo/future | 7 +++++++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/redo/container_darwin.go b/redo/container_darwin.go index a1096f1..4936a62 100644 --- a/redo/container_darwin.go +++ b/redo/container_darwin.go @@ -39,13 +39,12 @@ func containerResized(data unsafe.Pointer, width C.intptr_t, height C.intptr_t) c.resize(0, 0, int(width), int(height)) } -// THIS IS A GUESS. TODO. -// The only indication that this is remotely correct is the Auto Layout Guide implying that 12 pixels is the "Aqua space". +// These are based on measurements from Interface Builder. const ( - macXMargin = 12 - macYMargin = 12 - macXPadding = 12 - macYPadding = 12 + macXMargin = 20 + macYMargin = 20 + macXPadding = 8 + macYPadding = 8 ) func (c *container) beginResize() (d *sizing) { diff --git a/redo/future b/redo/future index 71c56b9..5e65850 100644 --- a/redo/future +++ b/redo/future @@ -33,7 +33,14 @@ Mac OS X // in the other case, the most correct thing would be for Label to be aligned to the alignment rect, but I can't get this working, and it looks fine as it is anyway other controls same rules? checkboxes seem damning... + ok in general + spacing applies to alignment rects + will conflict with Stack/Grid precalculation + unless we resize the control and move it around to suit + Tabs seem to have differnt margin rules + need to check padding rules within Tabs TextField + text alignment (think labels and checkboxes) may be a perpetual problem though add events (figure out which of the following are appropriate: changed, enter pressed) provide some facility to mark invalid values figure out numerics because you CAN paste into numeric boxes on Windows and GTK+ has no built-in number validator as far as I know