From c20e3a261195889029d71e9490674fe48104a170 Mon Sep 17 00:00:00 2001 From: Pietro Gagliardi Date: Sat, 15 Feb 2014 15:41:50 -0500 Subject: [PATCH] More TODO reduction. --- common_windows.go | 3 +-- winerrors.md | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/common_windows.go b/common_windows.go index e541c7b..5ebf0a4 100644 --- a/common_windows.go +++ b/common_windows.go @@ -26,8 +26,7 @@ const ( _TRUE = 1 // from windef.h ) -// TODO pull the thanks for these three from the old wingo source -// TODO put these in windows.go +// In MSDN, _LPARAM and _LRESULT are listed as signed pointers, however their interpretation is message-specific. Ergo, just cast them yourself; it'll be the same. (Thanks to Tv` in #go-nuts for helping me realize this.) type _WPARAM uintptr type _LPARAM uintptr type _LRESULT uintptr diff --git a/winerrors.md b/winerrors.md index fd401ca..8fe2cf3 100644 --- a/winerrors.md +++ b/winerrors.md @@ -1,6 +1,6 @@ - all SendMessage() calls - BM_GETCHECK (sysData.isChecked()) -- WM_GETTEXTLENGTH (LRESULT is unsinged so) (sysData.text()) +- WM_GETTEXTLENGTH (LRESULT is signed but we treat it as unsigned and MSDN says nothing about error returns) (sysData.text()) - WM_GETTEXT (WM_GETTEXTLENGTH docs say its result may be larger than the actual length, so we can't use that) (sysData.text()) - CB_GETCURSEL/LB_GETCURSEL (sysData.selectedIndex()) - LB_GETSELCOUNT/LB_GETSELITEMS (LB_ERR is returned if this is a single-selection listbox; are there actual errors?) (sysData.selectedIndices())