interesting
/
andlabs-ui
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed TODOs about sign extension on Windows; situation resolved.

This commit is contained in:
Pietro Gagliardi 2014-06-04 19:06:16 -04:00
parent ec5c4594b2
commit bd08967a5a
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
area_windows.go
View File

@ -462,12 +462,10 @@ func areaMouseEvent(s *sysData, button uint, up bool, wparam _WPARAM, lparam _LP
} else if button != 0 { // don't run the click counter if the mouse was only moved } else if button != 0 { // don't run the click counter if the mouse was only moved
me.Down = button me.Down = button
// this returns a LONG, which is int32, but we don't need to worry about the signedness because for the same bit widths and two's complement arithmetic, s1-s2 == u1-u2 if bits(s1)==bits(s2) and bits(u1)==bits(u2) (and Windows requires two's complement: http://blogs.msdn.com/b/oldnewthing/archive/2005/05/27/422551.aspx) // this returns a LONG, which is int32, but we don't need to worry about the signedness because for the same bit widths and two's complement arithmetic, s1-s2 == u1-u2 if bits(s1)==bits(s2) and bits(u1)==bits(u2) (and Windows requires two's complement: http://blogs.msdn.com/b/oldnewthing/archive/2005/05/27/422551.aspx)
// TODO actually will this break with negative numbers on systems where uintptr is 64 bits wide? only if the ABI doesn't sign-extend... // signedness isn't much of an issue for these calls anyway because http://stackoverflow.com/questions/24022225/what-are-the-sign-extension-rules-for-calling-windows-api-functions-stdcall-t and that we're only using unsigned values (think back to how you (didn't) handle signedness in assembly language) AND because of the above AND because the statistics below (time interval and width/height) really don't make sense if negative
time, _, _ := _getMessageTime.Call() time, _, _ := _getMessageTime.Call()
// this returns a UINT, which is uint32; don't worry about the smaller size as sign extension won't matter here (see the above)
maxTime, _, _ := _getDoubleClickTime.Call() maxTime, _, _ := _getDoubleClickTime.Call()
// ignore zero returns and errors; MSDN says zero will be returned on error but that GetLastError() is meaningless // ignore zero returns and errors; MSDN says zero will be returned on error but that GetLastError() is meaningless
// these should be unsigned... TODO MSDN doesn't say and GetSystemMetrics() returns an int (int32)
xdist, _, _ := _getSystemMetrics.Call(_SM_CXDOUBLECLK) xdist, _, _ := _getSystemMetrics.Call(_SM_CXDOUBLECLK)
ydist, _, _ := _getSystemMetrics.Call(_SM_CYDOUBLECLK) ydist, _, _ := _getSystemMetrics.Call(_SM_CYDOUBLECLK)
me.Count = s.clickCounter.click(button, me.Pos.X, me.Pos.Y, me.Count = s.clickCounter.click(button, me.Pos.X, me.Pos.Y,

2
common_windows.go
View File

@ -62,7 +62,7 @@ type _RECT struct {
} }
// Go doesn't allow negative constants to be forced into unsigned types at compile-time; this will do it at runtime. // Go doesn't allow negative constants to be forced into unsigned types at compile-time; this will do it at runtime.
// TODO make sure sign extension works fine here (check Go's rules and ABI sign extension rules) // This is safe; see http://stackoverflow.com/questions/24022225/what-are-the-sign-extension-rules-for-calling-windows-api-functions-stdcall-t
func negConst(c int) uintptr { func negConst(c int) uintptr {
return uintptr(c) return uintptr(c)
} }