From 9a1eb65f9a207a1c03e49cc9e281e7a8fd5e40a9 Mon Sep 17 00:00:00 2001 From: Pietro Gagliardi Date: Mon, 28 Apr 2014 12:13:06 -0400 Subject: [PATCH] Moved TODOs about stripping non-Windows XP constants to future plans; also reworded a comment in comctl_windows.go. --- comctl_windows.go | 3 +-- controls_windows.go | 2 -- futureplans.md | 1 + 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/comctl_windows.go b/comctl_windows.go index 7c336be..bb60779 100644 --- a/comctl_windows.go +++ b/comctl_windows.go @@ -9,8 +9,7 @@ import ( "io/ioutil" ) -// pretty much every constant here except _WM_USER is from commctrl.h -// TODO for all: filter out constants not available in Windows XP +// pretty much every constant here except _WM_USER is from commctrl.h, except where noted var ( // TODO deinitialize at program end? diff --git a/controls_windows.go b/controls_windows.go index 581c1a7..991e879 100644 --- a/controls_windows.go +++ b/controls_windows.go @@ -7,8 +7,6 @@ import ( // "unsafe" ) -// TODO for all: filter any not provided in Windows XP - // Button styles. const ( // from winuser.h diff --git a/futureplans.md b/futureplans.md index 71c66ba..5437bd9 100644 --- a/futureplans.md +++ b/futureplans.md @@ -72,6 +72,7 @@ far off: - change the MsgBox() calls to encourage good alert dialog design??????? maybe? TODO - make gcc (Unix)/clang (Mac OS X) pedantic about warnings/errors; also -Werror - problem: cgo-generated files trip -Werror up; I can't seem to turn off unused argument warnings with the -Wall/-Wextra/-pedantic options +- strip non-Windows XP constants from the Windows constants files? or at least just comment them all out... big things: - make sure every sysData function only performs a single invocation to uitask; see http://blogs.msdn.com/b/oldnewthing/archive/2005/10/10/479124.aspx#479182