interesting
/
andlabs-ui
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

"Fixed" the zero-size Combobox drop-down on Windows by having Windows fix it for us (and since we did everything we need to do to get it to fix it for us, it was already fixed!).

This commit is contained in:
Pietro Gagliardi 2014-04-10 12:53:23 -04:00
parent 013e8707da
commit 865a0ec662
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
prefsize_windows.go
View File

@ -42,6 +42,10 @@ var stdDlgSizes = [nctypes]dlgunits{
height: 10, height: 10,
}, },
c_combobox: dlgunits{ c_combobox: dlgunits{
// technically the height of a combobox has to include the drop-down list (this is a historical accident: originally comboboxes weren't drop-down)
// but since we're forcing Common Controls version 6, we can take advantage of one of its mechanisms to automatically fix this mistake (bad practice but whatever)
// see also: http://blogs.msdn.com/b/oldnewthing/archive/2006/03/10/548537.aspx
// note that the Microsoft guidelines pages don't take the list size into account
longest: true, longest: true,
height: 12, // from the Visual Studio 2012 offline docs's Win32 layout page; the online page above says 14 height: 12, // from the Visual Studio 2012 offline docs's Win32 layout page; the online page above says 14
}, },

2
todo.md
View File

@ -14,8 +14,6 @@ important things:
- LineEdit heights on Windows seem too big; either that or LineEdit, Button, and Label text is not vertically centered properly - LineEdit heights on Windows seem too big; either that or LineEdit, Button, and Label text is not vertically centered properly
- are Checkboxes and Comboboxes too small? - are Checkboxes and Comboboxes too small?
- Cocoa has similar margining issues (like Comboboxes having margins) - Cocoa has similar margining issues (like Comboboxes having margins)
- sometimes the size of the drop-down part of a Combobox becomes 0 or 1 or some other impossibly small value on Windows
- http://blogs.msdn.com/b/oldnewthing/archive/2006/03/10/548537.aspx
- make gcc (Unix)/clang (Mac OS X) pedantic about warnings/errors; also -Werror - make gcc (Unix)/clang (Mac OS X) pedantic about warnings/errors; also -Werror
- problem: cgo-generated files trip -Werror up; I can't seem to turn off unused argument warnings with the -Wall/-Wextra/-pedantic options - problem: cgo-generated files trip -Werror up; I can't seem to turn off unused argument warnings with the -Wall/-Wextra/-pedantic options
- make sure scrollbars in Listbox work identically on all platforms (specifically the existence and autohiding of both horizontal and vertical scrollbars) - make sure scrollbars in Listbox work identically on all platforms (specifically the existence and autohiding of both horizontal and vertical scrollbars)