From 69b63dbbb8762ba53f260959a753f83cf35ccf47 Mon Sep 17 00:00:00 2001
From: Pietro Gagliardi <pietro10@mac.com>
Date: Tue, 8 Apr 2014 00:21:12 -0400
Subject: [PATCH] Slowed GTK+ indeterminate Progressbars down.

---
 sysdata_unix.go | 6 +++---
 todo.md         | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sysdata_unix.go b/sysdata_unix.go
index 50b51cd..8e61a4f 100644
--- a/sysdata_unix.go
+++ b/sysdata_unix.go
@@ -296,8 +296,8 @@ func (s *sysData) progressPulse() {
 	var ticker *time.Ticker
 	var tickchan <-chan time.Time
 
-	// the default on Windows
-	const pulseRate = 30 * time.Millisecond
+	// the pulse rate used by Zenity (https://git.gnome.org/browse/zenity/tree/src/progress.c#n69 for blob cbffe08e8337ba1375a0ac7210eff5a2e4313bb8)
+	const pulseRate = 100 * time.Millisecond
 
 	for {
 		select {
@@ -305,7 +305,7 @@ func (s *sysData) progressPulse() {
 			if start {
 				ticker = time.NewTicker(pulseRate)
 				tickchan = ticker.C
-				pulse()			// start the pulse animation now, not 30ms later
+				pulse()			// start the pulse animation now, not 100ms later
 			} else {
 				if ticker != nil {
 					ticker.Stop()
diff --git a/todo.md b/todo.md
index e1a327b..822e421 100644
--- a/todo.md
+++ b/todo.md
@@ -72,7 +72,7 @@ super ultra important things:
 - despite us explicitly clearing the clip area on Windows, Area still doesn't seem to draw alpha bits correctly... it appears as if we are drawing over the existing image each time
 - on Windows, Shift+(num pad key) triggers the shifted key code when num lock is off; will need to reorder key code tests on all platforms to fix this
 - pressing global keycodes (including kwin's zoom in/out) when running the keyboard test in wine causes the Area to lose keyboard focus; this doesn't happen on the GTK+ version (fix the Windows version to behave like the GTK+ version)
-- GTK+ indefinite progress bar animation is too fast; HIG doesn't list a preferred speed?
+- GTK+ indefinite progress bar animation is choppy: make sure the speed we have now is the conventional speed for GTK+ programs (HIG doesn't list any) and that the choppiness is correct
 - Message boxes are not application-modal on some platforms
 - cast all objc_msgSend() direct invocations to the approrpiate types; this is how you're supposed to do things: https://developer.apple.com/library/ios/documentation/General/Conceptual/CocoaTouch64BitGuide/ConvertingYourAppto64-Bit/ConvertingYourAppto64-Bit.html http://lists.apple.com/archives/objc-language/2014/Jan/msg00011.html http://lists.apple.com/archives/cocoa-dev/2006/Feb/msg00753.html and many others
 - Area drawing assumes that i.Pix[0] is the first pixel; this might not be the case (and the current documentation for AreaHandler.Paint() allows it). Fix it.