interesting
/
andlabs-ui
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Switched to alpha-premultiplied image data for Areas on Mac OS X. This is the easiest change; it involves removing one bit flag from the NSBitmapImageRep constructor (the other changes are indentation changes).

This commit is contained in:
Pietro Gagliardi 2014-04-11 16:17:06 -04:00
parent 6f0d114a8b
commit 5581d41f88
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
bleh_darwin.m
View File

@ -270,17 +270,17 @@ void drawImage(void *pixels, int64_t width, int64_t height, int64_t stride, int6
bitmap = objc_msgSend(c_NSBitmapImageRep, s_alloc);
planes[0] = (unsigned char *) pixels;
bitmap = objc_msgSend(bitmap, s_initWithBitmapDataPlanes,
planes, /* initWithBitmapDataPlanes: */
(NSInteger) width, /* pixelsWide: */
(NSInteger) height, /* pixelsHigh: */
(NSInteger) 8, /* bitsPerSample: */
(NSInteger) 4, /* samplesPerPixel: */
(BOOL) YES, /* hasAlpha: */
(BOOL) NO, /* isPlanar: */
NSCalibratedRGBColorSpace, /* colorSpaceName: | TODO NSDeviceRGBColorSpace? */
(NSBitmapFormat) NSAlphaNonpremultipliedBitmapFormat, /* bitmapFormat: | this is where the flag for placing alpha first would go if alpha came first; the default is alpha last, which is how we're doing things (otherwise the docs say "Color planes are arranged in the standard order—for example, red before green before blue for RGB color.") */
(NSInteger) stride, /* bytesPerRow: */
(NSInteger) 32); /* bitsPerPixel: */
planes, /* initWithBitmapDataPlanes: */
(NSInteger) width, /* pixelsWide: */
(NSInteger) height, /* pixelsHigh: */
(NSInteger) 8, /* bitsPerSample: */
(NSInteger) 4, /* samplesPerPixel: */
(BOOL) YES, /* hasAlpha: */
(BOOL) NO, /* isPlanar: */
NSCalibratedRGBColorSpace, /* colorSpaceName: | TODO NSDeviceRGBColorSpace? */
(NSBitmapFormat) 0, /* bitmapFormat: | this is where the flag for placing alpha first would go if alpha came first; the default is alpha last, which is how we're doing things (otherwise the docs say "Color planes are arranged in the standard order—for example, red before green before blue for RGB color."); this is also where the flag for non-premultiplied colors would go if we used it (the default is alpha-premultiplied) */
(NSInteger) stride, /* bytesPerRow: */
(NSInteger) 32); /* bitsPerPixel: */
/* TODO this CAN fail; check error */
objc_msgSend_drawInRect(bitmap, s_drawInRect,
NSMakeRect((CGFloat) xdest, (CGFloat) ydest,