interesting
/
andlabs-ui
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cleaned up/removed some (not all) TODOs in init_windows.go.

This commit is contained in:
Pietro Gagliardi 2014-04-28 12:44:07 -04:00
parent b673f3d31b
commit 50dc1722da
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
init_windows.go
View File

@ -13,7 +13,7 @@ var (
nCmdShow int nCmdShow int
) )
// TODO is this trick documented in MSDN? // TODO is this documented?
func getWinMainhInstance() (err error) { func getWinMainhInstance() (err error) {
r1, _, err := kernel32.NewProc("GetModuleHandleW").Call(uintptr(_NULL)) r1, _, err := kernel32.NewProc("GetModuleHandleW").Call(uintptr(_NULL))
if r1 == 0 { // failure if r1 == 0 { // failure
@ -23,7 +23,7 @@ func getWinMainhInstance() (err error) {
return nil return nil
} }
// TODO this is what MinGW-w64's crt (svn revision TODO) does; is it best? is any of this documented anywhere on MSDN? // this is what MinGW-w64 does (for instance, http://sourceforge.net/p/mingw-w64/code/6604/tree/trunk/mingw-w64-crt/crt/crtexe.c#l320); Burgundy in irc.freenode.net/#winapi said that the Visual C++ runtime does this too
func getWinMainnCmdShow() { func getWinMainnCmdShow() {
var info struct { var info struct {
cb uint32 cb uint32
@ -74,6 +74,6 @@ func doWindowsInit() (err error) {
if err != nil { if err != nil {
return fmt.Errorf("error initializing Common Controls (comctl32.dll): %v", err) return fmt.Errorf("error initializing Common Controls (comctl32.dll): %v", err)
} }
// TODO others // others go here
return nil // all ready to go return nil // all ready to go
} }