interesting
/
andlabs-ui
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed Area scrollbars on Windows sometimes stopping a pixel shy of the actual end of the scrollbar.

This commit is contained in:
Pietro Gagliardi 2014-04-29 11:56:59 -04:00
parent 8813788c14
commit 3e047ba174
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
area_windows.go
View File

@ -382,8 +382,6 @@ func scrollArea(s *sysData, wparam _WPARAM, which uintptr) {
if r1 == 0 { // failure if r1 == 0 { // failure
panic(fmt.Errorf("error updating Area after scrolling: %v", err)) panic(fmt.Errorf("error updating Area after scrolling: %v", err))
} }
// TODO in some cases wine will show a thumb one pixel away from the advance arrow button if going to the end; the values are correct though... weirdness in wine or something I never noticed about Windows?
} }
func adjustAreaScrollbars(s *sysData) { func adjustAreaScrollbars(s *sysData) {
@ -400,7 +398,7 @@ func adjustAreaScrollbars(s *sysData) {
si.cbSize = uint32(unsafe.Sizeof(si)) si.cbSize = uint32(unsafe.Sizeof(si))
si.fMask = _SIF_RANGE | _SIF_PAGE si.fMask = _SIF_RANGE | _SIF_PAGE
si.nMin = 0 si.nMin = 0
si.nMax = int32(s.areawidth) si.nMax = int32(s.areawidth - 1) // the max point is inclusive, so we have to pass in the last valid value, not the first invalid one (see http://blogs.msdn.com/b/oldnewthing/archive/2003/07/31/54601.aspx); if we don't, we get weird things like the scrollbar sometimes showing one extra scroll position at the end that you can never scroll to
si.nPage = uint32(cwid) si.nPage = uint32(cwid)
_setScrollInfo.Call( _setScrollInfo.Call(
uintptr(s.hwnd), uintptr(s.hwnd),
@ -411,7 +409,7 @@ func adjustAreaScrollbars(s *sysData) {
si.cbSize = uint32(unsafe.Sizeof(si)) // MSDN sample code does this a second time; let's do it too to be safe si.cbSize = uint32(unsafe.Sizeof(si)) // MSDN sample code does this a second time; let's do it too to be safe
si.fMask = _SIF_RANGE | _SIF_PAGE si.fMask = _SIF_RANGE | _SIF_PAGE
si.nMin = 0 si.nMin = 0
si.nMax = int32(s.areaheight) si.nMax = int32(s.areaheight - 1)
si.nPage = uint32(cht) si.nPage = uint32(cht)
_setScrollInfo.Call( _setScrollInfo.Call(
uintptr(s.hwnd), uintptr(s.hwnd),