interesting
/
andlabs-ui
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed some Windows Popover redraw issues.

This commit is contained in:
Pietro Gagliardi 2014-10-10 21:26:51 -04:00
parent df45a8b035
commit 152f2a2ccd
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
windowspopover/main.c
View File

@ -177,14 +177,8 @@ LRESULT CALLBACK popoverproc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
if (dc == NULL)
xpanic("error getting Popover window DC for drawing border", GetLastError());
region = makePopoverRegion(dc, width, height);
// TODO isolate the brush name to a constant
// unfortunately FillRgn() doesn't document the COLOR+1 trick as working there
brush = GetSysColorBrush(COLOR_BTNFACE);
if (brush == NULL)
xpanic("error getting Popover background brush", GetLastError());
if (FillRgn(dc, region, brush) == 0)
xpanic("error drawing Popover background", GetLastError());
// TODO use a system color brush?
// don't call FillRgn(); WM_ERASEBKGND seems to do this to the non-client area for us already :S (TODO confirm)
// TODO arrow is black in wine
brush = (HBRUSH) GetStockObject(BLACK_BRUSH);
if (brush == NULL)
xpanic("error getting Popover border brush", GetLastError());
@ -241,7 +235,6 @@ LRESULT CALLBACK popoverproc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
case msgPopoverPrepareLeftRight:
case msgPopoverPrepareTopBottom:
// TODO window edge detection
// TODO if window was partially offscreen and then moved onscreen, client rect gets fucked up
{
RECT r;
LONG x, y;