From 10e9f6b927c5208fce290fea346a8a2ad7ac3fa3 Mon Sep 17 00:00:00 2001 From: Pietro Gagliardi Date: Sat, 1 Mar 2014 18:04:09 -0500 Subject: [PATCH] Fixed non-minimizeable windows in Mac OS X; it was a simple copy-paste fail. --- sysdata_darwin.go | 2 +- todo.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdata_darwin.go b/sysdata_darwin.go index 797fe70..37352a3 100644 --- a/sysdata_darwin.go +++ b/sysdata_darwin.go @@ -68,7 +68,7 @@ var classTypes = [nctypes]*classData{ win = objc_msgSend_rect_uint_uint_bool(win, _initWithContentRect, 0, 0, 100, 100, - NSTitledWindowMask | NSClosableWindowMask | NSClosableWindowMask | NSResizableWindowMask, + NSTitledWindowMask | NSClosableWindowMask | NSMiniaturizableWindowMask | NSResizableWindowMask, 2, // NSBackingStoreBuffered - the only backing store method that Apple says we should use (the others are legacy) C.BOOL(C.YES)) // defer creation of device until we show the window objc_setDelegate(win, appDelegate) diff --git a/todo.md b/todo.md index 943620f..1a77ded 100644 --- a/todo.md +++ b/todo.md @@ -26,7 +26,7 @@ important things: - ui.Go() should exit when the main() you pass in exits - because the main event loop is not called if initialization fails, it is presently impossible for MsgBoxError() to work if UI initialization fails; this basically means we cannot allow initializiation to fail on Mac OS X if we want to be able to report UI init failures to the user with one - Cocoa coordinates have (0,0) at the bottom left: need to fix this somehow -- Cocoa windows seem to ignore the minizeable flag and cannot be live-resized +- Cocoa windows cannot be live-resized - there's no GTK+ error handling whatsoever; we need to figure out how it works - make sure GTK+ documentation point differences don't matter - button sizes and LineEdit sizes on Windows seem too big; Comboboxes have margins